Message ID | 20231016001227.2717180-39-kmatsui@gcc.gnu.org |
---|---|
State | Unresolved |
Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp3160093vqb; Sun, 15 Oct 2023 17:27:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF6t/oYzDXDaZa9NVrnaWd3k1ZNF3cD1yFm2C7sZtlE6C15YvL9yGvIgSjNhOLdc0TtCnaL X-Received: by 2002:ad4:5c87:0:b0:66d:34a8:3ed0 with SMTP id o7-20020ad45c87000000b0066d34a83ed0mr9215334qvh.26.1697416022016; Sun, 15 Oct 2023 17:27:02 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1697416022; cv=pass; d=google.com; s=arc-20160816; b=Xv4r7aaVMebklwwUhGy63HL+N7Ed1zgbXNgyPcgkdfp9ipkjZI/O+akyIlzCOiHDHR 6bv/JKesrp8RGG6OitodzZyFI7j1gcRkB8066E7f+ckouh7yEVJEbU8RFjGFWia/zTFw R2Sx69EIvqccU3RWNglnaiKJtZ5cscW3FXD5cPJJ4If6c5XzxU8ixOUWWbCW4HB0GLqf BwPmJO0r1QihHzBZWrHDQweIWPnx3e+GOAI1T9FZLryi/2LAQqGHz5y76lvg4qU6Eg2k bLiTHmXhlvgAv+BdJbvIAXl/EvlOq+/97uea8jBnY0EFbcDQig28rGVXWhQmgR1gbf63 uYiA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:arc-filter:dmarc-filter:delivered-to:dkim-signature :dkim-filter; bh=cQfm2Z2CbE9/tDAPdRh2GGqLZxuO7lj7PQBaV9C0Mb0=; fh=kSSy/oyUXqQD15FLeKdymIgDBFPFITPA1Gj52CNOxRQ=; b=Ro9s9+c9r8EO6plocY6sBr0pXUB0QOmWO+JmuZO9QgaX3th8aky7jovhGIQ7+IS0Yy ulHOFStHojPIe67nhW1roTBCzp2GRlpQavNqh4svvIoIJXhX1yLnpt4zxd+uvJ5kla/A cxJnLnXIau/9KlyoTko3XWOJLm/QJJSbUEmbsZJ3XE9sZK6KdLnjBjhjqEZDaF2z/L1d f2bXI/2W3K4wH2oJNc1CJUxeBOxizroqXOGmBlvMRuMvC8puasrBA+GiIksfCHP8HB3b BxFqMgFYoFf3fIfJSpFM/gE9cZNoefOrhPf3esaMRydFHJkY8Tp0Gu1zumv5TdWurOXF BZSQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=IXRgnB7z; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id c4-20020a05620a11a400b007759f94721asi4504148qkk.209.2023.10.15.17.27.01 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Oct 2023 17:27:02 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=IXRgnB7z; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B63173858418 for <ouuuleilei@gmail.com>; Mon, 16 Oct 2023 00:27:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B63173858418 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1697416021; bh=cQfm2Z2CbE9/tDAPdRh2GGqLZxuO7lj7PQBaV9C0Mb0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=IXRgnB7z0KUk8DJ/83TdSw6PlYRK+teqWG+IOniI5CEGCefFhWpEcPWPIuiJviul5 o3TbrBm0nZ7w5GA4E+G7nNnXGkb+ENP3UHKPzM53LfOMcAiM1g8vmlEQo8OsdAzFX5 vY1SwwZwfH7P92WGVFCd6FVt1DBoy377kA0djTyg= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0b-00641c01.pphosted.com (mx0b-00641c01.pphosted.com [205.220.177.146]) by sourceware.org (Postfix) with ESMTPS id CF9DA3857027; Mon, 16 Oct 2023 00:14:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CF9DA3857027 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=gcc.gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org CF9DA3857027 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=205.220.177.146 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697415287; cv=none; b=UtXBD9Qft7+ZCTNu0rX5c9p+gcP883EQ0KlOGOahvg0tey7DQXqXe0RUBVpkCHyDMdPIOZfNb9pLVdbB/MLO7TEpg083b1BIdc9u8OELYjv2U1n5BvUnHfy9jwlOaM689soUVAH41pXXG2itFKxP9G/D53TztmD6T6GtA0Wcteg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697415287; c=relaxed/simple; bh=fm6aTmzL/u+DvSJqIIKZX3rAVzVD2tqarjJM/UYhTyo=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=f5M+0mbOGBzjO35B5shvwk5FF5fNy4Hd6hf1j7EHuQXN9MyFcrh0jnueKddeEKzA3Os7FluK4259bHRi5c7e8GDhd9kjgOgNx0AdI0N5y8pv0zmkX7x2FMWPT0C2yroGv7/Es18ctAvDogZ/Kq7jein3HOPhZaVq/hDCEgG3PDY= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0247479.ppops.net [127.0.0.1]) by mx0a-00641c01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 39G047E3010005; Mon, 16 Oct 2023 00:14:45 GMT Received: from mxout22.s.uw.edu (mxout22.s.uw.edu [128.95.242.222]) by mx0a-00641c01.pphosted.com (PPS) with ESMTPS id 3tr4kp4fh8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 16 Oct 2023 00:14:45 +0000 Received: from smtp.washington.edu (smtp.washington.edu [128.208.60.132]) by mxout22.s.uw.edu (8.14.4+UW20.07/8.14.4+UW22.04) with ESMTP id 39G0EGxT016536 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 15 Oct 2023 17:14:16 -0700 X-Auth-Received: from kmatsui-ThinkPad-X1-Carbon-Gen-9.dhcp4.washington.edu ([10.19.18.191]) (authenticated authid=kmatsui) by smtp.washington.edu (8.16.1+UW21.10/8.14.4+UW19.10) with ESMTPSA id 39G0CSsS032329 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 15 Oct 2023 17:14:16 -0700 X-UW-Orig-Sender: kmatsui@smtp.washington.edu From: Ken Matsui <kmatsui@gcc.gnu.org> To: gcc-patches@gcc.gnu.org Cc: libstdc++@gcc.gnu.org, Ken Matsui <kmatsui@gcc.gnu.org> Subject: [PATCH v20 38/40] libstdc++: Optimize is_signed trait performance Date: Sun, 15 Oct 2023 17:10:22 -0700 Message-ID: <20231016001227.2717180-39-kmatsui@gcc.gnu.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231016001227.2717180-1-kmatsui@gcc.gnu.org> References: <20231013223957.1634024-1-kmatsui@gcc.gnu.org> <20231016001227.2717180-1-kmatsui@gcc.gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: OFotz_81xw6eeZHKWrvmqzkHU4yWkjhh X-Proofpoint-ORIG-GUID: OFotz_81xw6eeZHKWrvmqzkHU4yWkjhh X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-15_09,2023-10-12_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 spamscore=0 adultscore=0 clxscore=1034 bulkscore=0 priorityscore=1501 impostorscore=0 mlxlogscore=731 malwarescore=0 suspectscore=0 mlxscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2310160000 X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776995527999111836 X-GMAIL-MSGID: 1779869702600678599 |
Series |
Optimize type traits performance
|
|
Checks
Context | Check | Description |
---|---|---|
snail/gcc-patch-check | warning | Git am fail log |
Commit Message
Ken Matsui
Oct. 16, 2023, 12:10 a.m. UTC
This patch optimizes the performance of the is_signed trait by dispatching to
the new __is_signed built-in trait.
libstdc++-v3/ChangeLog:
* include/std/type_traits (is_signed): Use __is_signed built-in trait.
(is_signed_v): Likewise.
Signed-off-by: Ken Matsui <kmatsui@gcc.gnu.org>
---
libstdc++-v3/include/std/type_traits | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/libstdc++-v3/include/std/type_traits b/libstdc++-v3/include/std/type_traits index f7d3815f332..7e93923f44b 100644 --- a/libstdc++-v3/include/std/type_traits +++ b/libstdc++-v3/include/std/type_traits @@ -982,6 +982,13 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION : public __bool_constant<__is_abstract(_Tp)> { }; + /// is_signed +#if _GLIBCXX_USE_BUILTIN_TRAIT(__is_signed) + template<typename _Tp> + struct is_signed + : public __bool_constant<__is_signed(_Tp)> + { }; +#else /// @cond undocumented template<typename _Tp, bool = is_arithmetic<_Tp>::value> @@ -994,11 +1001,11 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION { }; /// @endcond - /// is_signed template<typename _Tp> struct is_signed : public __is_signed_helper<_Tp>::type { }; +#endif /// is_unsigned #if _GLIBCXX_USE_BUILTIN_TRAIT(__is_unsigned) @@ -3445,8 +3452,13 @@ template <typename _Tp> template <typename _Tp> inline constexpr bool is_final_v = __is_final(_Tp); +#if _GLIBCXX_USE_BUILTIN_TRAIT(__is_signed) +template <typename _Tp> + inline constexpr bool is_signed_v = __is_signed(_Tp); +#else template <typename _Tp> inline constexpr bool is_signed_v = is_signed<_Tp>::value; +#endif #if _GLIBCXX_USE_BUILTIN_TRAIT(__is_unsigned) template <typename _Tp>