Message ID | 20231016001227.2717180-26-kmatsui@gcc.gnu.org |
---|---|
State | Unresolved |
Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp3159569vqb; Sun, 15 Oct 2023 17:25:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEf6DNqiJmIUdYBfdqEEPkaX2NXYNJIXEMdl+62qQax9XVBz88ATRqUA9MiA4TSSwYC399p X-Received: by 2002:a25:5ca:0:b0:d9a:c946:4187 with SMTP id 193-20020a2505ca000000b00d9ac9464187mr9053410ybf.22.1697415908391; Sun, 15 Oct 2023 17:25:08 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1697415908; cv=pass; d=google.com; s=arc-20160816; b=0U+iIFmp61N3kL1lMYtEGtpuuu2kbBlx7O4rQGZUTB7X66MntK/4PEFeXQekeOQerH aL0RuyrRk9xr5cmayD20V+azqmcrsm9ynhYggAVOIi7IcHe/uERU/tmpqbhmWk9LDVKI EWaPCZQ1Jt2AHmn9HWg7iSKb68hiSaIv3qBJJN8NA8SsbyiqFViNRyoSBEV9yYtFa48F 2GrRqB3biFILGXlN1ClLPTFFeRgaGSremJ97W1/e/7QD4AVA//XsluQrwx+UaFPCSgSF Fi+nD+D/cy4HUrOHpjXcWbjtE4yaJPGJzJ8ejOXPrwVVrmUJXsIdWMc31w+lwxKO8EB3 zimA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:arc-filter:dmarc-filter:delivered-to:dkim-signature :dkim-filter; bh=iaWBS76ar32WQjo99XIMZUyy0dOBDYRpdSXRNfrU13A=; fh=kSSy/oyUXqQD15FLeKdymIgDBFPFITPA1Gj52CNOxRQ=; b=wqtiG/mV3+CUfPqBT7Lz3gLAaWur3yZJj55wagZNBVtphzoOoCoBH056vOjgpz05zQ vrw4ATFhVfUCmStWnkFMeKoa+tiSBepk5yg007BpI6EpC23qOPAoOIfjAIr2y4wfOhdX WV246tbVuCUygDEjoXHljnbkSv0fIeilAr8xvMtTbcfhZQS8/88Oy8pvWhAbyb3Tuz+d Lo96pf1bGDF8eGa4doqfucbo2p1sPvf2CctkNPGiUO/e/MzgmxaGvsFGzFG3PxPzMTyB pedjn5qUrjwSd/ksdYjMzngrKDkeCyiq0qLLNx0O4BOaP7kyoKXcROE1VSDEkOz5nxU3 ht8A== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=YhML2Udd; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id lv8-20020a056214578800b0065b129e617fsi4507919qvb.306.2023.10.15.17.25.08 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Oct 2023 17:25:08 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=YhML2Udd; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C981C3857351 for <ouuuleilei@gmail.com>; Mon, 16 Oct 2023 00:25:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C981C3857351 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1697415907; bh=iaWBS76ar32WQjo99XIMZUyy0dOBDYRpdSXRNfrU13A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=YhML2UddZiIe7UyA6HlKVrN3RZCztdSM9w05H5qd/xo+SmQCrSRQNp2tUuelSzEb+ fZ0OWcN5qSMXRx86RHsQaD9KEuN6v7TatDhCePhLlIaUnHO6nNOkwRtln8JFCU0zZx 19Y4ltosCn+J/ppiYoA+C5aGDcDqHlevqQP3zAnk= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0b-00641c01.pphosted.com (mx0b-00641c01.pphosted.com [205.220.177.146]) by sourceware.org (Postfix) with ESMTPS id 2BC123857029; Mon, 16 Oct 2023 00:14:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2BC123857029 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=gcc.gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2BC123857029 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=205.220.177.146 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697415285; cv=none; b=OH5BsLEHW0kiQnKSvQMFLS/4dcBFN4hVIwhmZd+BPumOPH0W9l2siG4jFPX9qo46xM3zHBFnqNI+3Ejrzyd2DbEupIco3eu79HmtrPXvkW0HbypoMRs5UG/9+kyCWOyly1//v6hRLBchwc/1Mjwa1hFuD98uFUF3l/4fa5kqDtc= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697415285; c=relaxed/simple; bh=c205PSleSo98VKF72O15l6crxQGKXbefxic2LHXRDwk=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=hFJ8vEe0srkqcBOHmXGUW5cN3lc6d9zYEAFCmBaj70bosw+j3GP7IbQpQylTjasKvOSzrCMpQkO+eGQW8uJk10H94OZKhzyFaKHgCTDgeboiv2NyWfIG4wcgf0A0GP40hVIEDKoGb6w4H4fbzDxaPmeW3NQaP20HlxPw1ohD9Jc= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from pps.filterd (m0247481.ppops.net [127.0.0.1]) by mx0a-00641c01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 39G0EJes026225; Mon, 16 Oct 2023 00:14:42 GMT Received: from mxout21.s.uw.edu (mxout21.s.uw.edu [140.142.32.139]) by mx0a-00641c01.pphosted.com (PPS) with ESMTPS id 3tqk70fuw5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 16 Oct 2023 00:14:42 +0000 Received: from smtp.washington.edu (smtp.washington.edu [128.208.60.132]) by mxout21.s.uw.edu (8.14.4+UW20.07/8.14.4+UW22.04) with ESMTP id 39G0EF1J011860 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 15 Oct 2023 17:14:15 -0700 X-Auth-Received: from kmatsui-ThinkPad-X1-Carbon-Gen-9.dhcp4.washington.edu ([10.19.18.191]) (authenticated authid=kmatsui) by smtp.washington.edu (8.16.1+UW21.10/8.14.4+UW19.10) with ESMTPSA id 39G0CSsF032329 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 15 Oct 2023 17:14:15 -0700 X-UW-Orig-Sender: kmatsui@smtp.washington.edu From: Ken Matsui <kmatsui@gcc.gnu.org> To: gcc-patches@gcc.gnu.org Cc: libstdc++@gcc.gnu.org, Ken Matsui <kmatsui@gcc.gnu.org> Subject: [PATCH v20 25/40] libstdc++: Optimize is_function trait performance Date: Sun, 15 Oct 2023 17:10:09 -0700 Message-ID: <20231016001227.2717180-26-kmatsui@gcc.gnu.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231016001227.2717180-1-kmatsui@gcc.gnu.org> References: <20231013223957.1634024-1-kmatsui@gcc.gnu.org> <20231016001227.2717180-1-kmatsui@gcc.gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: xu4G-0OkRBhkEalH4PCMErwYPELUykcT X-Proofpoint-ORIG-GUID: xu4G-0OkRBhkEalH4PCMErwYPELUykcT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-15_09,2023-10-12_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 spamscore=0 clxscore=1034 malwarescore=0 mlxlogscore=582 impostorscore=0 mlxscore=0 suspectscore=0 priorityscore=1501 phishscore=0 lowpriorityscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2310160000 X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776997392552534413 X-GMAIL-MSGID: 1779869583530419534 |
Series |
Optimize type traits performance
|
|
Checks
Context | Check | Description |
---|---|---|
snail/gcc-patch-check | warning | Git am fail log |
Commit Message
Ken Matsui
Oct. 16, 2023, 12:10 a.m. UTC
This patch optimizes the performance of the is_function trait by dispatching
to the new __is_function built-in trait.
libstdc++-v3/ChangeLog:
* include/std/type_traits (is_function): Use __is_function built-in
trait.
(is_function_v): Likewise. Optimize its implementation.
Signed-off-by: Ken Matsui <kmatsui@gcc.gnu.org>
---
libstdc++-v3/include/std/type_traits | 19 ++++++++++++++++++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/libstdc++-v3/include/std/type_traits b/libstdc++-v3/include/std/type_traits index 36ad9814047..bd57488824b 100644 --- a/libstdc++-v3/include/std/type_traits +++ b/libstdc++-v3/include/std/type_traits @@ -637,6 +637,12 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION { }; /// is_function +#if _GLIBCXX_USE_BUILTIN_TRAIT(__is_function) + template<typename _Tp> + struct is_function + : public __bool_constant<__is_function(_Tp)> + { }; +#else template<typename _Tp> struct is_function : public __bool_constant<!is_const<const _Tp>::value> { }; @@ -648,6 +654,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION template<typename _Tp> struct is_function<_Tp&&> : public false_type { }; +#endif #ifdef __cpp_lib_is_null_pointer // C++ >= 11 /// is_null_pointer (LWG 2247). @@ -3269,8 +3276,18 @@ template <typename _Tp> inline constexpr bool is_union_v = __is_union(_Tp); template <typename _Tp> inline constexpr bool is_class_v = __is_class(_Tp); + +#if _GLIBCXX_USE_BUILTIN_TRAIT(__is_function) template <typename _Tp> - inline constexpr bool is_function_v = is_function<_Tp>::value; + inline constexpr bool is_function_v = __is_function(_Tp); +#else +template <typename _Tp> + inline constexpr bool is_function_v = !is_const_v<const _Tp>; +template <typename _Tp> + inline constexpr bool is_function_v<_Tp&> = false; +template <typename _Tp> + inline constexpr bool is_function_v<_Tp&&> = false; +#endif #if _GLIBCXX_USE_BUILTIN_TRAIT(__is_reference) template <typename _Tp>