Message ID | 20231013223957.1634024-39-kmatsui@gcc.gnu.org |
---|---|
State | Unresolved |
Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp2192243vqb; Fri, 13 Oct 2023 15:44:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEnzKIcOCmKJJ9X7C7yZ2/QlvBMed1+VWFrQuz5PdSrwh1rfypL1T/3ODT5NRXUMmNXGeAI X-Received: by 2002:a67:c510:0:b0:457:670b:1810 with SMTP id e16-20020a67c510000000b00457670b1810mr17420090vsk.31.1697237095622; Fri, 13 Oct 2023 15:44:55 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1697237095; cv=pass; d=google.com; s=arc-20160816; b=cXKTfnemMhZYx+lrlshzM28rK8BNGrKxWmG+3JP+2+cfFvos2fGxiCqRwtcSUW2/K0 2AwE9aCSWKzGjg/UZXrvYm605EdB1zvxyu6mY96LdU3eyrGQI+wV8ovbMsNehaITKOVr 9TVvKhT8PL67oM/Uz5KvrHjZRKHjhhFICwOScNtwvrm1IeHDkqQie+9bdYjY55vV/2gC CEzqskQbOzgqwLqwS9JW0BC00BdJEe60PlrWuf0BeAGkiKbEc/pqbx02K3QqsBBCbtJG CsOfSPRpmGNH6RUJHjQDHZpkasIAZ9dMIXiu/kJ/pOhDyipZHUsRGC0gXA4njA9tRAO2 aVKw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dmarc-filter:arc-filter:delivered-to:dkim-signature :dkim-filter; bh=cQfm2Z2CbE9/tDAPdRh2GGqLZxuO7lj7PQBaV9C0Mb0=; fh=kSSy/oyUXqQD15FLeKdymIgDBFPFITPA1Gj52CNOxRQ=; b=NYnfHJkeH98FjZt4A9rNIw3tdsczhY4OMu079Fmpd8mAq+RgSnMqDVmc6ogwCCF5SF ucoVPlQvvZRcLtMW2dGE2q1DzINzeBQ+yTVIudcuW5d9fi/lWL30Y7CB9iMByHBOkqs0 X4BlVAi7Gpl5/wQ32krqAXWZMug9mRS0ZQuXqAXgeh5aR+M807rHH/y4DeaG4c2UxXHf IPUlVm61kuZ2JIbphA1JMCjfX9mfs+ze8Kmr5Jjjc3AskY6OOCoPKqxgEfA901zLQhjp A1/iWGJV1JbdpSmk4t/hHR6DCUMsP+jDnxfXamVPSMqTIOAaNMAMmsQHDgNF81fK8fLS cgpQ== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=WpxOaq4p; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id a24-20020a0ca998000000b0066d1e71e518si1927294qvb.480.2023.10.13.15.44.55 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 15:44:55 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=WpxOaq4p; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A3A75385CC8F for <ouuuleilei@gmail.com>; Fri, 13 Oct 2023 22:44:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A3A75385CC8F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1697237094; bh=cQfm2Z2CbE9/tDAPdRh2GGqLZxuO7lj7PQBaV9C0Mb0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=WpxOaq4plFbYqyZYaCMLAGiIGVV4jy3ohlAMy63y0aXryYU3otxfWEGNPF6d/idQa Sl0mRIJIU3Sb3yDccIwkbYr5vCkXyv0rm6/dOU1T1Vyzqg8kNIziimnaFQSeVniocO bgAvMTD7rEZ0lHUvEjVgnWkKDJ5mRJiy7J5/oPmQ= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0b-00641c01.pphosted.com (mx0b-00641c01.pphosted.com [205.220.177.146]) by sourceware.org (Postfix) with ESMTPS id B856E3858439; Fri, 13 Oct 2023 22:43:15 +0000 (GMT) ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B856E3858439 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=205.220.177.146 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697236998; cv=none; b=DOqVqT0stR3V6AR+XTACeSjLzbK3Pre1p0YWkkuRCk23O9Diup58V4jgLTshooyMpTbvVLCBDFXs0cF76+utgt1Uih5pO5hUhw6V1aPz5z4B1XIu7SQRhFWsUt2123D14JOrtFcRkS/XcTMEVBT2nBs0PiDkRAm7kpf2/7QS+IE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697236998; c=relaxed/simple; bh=fm6aTmzL/u+DvSJqIIKZX3rAVzVD2tqarjJM/UYhTyo=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=GIzmFNWeZklON7nEmG3TjoCl+iiwhuHOgpIczDRAXAZGysf3ap4FDao+xUXsyjNEzyXQ/ZnDPA7Ib4o3vSdp5vmbr+xPJxFcSZF4TIBrNCEmcp0VGoAfRTR5B/2OdJh+sitzAfqyWtOYgsltatrYd+uJufPwpvi8Or5qRExPmXQ= ARC-Authentication-Results: i=1; server2.sourceware.org DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B856E3858439 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=gcc.gnu.org Received: from pps.filterd (m0247479.ppops.net [127.0.0.1]) by mx0a-00641c01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 39DMXSpH014551; Fri, 13 Oct 2023 22:43:15 GMT Received: from mxout22.s.uw.edu (mxout22.s.uw.edu [128.95.242.222]) by mx0a-00641c01.pphosted.com (PPS) with ESMTPS id 3tqc209mqn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 13 Oct 2023 22:43:15 +0000 Received: from smtp.washington.edu (smtp.washington.edu [128.208.60.54]) by mxout22.s.uw.edu (8.14.4+UW20.07/8.14.4+UW22.04) with ESMTP id 39DMh3kW021625 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 13 Oct 2023 15:43:03 -0700 X-Auth-Received: from kmatsui-ThinkPad-X1-Carbon-Gen-9.dhcp4.washington.edu ([10.19.18.191]) (authenticated authid=kmatsui) by smtp.washington.edu (8.16.1+UW21.10/8.14.4+UW19.10) with ESMTPSA id 39DMdx1p016619 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 13 Oct 2023 15:43:03 -0700 X-UW-Orig-Sender: kmatsui@smtp.washington.edu From: Ken Matsui <kmatsui@gcc.gnu.org> To: gcc-patches@gcc.gnu.org Cc: libstdc++@gcc.gnu.org, Ken Matsui <kmatsui@gcc.gnu.org> Subject: [PATCH v19 38/40] libstdc++: Optimize is_signed trait performance Date: Fri, 13 Oct 2023 15:37:52 -0700 Message-ID: <20231013223957.1634024-39-kmatsui@gcc.gnu.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231013223957.1634024-1-kmatsui@gcc.gnu.org> References: <20231013211206.1215663-1-kmatsui@gcc.gnu.org> <20231013223957.1634024-1-kmatsui@gcc.gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: i2t82heX8u9BemQANbz4FSvbadS3gbco X-Proofpoint-GUID: i2t82heX8u9BemQANbz4FSvbadS3gbco X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-13_12,2023-10-12_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 mlxlogscore=732 suspectscore=0 adultscore=0 clxscore=1034 mlxscore=0 spamscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2310130197 X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776995527999111836 X-GMAIL-MSGID: 1779682084760928689 |
Series |
Optimize type traits performance
|
|
Checks
Context | Check | Description |
---|---|---|
snail/gcc-patch-check | warning | Git am fail log |
Commit Message
Ken Matsui
Oct. 13, 2023, 10:37 p.m. UTC
This patch optimizes the performance of the is_signed trait by dispatching to
the new __is_signed built-in trait.
libstdc++-v3/ChangeLog:
* include/std/type_traits (is_signed): Use __is_signed built-in trait.
(is_signed_v): Likewise.
Signed-off-by: Ken Matsui <kmatsui@gcc.gnu.org>
---
libstdc++-v3/include/std/type_traits | 14 +++++++++++++-
1 file changed, 13 insertions(+), 1 deletion(-)
diff --git a/libstdc++-v3/include/std/type_traits b/libstdc++-v3/include/std/type_traits index f7d3815f332..7e93923f44b 100644 --- a/libstdc++-v3/include/std/type_traits +++ b/libstdc++-v3/include/std/type_traits @@ -982,6 +982,13 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION : public __bool_constant<__is_abstract(_Tp)> { }; + /// is_signed +#if _GLIBCXX_USE_BUILTIN_TRAIT(__is_signed) + template<typename _Tp> + struct is_signed + : public __bool_constant<__is_signed(_Tp)> + { }; +#else /// @cond undocumented template<typename _Tp, bool = is_arithmetic<_Tp>::value> @@ -994,11 +1001,11 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION { }; /// @endcond - /// is_signed template<typename _Tp> struct is_signed : public __is_signed_helper<_Tp>::type { }; +#endif /// is_unsigned #if _GLIBCXX_USE_BUILTIN_TRAIT(__is_unsigned) @@ -3445,8 +3452,13 @@ template <typename _Tp> template <typename _Tp> inline constexpr bool is_final_v = __is_final(_Tp); +#if _GLIBCXX_USE_BUILTIN_TRAIT(__is_signed) +template <typename _Tp> + inline constexpr bool is_signed_v = __is_signed(_Tp); +#else template <typename _Tp> inline constexpr bool is_signed_v = is_signed<_Tp>::value; +#endif #if _GLIBCXX_USE_BUILTIN_TRAIT(__is_unsigned) template <typename _Tp>