Message ID | 20231013223957.1634024-34-kmatsui@gcc.gnu.org |
---|---|
State | Unresolved |
Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp2194767vqb; Fri, 13 Oct 2023 15:52:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEJzHDgMEweznNv86sCTO91FDp1iXTtwcfp34ZUsTJ7wrnzk/XZLfZW9hxn4AiVyaHLt//a X-Received: by 2002:a81:ac06:0:b0:5a7:ad67:2b67 with SMTP id k6-20020a81ac06000000b005a7ad672b67mr12315627ywh.5.1697237535981; Fri, 13 Oct 2023 15:52:15 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1697237535; cv=pass; d=google.com; s=arc-20160816; b=AYTZLouSoLFWzSGLRRK8hWjyhqtZT5WXehawMHv6jM1OH3k9T5Fq+zcJEUDlFl70Ey GM+byHQzj9T1sltdTY7bKOXyGOSSjTN0yYMRM8IAE8XoZbZqwWcDkvlF7rBp0a6Ev3+j /iFoAtvfojsTEPS4uKI67roxSZdtCqnihUfR2RolNWM5t/70vVejuR6CsSfv95XGWh6o H4lpg3KCir8PVAbqsKaZoBXL6nnYWISM/BoroEWy8p7cJaDncBW7qYU4RLv8/lGZLDQc aWEolJVBOPDukE50wXJBYwT0GV1HQVEBjGG2n54h7BUaI/oXSmXxz3N0EITXgmCESH8X gICw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dmarc-filter:arc-filter:delivered-to:dkim-signature :dkim-filter; bh=noKDFtKJFjfo7apPynoK1CS9k2hGzaYhkiB5OX56sE8=; fh=kSSy/oyUXqQD15FLeKdymIgDBFPFITPA1Gj52CNOxRQ=; b=ZbbOyd0Maw1Hx1r36IIoubAibXYriigENxWFyuDObvSahfUV/h8HEX2IpMYcbp4tTs cZ8hoA+GxEzOU4wvJxziaMTmKG9XsGf5bhSme5Y7fwFbAmWoZlBRJU4Z+V8a62Wlf7hi b0/+yAYr14SjX/Qlhqr8FfR2KGaKL6etLscFpg3EL1nWceNYu3zroyNVcx6ate/Ith3p vXaqMapyBkCdTki176Y4VYExslY9KqDfhZ+SsNs06zLJMces/IRdkmuhKxvxTLW4620N WQkCT01V4y5Kgm8c/fKgGenDoLo0d7WFoV2TDkkKNEOLm3eNlercxS1+GQKSppO0Q0u8 5dnw== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=qQsVbE87; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id w11-20020a05620a444b00b00775bf2a8df6si2042723qkp.195.2023.10.13.15.52.15 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 15:52:15 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=qQsVbE87; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D380138555A0 for <ouuuleilei@gmail.com>; Fri, 13 Oct 2023 22:52:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D380138555A0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1697237522; bh=noKDFtKJFjfo7apPynoK1CS9k2hGzaYhkiB5OX56sE8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=qQsVbE87EC5tmiRAplONcHJtjmTi1FDXldfTi1QEbryAbqig5aA5BL1SMtoDf77WA 8qxQnjGfE1PO5bUBqfyMw1J1FhFeg/BU/a0M+jdMErrFrhY8Er3gCr/JHCrGt0/IIg ddQbTm7p0K1FUU+qL1HvfAQQZbbjvm9JccZZMgiU= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0b-00641c01.pphosted.com (mx0b-00641c01.pphosted.com [205.220.177.146]) by sourceware.org (Postfix) with ESMTPS id 2927B3856964; Fri, 13 Oct 2023 22:43:17 +0000 (GMT) ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 2927B3856964 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=205.220.177.146 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697237005; cv=none; b=xmyvtAtxesi3HMcYErnAyGLs/xJtgn5VmkzaAjDkP/4yEsznssqlsIotOImwIIW0Kq2l2LIlNyVW/htwQBcxXrbpuENz0wYeTveB91ISYWu97qxDZJsX3SUJA+lKS2wwyII2D09acmyyg5o+eCycbXW9XfHXHb0JAZ5MX3wCLmU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697237005; c=relaxed/simple; bh=VMehu4HE7BzN624OVO4Fw+NnsTWTfYiByT3bQXMD4Js=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=PvLWz1Tz2YhXD3zXI8VDwmpwRGSCUw+W7BBr+g4JW7pu7M87WGJ/J1i+zVPhfCjpYksEAD2pJeH2RHsa2QUn4MbO6CH/Lr9R21Wz5vfeJet+rj1gqwml0qpsdsQRkBx+336q3CdJPi8qLY8lPjEnDGHem8HKxih2Rd9fs4Kfy84= ARC-Authentication-Results: i=1; server2.sourceware.org DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2927B3856964 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=gcc.gnu.org Received: from pps.filterd (m0247479.ppops.net [127.0.0.1]) by mx0a-00641c01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 39DMh0aO001171; Fri, 13 Oct 2023 22:43:16 GMT Received: from mxout26.s.uw.edu (mxout26.s.uw.edu [140.142.234.176]) by mx0a-00641c01.pphosted.com (PPS) with ESMTPS id 3tqc209mr3-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 13 Oct 2023 22:43:16 +0000 Received: from smtp.washington.edu (smtp.washington.edu [128.208.60.54]) by mxout26.s.uw.edu (8.14.4+UW20.07/8.14.4+UW22.04) with ESMTP id 39DMh2e9008054 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 13 Oct 2023 15:43:02 -0700 X-Auth-Received: from kmatsui-ThinkPad-X1-Carbon-Gen-9.dhcp4.washington.edu ([10.19.18.191]) (authenticated authid=kmatsui) by smtp.washington.edu (8.16.1+UW21.10/8.14.4+UW19.10) with ESMTPSA id 39DMdx1k016619 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 13 Oct 2023 15:43:02 -0700 X-UW-Orig-Sender: kmatsui@smtp.washington.edu From: Ken Matsui <kmatsui@gcc.gnu.org> To: gcc-patches@gcc.gnu.org Cc: libstdc++@gcc.gnu.org, Ken Matsui <kmatsui@gcc.gnu.org> Subject: [PATCH v19 33/40] libstdc++: Optimize is_fundamental trait performance Date: Fri, 13 Oct 2023 15:37:47 -0700 Message-ID: <20231013223957.1634024-34-kmatsui@gcc.gnu.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231013223957.1634024-1-kmatsui@gcc.gnu.org> References: <20231013211206.1215663-1-kmatsui@gcc.gnu.org> <20231013223957.1634024-1-kmatsui@gcc.gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: 4LF9fYgV63lwI7nvBLaRJGH0VeI2Rbhs X-Proofpoint-GUID: 4LF9fYgV63lwI7nvBLaRJGH0VeI2Rbhs X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-13_12,2023-10-12_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 mlxlogscore=656 suspectscore=0 adultscore=0 clxscore=1034 mlxscore=0 spamscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2310130197 X-Spam-Status: No, score=-13.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776996476757191546 X-GMAIL-MSGID: 1779682546521735295 |
Series |
Optimize type traits performance
|
|
Checks
Context | Check | Description |
---|---|---|
snail/gcc-patch-check | warning | Git am fail log |
Commit Message
Ken Matsui
Oct. 13, 2023, 10:37 p.m. UTC
This patch optimizes the performance of the is_fundamental trait by
dispatching to the new __is_arithmetic built-in trait.
libstdc++-v3/ChangeLog:
* include/std/type_traits (is_fundamental_v): Use __is_arithmetic
built-in trait.
(is_fundamental): Likewise. Optimize the original implementation.
Signed-off-by: Ken Matsui <kmatsui@gcc.gnu.org>
---
libstdc++-v3/include/std/type_traits | 20 ++++++++++++++++----
1 file changed, 16 insertions(+), 4 deletions(-)
diff --git a/libstdc++-v3/include/std/type_traits b/libstdc++-v3/include/std/type_traits index cc466e0f606..88171e1a672 100644 --- a/libstdc++-v3/include/std/type_traits +++ b/libstdc++-v3/include/std/type_traits @@ -739,11 +739,21 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION #endif /// is_fundamental +#if _GLIBCXX_USE_BUILTIN_TRAIT(__is_arithmetic) + template<typename _Tp> + struct is_fundamental + : public __bool_constant<__is_arithmetic(_Tp) + || is_void<_Tp>::value + || is_null_pointer<_Tp>::value> + { }; +#else template<typename _Tp> struct is_fundamental - : public __or_<is_arithmetic<_Tp>, is_void<_Tp>, - is_null_pointer<_Tp>>::type + : public __bool_constant<is_arithmetic<_Tp>::value + || is_void<_Tp>::value + || is_null_pointer<_Tp>::value> { }; +#endif /// is_object #if _GLIBCXX_USE_BUILTIN_TRAIT(__is_function) \ @@ -3354,13 +3364,15 @@ template <typename _Tp> #if _GLIBCXX_USE_BUILTIN_TRAIT(__is_arithmetic) template <typename _Tp> inline constexpr bool is_arithmetic_v = __is_arithmetic(_Tp); +template <typename _Tp> + inline constexpr bool is_fundamental_v + = __is_arithmetic(_Tp) || is_void_v<_Tp> || is_null_pointer_v<_Tp>; #else template <typename _Tp> inline constexpr bool is_arithmetic_v = is_arithmetic<_Tp>::value; -#endif - template <typename _Tp> inline constexpr bool is_fundamental_v = is_fundamental<_Tp>::value; +#endif #if _GLIBCXX_USE_BUILTIN_TRAIT(__is_function) \ && _GLIBCXX_USE_BUILTIN_TRAIT(__is_reference)