From patchwork Fri Oct 13 22:37:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ken Matsui X-Patchwork-Id: 152800 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp2192511vqb; Fri, 13 Oct 2023 15:45:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEkWok0/5+MLFBXTCP/6yiIwAPYVWae6CPWL1gSXCOJGvUL4OnECTC1Pn5uz2Ik9fdZG+1Q X-Received: by 2002:a0c:aa5d:0:b0:66d:13c2:1c31 with SMTP id e29-20020a0caa5d000000b0066d13c21c31mr1985938qvb.24.1697237140312; Fri, 13 Oct 2023 15:45:40 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1697237140; cv=pass; d=google.com; s=arc-20160816; b=Xus+kadOvXAntnYCFw9ZaLCsfz9A9J6S5+wG1sqPvq6ZtqVvLxcohl5bXtPCel7W+U xWUG4zAyuAQn1cbvGbiv8pIDJ2H8EMd47oIq3C3vjIzYi+EGijbAl5x/mpl02atqYRmH AUgbcFNiWyki9dAZ8zWDz3jlU5OkhiwZ43w8SG3XQDQusEjqVHxmG1CRSGY39iWzqza5 VHURLGjTEmSuOAie8k6rdPqVPWtu3TdXSBbmRqfOYG/KAmlBcC5x7iaLf7xApWb/7UYR +r2YpRii2ECwLLi0309bsdSyUrjIe1d2j/6zLFqDgIa7tARUJocvU6G24HWhLl19+Yjs DJHQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dmarc-filter:arc-filter:delivered-to:dkim-signature :dkim-filter; bh=iaWBS76ar32WQjo99XIMZUyy0dOBDYRpdSXRNfrU13A=; fh=kSSy/oyUXqQD15FLeKdymIgDBFPFITPA1Gj52CNOxRQ=; b=FH4expQ6mozip7YKWSqUdPWFwSNR/aeHh5aqGl0xHCena/60/gj+MeZ68ztixxVBSW h/BGpbBn0JiWhtPdsC3TMU1C0J8ZXeYvjGsP12kk8mDbWcx7LILMFzz+I/UVFe97NlGb PIKfVTqa5+tNjlaYm/cHGsesMcaE0QyY99pQ/xdTcYtXqiFDjQF7TL1Sh7gtUqs26wnA sFKjISfs5ij1oPpoR94RIHTocoAT3A1guXq8Vjw1S90W/o3xZr5Xol6OiVgUjbvqGqck Mz3ddH6MV7If1BRX2TCF121VM3EnPb3jPMuIwuEpXXlhYlHg8cqxOkmOjrUM1g4erbwH 23EA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=Dy0OzrcQ; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id eb12-20020ad44e4c000000b0066d130cbb98si1919057qvb.19.2023.10.13.15.45.40 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 15:45:40 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=Dy0OzrcQ; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4D7A33861861 for ; Fri, 13 Oct 2023 22:45:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4D7A33861861 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1697237135; bh=iaWBS76ar32WQjo99XIMZUyy0dOBDYRpdSXRNfrU13A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Dy0OzrcQDpEwhnWXjOCqdfSql6eDrcB9Gqhpp4sD2j0Kqtj+BlzIkFyrQ9aHltgKs Gc5ZULfUw/b4l2YtSZSUrlzedd60oedTxB+Xq7NwBi90JaIQkiRhxC23zQRt1u75A3 wn0+wSfa7JL3miZOoV83dwFqz+la2d2C+Uqz45c0= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0b-00641c01.pphosted.com (mx0b-00641c01.pphosted.com [205.220.177.146]) by sourceware.org (Postfix) with ESMTPS id 23D1E3857359; Fri, 13 Oct 2023 22:43:16 +0000 (GMT) ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 23D1E3857359 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=205.220.177.146 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697236998; cv=none; b=G+W4Z/71PUsd8HDoT/s2Vj/d8KV1/WD5jcj45061HpowSI3tmcEWV0yvLjOfRoWHRE6/Ff4vgStv6TOZIf+uuhydXDV7XYHomEgGuMsSaUrXr/Z8Bm82e/MWEM7HZFbpJ5Vzy20CDtIhgKQ5e8ViG46HHKHM7oFO+a73925Rv3c= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697236998; c=relaxed/simple; bh=c205PSleSo98VKF72O15l6crxQGKXbefxic2LHXRDwk=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=vIt4hy5+Wi0JpIucaA9ExPdAo0g1RKPQyaWsKq4RqHF8rlGLNRjJmVT5kfe2JEliMhV85K3i8X6X1S7KlmhBcJpf8BHpICovPltM9uZbTy6BwHecXrCrUhYn0XTCMiwGdUFP4bQNo6eY67u/BACXYMZfdr+kHU/xjIqx7fdL7XA= ARC-Authentication-Results: i=1; server2.sourceware.org DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 23D1E3857359 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=gcc.gnu.org Received: from pps.filterd (m0247477.ppops.net [127.0.0.1]) by mx0a-00641c01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 39DMYn2w019858; Fri, 13 Oct 2023 22:43:15 GMT Received: from mxout22.s.uw.edu (mxout22.s.uw.edu [128.95.242.222]) by mx0a-00641c01.pphosted.com (PPS) with ESMTPS id 3tqdep0tbx-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 13 Oct 2023 22:43:15 +0000 Received: from smtp.washington.edu (smtp.washington.edu [128.208.60.54]) by mxout22.s.uw.edu (8.14.4+UW20.07/8.14.4+UW22.04) with ESMTP id 39DMh2ek021602 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 13 Oct 2023 15:43:02 -0700 X-Auth-Received: from kmatsui-ThinkPad-X1-Carbon-Gen-9.dhcp4.washington.edu ([10.19.18.191]) (authenticated authid=kmatsui) by smtp.washington.edu (8.16.1+UW21.10/8.14.4+UW19.10) with ESMTPSA id 39DMdx1c016619 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 13 Oct 2023 15:43:02 -0700 X-UW-Orig-Sender: kmatsui@smtp.washington.edu From: Ken Matsui To: gcc-patches@gcc.gnu.org Cc: libstdc++@gcc.gnu.org, Ken Matsui Subject: [PATCH v19 25/40] libstdc++: Optimize is_function trait performance Date: Fri, 13 Oct 2023 15:37:39 -0700 Message-ID: <20231013223957.1634024-26-kmatsui@gcc.gnu.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231013223957.1634024-1-kmatsui@gcc.gnu.org> References: <20231013211206.1215663-1-kmatsui@gcc.gnu.org> <20231013223957.1634024-1-kmatsui@gcc.gnu.org> MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: dcwnQJIGOAsrxb2UU4hFzN74C4Kmrx-C X-Proofpoint-GUID: dcwnQJIGOAsrxb2UU4hFzN74C4Kmrx-C X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-13_12,2023-10-12_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 clxscore=1034 impostorscore=0 phishscore=0 adultscore=0 suspectscore=0 malwarescore=0 mlxlogscore=583 mlxscore=0 priorityscore=1501 bulkscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2310130197 X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776997392552534413 X-GMAIL-MSGID: 1779682131632581446 This patch optimizes the performance of the is_function trait by dispatching to the new __is_function built-in trait. libstdc++-v3/ChangeLog: * include/std/type_traits (is_function): Use __is_function built-in trait. (is_function_v): Likewise. Optimize its implementation. Signed-off-by: Ken Matsui --- libstdc++-v3/include/std/type_traits | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/libstdc++-v3/include/std/type_traits b/libstdc++-v3/include/std/type_traits index 36ad9814047..bd57488824b 100644 --- a/libstdc++-v3/include/std/type_traits +++ b/libstdc++-v3/include/std/type_traits @@ -637,6 +637,12 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION { }; /// is_function +#if _GLIBCXX_USE_BUILTIN_TRAIT(__is_function) + template + struct is_function + : public __bool_constant<__is_function(_Tp)> + { }; +#else template struct is_function : public __bool_constant::value> { }; @@ -648,6 +654,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION template struct is_function<_Tp&&> : public false_type { }; +#endif #ifdef __cpp_lib_is_null_pointer // C++ >= 11 /// is_null_pointer (LWG 2247). @@ -3269,8 +3276,18 @@ template inline constexpr bool is_union_v = __is_union(_Tp); template inline constexpr bool is_class_v = __is_class(_Tp); + +#if _GLIBCXX_USE_BUILTIN_TRAIT(__is_function) template - inline constexpr bool is_function_v = is_function<_Tp>::value; + inline constexpr bool is_function_v = __is_function(_Tp); +#else +template + inline constexpr bool is_function_v = !is_const_v; +template + inline constexpr bool is_function_v<_Tp&> = false; +template + inline constexpr bool is_function_v<_Tp&&> = false; +#endif #if _GLIBCXX_USE_BUILTIN_TRAIT(__is_reference) template