Message ID | 20231013223957.1634024-24-kmatsui@gcc.gnu.org |
---|---|
State | Unresolved |
Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp2193108vqb; Fri, 13 Oct 2023 15:47:36 -0700 (PDT) X-Google-Smtp-Source: AGHT+IExUU8lyaDq6rkQJNG6xtS5uhWdLnZUZeMErT7cBrMASiooKyeJb+hOWiUAOziBiDIpA6D0 X-Received: by 2002:ac8:5e4b:0:b0:418:1f6b:7ca3 with SMTP id i11-20020ac85e4b000000b004181f6b7ca3mr35891583qtx.23.1697237256059; Fri, 13 Oct 2023 15:47:36 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1697237256; cv=pass; d=google.com; s=arc-20160816; b=sdFIkYQk7NQ0kMskzUKDdTi+kQxcY9+mTBVGsNbp1hGkZNrbx10d0wazXSuu/WgGAR gb7bEz/6FuWykgaMLXqv6+PiAKF7Uy7yH3Eg3nN+syTRk/4I1KEhe3eI/3qwegvL32ML qSS9sEfDrVOY0389Wsy+jUiicYjlnSmgjt8/eekQYo4iFLoRzhtXljaSU3U+V+KaTzOf WmoyJoVM8xOpvzbBW1AdRSiyURbPUAggiOBf2o41yD2CnqNVmcneACfqx1sO/hqry+Eb fdueCgTGlMQRqP72BWmHrzxY+V1tP9YHwTo4xVCnNWW3C4qCaGiT/0LdkkCkId+IMvGV 9BVw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dmarc-filter:arc-filter:delivered-to:dkim-signature :dkim-filter; bh=a3SDnv+ngUCB35eFko44fBFMw3GjBIvC/op0WNV0QaA=; fh=kSSy/oyUXqQD15FLeKdymIgDBFPFITPA1Gj52CNOxRQ=; b=ZW6wu1dN2CvEGIhqodzdtQUXkyLqdziKbR+EV4Z8jFZdLkl7oL/7IaiEgNrVzb9amC tA4kZKPOdwEl2oV8UfHfVMJyBoClVP4XnGMsZzZtcmDJjguhdTvGat3tHk/1QwIKNJwD WVPTDaXETpXHXNeTzk1t0w6Z4uA77Q0QKDe0v1Y2zF2vYj8rX0Z/xSuZiMPWVT51oz/u W3DA1+o9K6uJah5QEopup7cAg6gvA6UeD6leak/FNRmN9AP27XZj9N9TTD3qzTvgRR5f 48PmMNEJjxpiQ+7lPhG6swW6j4UhJblQhzKcZsBoyxQtExG2FeIiAHJ/NdCbjKfS19lu /mHg== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b="yivZ/dzO"; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id u19-20020a05622a011300b0041816d65a98si2011529qtw.421.2023.10.13.15.47.36 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 15:47:36 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b="yivZ/dzO"; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0A0B0385C422 for <ouuuleilei@gmail.com>; Fri, 13 Oct 2023 22:47:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0A0B0385C422 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1697237250; bh=a3SDnv+ngUCB35eFko44fBFMw3GjBIvC/op0WNV0QaA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=yivZ/dzOLd9rwPinpaT0wfLyJDYFruPj7+EivCGMer/u23wj0royps5jw3ZNTRGkE iITbvShmBwh7NhkkCh/MBdyx7jqxiXAxlKPOivNMahGeSTA1ggrmfsfe9oy8+b9Dhp O3I+e4p9w6CGgGBotcbNX2uxwS5IV2o0r0lvLJ7g= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0b-00641c01.pphosted.com (mx0b-00641c01.pphosted.com [205.220.177.146]) by sourceware.org (Postfix) with ESMTPS id 6C6403856943; Fri, 13 Oct 2023 22:43:16 +0000 (GMT) ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 6C6403856943 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=205.220.177.146 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697237000; cv=none; b=s6X6E0kf5AURbxIeuVeIWZH21ngp48R6DsVIONzS8k+s/7fswRDGXRaxmsIfCJp9Ezh1IqewKlIcQU2hqDA8kMvstOf5/EZqZBnTac2J0MkcsbY8D0q1kcy1CUs7kqKJWc9smYudAp88RTrazAzAadvadt4GSelsMTa2HPW719U= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697237000; c=relaxed/simple; bh=/ZpKzUC/+Cn+6c4i+PdtJvMDzWz2wSkg6dqToHkptIU=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=kglCAAYevoB69tAPBZ5cYV9nu9Q1GQOUijKGPOtnP306Hxa8myK7esEmV6dcrTTqZHru5DD+wyAXXUHhbKHkSo/OpmtX9Dz3B1/TESmBnkqZKGaCHleA5SiPX3Mdz/SxF0aC1cUKe8QUmmAmLZvKVNo6yEVT9Pc7SF2jZS+RENE= ARC-Authentication-Results: i=1; server2.sourceware.org DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6C6403856943 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=gcc.gnu.org Received: from pps.filterd (m0247481.ppops.net [127.0.0.1]) by mx0a-00641c01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 39DMd4Eu025980; Fri, 13 Oct 2023 22:43:16 GMT Received: from mxout22.s.uw.edu (mxout22.s.uw.edu [128.95.242.222]) by mx0a-00641c01.pphosted.com (PPS) with ESMTPS id 3tqb8ma0mc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 13 Oct 2023 22:43:15 +0000 Received: from smtp.washington.edu (smtp.washington.edu [128.208.60.54]) by mxout22.s.uw.edu (8.14.4+UW20.07/8.14.4+UW22.04) with ESMTP id 39DMh2UZ021601 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 13 Oct 2023 15:43:02 -0700 X-Auth-Received: from kmatsui-ThinkPad-X1-Carbon-Gen-9.dhcp4.washington.edu ([10.19.18.191]) (authenticated authid=kmatsui) by smtp.washington.edu (8.16.1+UW21.10/8.14.4+UW19.10) with ESMTPSA id 39DMdx1a016619 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 13 Oct 2023 15:43:02 -0700 X-UW-Orig-Sender: kmatsui@smtp.washington.edu From: Ken Matsui <kmatsui@gcc.gnu.org> To: gcc-patches@gcc.gnu.org Cc: libstdc++@gcc.gnu.org, Ken Matsui <kmatsui@gcc.gnu.org> Subject: [PATCH v19 23/40] libstdc++: Optimize is_reference trait performance Date: Fri, 13 Oct 2023 15:37:37 -0700 Message-ID: <20231013223957.1634024-24-kmatsui@gcc.gnu.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231013223957.1634024-1-kmatsui@gcc.gnu.org> References: <20231013211206.1215663-1-kmatsui@gcc.gnu.org> <20231013223957.1634024-1-kmatsui@gcc.gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: kTdIoD7Agry36Il-9d3ghDZo_NkmffCc X-Proofpoint-GUID: kTdIoD7Agry36Il-9d3ghDZo_NkmffCc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-13_12,2023-10-12_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1034 suspectscore=0 malwarescore=0 lowpriorityscore=0 bulkscore=0 mlxlogscore=782 impostorscore=0 priorityscore=1501 mlxscore=0 spamscore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2310130197 X-Spam-Status: No, score=-13.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776997499735714658 X-GMAIL-MSGID: 1779682253139068141 |
Series |
Optimize type traits performance
|
|
Checks
Context | Check | Description |
---|---|---|
snail/gcc-patch-check | warning | Git am fail log |
Commit Message
Ken Matsui
Oct. 13, 2023, 10:37 p.m. UTC
This patch optimizes the performance of the is_reference trait by dispatching
to the new __is_reference built-in trait.
libstdc++-v3/ChangeLog:
* include/std/type_traits (is_reference): Use __is_reference built-in
trait.
(is_reference_v): Likewise.
Signed-off-by: Ken Matsui <kmatsui@gcc.gnu.org>
---
libstdc++-v3/include/std/type_traits | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/libstdc++-v3/include/std/type_traits b/libstdc++-v3/include/std/type_traits index 792213ebfe8..36ad9814047 100644 --- a/libstdc++-v3/include/std/type_traits +++ b/libstdc++-v3/include/std/type_traits @@ -682,6 +682,12 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION // Composite type categories. /// is_reference +#if _GLIBCXX_USE_BUILTIN_TRAIT(__is_reference) + template<typename _Tp> + struct is_reference + : public __bool_constant<__is_reference(_Tp)> + { }; +#else template<typename _Tp> struct is_reference : public false_type @@ -696,6 +702,7 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION struct is_reference<_Tp&&> : public true_type { }; +#endif /// is_arithmetic template<typename _Tp> @@ -3264,12 +3271,19 @@ template <typename _Tp> inline constexpr bool is_class_v = __is_class(_Tp); template <typename _Tp> inline constexpr bool is_function_v = is_function<_Tp>::value; + +#if _GLIBCXX_USE_BUILTIN_TRAIT(__is_reference) +template <typename _Tp> + inline constexpr bool is_reference_v = __is_reference(_Tp); +#else template <typename _Tp> inline constexpr bool is_reference_v = false; template <typename _Tp> inline constexpr bool is_reference_v<_Tp&> = true; template <typename _Tp> inline constexpr bool is_reference_v<_Tp&&> = true; +#endif + template <typename _Tp> inline constexpr bool is_arithmetic_v = is_arithmetic<_Tp>::value; template <typename _Tp>