From patchwork Fri Oct 13 21:04:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ken Matsui X-Patchwork-Id: 152764 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp2163756vqb; Fri, 13 Oct 2023 14:30:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHniWTb6Bl48A0rFNquE8Gvfy6gdXyAWtsSyndhr9EX+/Ahkz8bDxBpUSOKb2qDE+h2Olsv X-Received: by 2002:a05:622a:20e:b0:418:1f57:3f76 with SMTP id b14-20020a05622a020e00b004181f573f76mr34030796qtx.65.1697232607864; Fri, 13 Oct 2023 14:30:07 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1697232607; cv=pass; d=google.com; s=arc-20160816; b=UEDwjQR3IK7dTCIb/kQXG/P84yE1GdNj4U5FDBuyLfgArnO8XNsc5q+rxyCtvGB9XC 4pjPiKHfD+lU8JUnm/yI0j7alniuKHy817cQBs0mg1qszSCWQ2g7ejKiOEEzA5kkcxNs VbbWBVzt6+nUwtMf1sFtaUgaEdf3krQYW6inQ+Tp8QXS6SP+9zAnKfL5hDUs1j+Z9Aws 7teUPr78W+mEyFE6kMhu0Vmf8QlAYdl4G/knt1yo03LdElFuMLp1xMbVEzpdb0vRvcA4 DYtnJ6TPa93+KLNU4NsTngeA7gn0tBRzpmtgJt+zeGGuK+4tjGaSjO/BzVR644rSICcM 8LOg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:dmarc-filter:arc-filter:delivered-to:dkim-signature :dkim-filter; bh=Q8cGYOOlgBr4ka3oidY/INwakk2lw0voEZaicAwcnN0=; fh=kSSy/oyUXqQD15FLeKdymIgDBFPFITPA1Gj52CNOxRQ=; b=KdQB3oZ/tM1+R8363mtM8LQ78xNqzRRARswAjRXBMKpZhM4SPS/5QRZpuqbbsxoJBX lbFkQYIMzV71AUnR1xs6k5t4esWQZ9JWYvcdoQkQXAzRbsbmAkUZ3RHQmAn3/53sK7Tm PAiyhOy0abPvpQ7Ceb6/ItFt8p72dKa/r2UzdxFFJpeSzvEK5tVRQ1hYyEqQSRq+AO2O rgv2NRyynemYlzXscaHwOz7x5deEq1aNIr9rM27dAMQzjBXqY9ugZpQMYdoFHhyNneu+ eR2SZhmOyHR/mvIz/tFEONFmohlB9PznuZm99kQsAu/K7ygIX4N7dsGooOeC+l1USOa8 NaLA== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=H50pDKK7; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id m12-20020ac85b0c000000b0040a547f5370si1895901qtw.364.2023.10.13.14.30.07 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 13 Oct 2023 14:30:07 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=H50pDKK7; arc=pass (i=1); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 95019385CC84 for ; Fri, 13 Oct 2023 21:30:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 95019385CC84 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1697232607; bh=Q8cGYOOlgBr4ka3oidY/INwakk2lw0voEZaicAwcnN0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=H50pDKK7vYxVYKaSd4vLwLzSpDPgzUDiEl2InjWHh2FAMho4heZWIVY0Vu+7rShS1 D5c32BOqJ2ZfD3MR4jvwKke/QP1/s/Wr6zZrYgvYTDZbW3bfCwMcfSJOseYkru4LB6 J1Jw2cTJpGUCYbNU6g7/Bu5iAZLCQC74emHtlNrs= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0a-00641c01.pphosted.com (mx0a-00641c01.pphosted.com [205.220.165.146]) by sourceware.org (Postfix) with ESMTPS id E8C96385C6F0; Fri, 13 Oct 2023 21:29:18 +0000 (GMT) ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E8C96385C6F0 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=205.220.165.146 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697232560; cv=none; b=w2tCNpCso57NFnKCOWhO7glq5g49BpKvG4l8WV/YxR9bgFsnrkhU+PFGEXZ8TicHjt9MscBrCxd0DxFtj2imwcAPzJy1P3iLuXZ3OJuMqGobCtKLjOFbr1y6pIrT9Ui/C+TfLVLrkFJvqRRrxdBdH9ZoX1VdIh6jF2wyxQT4Kow= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1697232560; c=relaxed/simple; bh=zHRUm094zuZ3ZECOAp015pu8rl+10kg38IxbocgWKRo=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=wTWhdqf1Ymhsy3U06PdYm0/YFvB8smyd1B7QxI7yjWFePdmyPEUEXtjV+A+JKEIjMRZROo2EaqGUQkGJSMPaqbHioEGvTgxiheU6ye5Yf5cHC3q/HZFXY1nbuBvi8VDxLv67sZHXsa2kckAXo3Ib2agILCvXRJbAZFc1HCjzRpk= ARC-Authentication-Results: i=1; server2.sourceware.org DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E8C96385C6F0 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gcc.gnu.org Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=gcc.gnu.org Received: from pps.filterd (m0247474.ppops.net [127.0.0.1]) by mx0a-00641c01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 39DLJYbO020472; Fri, 13 Oct 2023 21:29:18 GMT Received: from mxout22.s.uw.edu (mxout22.s.uw.edu [128.95.242.222]) by mx0a-00641c01.pphosted.com (PPS) with ESMTPS id 3tq3k05975-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 13 Oct 2023 21:29:17 +0000 Received: from smtp.washington.edu (smtp.washington.edu [140.142.234.157]) by mxout22.s.uw.edu (8.14.4+UW20.07/8.14.4+UW22.04) with ESMTP id 39DLTD5d001306 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 13 Oct 2023 14:29:13 -0700 X-Auth-Received: from kmatsui-ThinkPad-X1-Carbon-Gen-9.dhcp4.washington.edu ([10.19.18.191]) (authenticated authid=kmatsui) by smtp.washington.edu (8.16.1+UW21.10/8.14.4+UW19.10) with ESMTPSA id 39DLC9cT009146 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 13 Oct 2023 14:29:13 -0700 X-UW-Orig-Sender: kmatsui@smtp.washington.edu From: Ken Matsui To: gcc-patches@gcc.gnu.org Cc: libstdc++@gcc.gnu.org, Ken Matsui Subject: [PATCH v18 26/40] libstdc++: Optimize is_object trait performance Date: Fri, 13 Oct 2023 14:04:22 -0700 Message-ID: <20231013211206.1215663-27-kmatsui@gcc.gnu.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231013211206.1215663-1-kmatsui@gcc.gnu.org> References: <20231011215049.1052142-1-kmatsui@gcc.gnu.org> <20231013211206.1215663-1-kmatsui@gcc.gnu.org> MIME-Version: 1.0 X-Proofpoint-GUID: n0tq0yA3gprbMn4OeQX4NvExk7Pl9f3q X-Proofpoint-ORIG-GUID: n0tq0yA3gprbMn4OeQX4NvExk7Pl9f3q X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-13_12,2023-10-12_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 priorityscore=1501 adultscore=0 clxscore=1034 mlxscore=0 lowpriorityscore=0 phishscore=0 spamscore=0 malwarescore=0 suspectscore=0 mlxlogscore=793 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2310130186 X-Spam-Status: No, score=-13.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NEUTRAL, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1776995944979792207 X-GMAIL-MSGID: 1779677379025620248 This patch optimizes the performance of the is_object trait by dispatching to the new __is_function and __is_reference built-in traits. libstdc++-v3/ChangeLog: * include/std/type_traits (is_object): Use __is_function and __is_reference built-in traits. (is_object_v): Likewise. Signed-off-by: Ken Matsui --- libstdc++-v3/include/std/type_traits | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/libstdc++-v3/include/std/type_traits b/libstdc++-v3/include/std/type_traits index bd57488824b..674d398c075 100644 --- a/libstdc++-v3/include/std/type_traits +++ b/libstdc++-v3/include/std/type_traits @@ -725,11 +725,20 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION { }; /// is_object +#if _GLIBCXX_USE_BUILTIN_TRAIT(__is_function) \ + && _GLIBCXX_USE_BUILTIN_TRAIT(__is_reference) + template + struct is_object + : public __bool_constant::value)> + { }; +#else template struct is_object : public __not_<__or_, is_reference<_Tp>, is_void<_Tp>>>::type { }; +#endif template struct is_member_pointer; @@ -3305,8 +3314,17 @@ template inline constexpr bool is_arithmetic_v = is_arithmetic<_Tp>::value; template inline constexpr bool is_fundamental_v = is_fundamental<_Tp>::value; + +#if _GLIBCXX_USE_BUILTIN_TRAIT(__is_function) \ + && _GLIBCXX_USE_BUILTIN_TRAIT(__is_reference) +template + inline constexpr bool is_object_v + = !(__is_function(_Tp) || __is_reference(_Tp) || is_void<_Tp>::value); +#else template inline constexpr bool is_object_v = is_object<_Tp>::value; +#endif + template inline constexpr bool is_scalar_v = is_scalar<_Tp>::value; template