diff mbox series

[06/22] Use popcount_hwi rather than builtin

Message ID	20231004123921.634024-7-j@lambda.is
State	Unresolved
Headers	Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 222F6385B515 From: =?utf-8?q?J=C3=B8rgen_Kvalsvik?= <j@lambda.is> To: gcc-patches@gcc.gnu.org Cc: mliska@suse.cz, jh@suse.cz, =?utf-8?q?J=C3=B8rgen_Kvalsvik?= <jorgen.kvalsvik@woven.toyota> Subject: [PATCH 06/22] Use popcount_hwi rather than builtin Date: Wed, 4 Oct 2023 21:39:06 +0900 Message-Id: <20231004123921.634024-7-j@lambda.is> In-Reply-To: <20231004123921.634024-1-j@lambda.is> References: <20231004123921.634024-1-j@lambda.is> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX
Series	[01/22] Add condition coverage profiling \| [01/22] Add condition coverage profiling [02/22] Add "Condition coverage profiling" term to --help [03/22] Mention relevant flags in condition coverage docs [04/22] Describe, remove ATTRIBUTE_UNUSED from tag_conditions [05/22] Describe condition_info [06/22] Use popcount_hwi rather than builtin [07/22] Describe add_condition_counts [08/22] Describe output_conditions [09/22] Find reachable conditions unbounded by dominators [10/22] Prune search for boolean expr on goto, return [11/22] Add test case showing cross-decision fusing [12/22] Do two-phase filtering in expr isolation [13/22] Handle split-outcome with intrusive flag [14/22] Unify expression candidate set refinement logic [15/22] Fix candidate, neighborhood set reduction phase [16/22] Rename pathological -> setjmp [17/22] Mark contracted-past nodes in reachable [18/22] Don't contract into random edge in multi-succ node [19/22] Beautify assert [20/22] Don't try to reduce NG from dominators [21/22] Walk the cfg in topological order, not depth-first [22/22] Return value on separate line

Checks

Context	Check	Description
snail/gcc-patch-check	warning	Git am fail log

Commit Message

Jørgen Kvalsvik Oct. 4, 2023, 12:39 p.m. UTC

  From: Jørgen Kvalsvik <jorgen.kvalsvik@woven.toyota>

---
 gcc/gcov.cc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Jan Hubicka Oct. 5, 2023, 1:01 p.m. UTC | #1

Hi,
can you please also squash those changes which fixes patch #1
so it is easier to review?
Honza
> From: Jørgen Kvalsvik <jorgen.kvalsvik@woven.toyota>
> 
> ---
>  gcc/gcov.cc | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/gcc/gcov.cc b/gcc/gcov.cc
> index 274f2fc5d9f..35be97cf5ac 100644
> --- a/gcc/gcov.cc
> +++ b/gcc/gcov.cc
> @@ -46,6 +46,7 @@ along with Gcov; see the file COPYING3.  If not see
>  #include "color-macros.h"
>  #include "pretty-print.h"
>  #include "json.h"
> +#include "hwint.h"
>  
>  #include <zlib.h>
>  #include <getopt.h>
> @@ -159,7 +160,7 @@ condition_info::condition_info (): truev (0), falsev (0), n_terms (0)
>  
>  int condition_info::popcount () const
>  {
> -    return __builtin_popcountll (truev) + __builtin_popcountll (falsev);
> +    return popcount_hwi (truev) + popcount_hwi (falsev);
>  }
>  
>  /* Describes a basic block. Contains lists of arcs to successor and
> -- 
> 2.30.2
>

diff mbox series

Patch

diff --git a/gcc/gcov.cc b/gcc/gcov.cc
index 274f2fc5d9f..35be97cf5ac 100644
--- a/gcc/gcov.cc
+++ b/gcc/gcov.cc
@@ -46,6 +46,7 @@  along with Gcov; see the file COPYING3.  If not see
 #include "color-macros.h"
 #include "pretty-print.h"
 #include "json.h"
+#include "hwint.h"
 
 #include <zlib.h>
 #include <getopt.h>
@@ -159,7 +160,7 @@  condition_info::condition_info (): truev (0), falsev (0), n_terms (0)
 
 int condition_info::popcount () const
 {
-    return __builtin_popcountll (truev) + __builtin_popcountll (falsev);
+    return popcount_hwi (truev) + popcount_hwi (falsev);
 }
 
 /* Describes a basic block. Contains lists of arcs to successor and