From patchwork Mon Oct 2 12:05:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sergei Trofimovich X-Patchwork-Id: 147256 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2a8e:b0:403:3b70:6f57 with SMTP id in14csp1376854vqb; Mon, 2 Oct 2023 05:07:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHrUS/yRid6wiygH8IvGacMK8wGz0uKe/jsyXCsAwUxmzViaKMvHTutRgcpVTE6iliO9Hqu X-Received: by 2002:a5d:410d:0:b0:314:1ce9:3c86 with SMTP id l13-20020a5d410d000000b003141ce93c86mr9146762wrp.0.1696248425711; Mon, 02 Oct 2023 05:07:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1696248425; cv=none; d=google.com; s=arc-20160816; b=BzM9G3oBt1zTFCZlmuxAHIclmXlIBxxRE/hGr/pYOL8PMc6J+aAT3g+XTuHwlP2wjt PDcPFOdlOnN23SC7LBGR2c/qfu9iyUoyt76g377RsNGYMyJBk6tSy4WBAF9n1SmXHUW9 5sJm0W3mOaBImO/pHOJ3b7Bd5yF+/1MpRiBU5H5ozFiQM706z3RvaxuqxULHxvZWP+pf uqWwn+Nz/JdZQCeJ5xNtJuFeI+Kvwzm56iAce4q7B+A1f9FWGwdBDT+KZfD8E2XDCg0A LBeiZlHQFIX2DDmstVvSVgPERJ6I9Kc9EVo9BZSg/iM76bHRkvTM4GMiYa8w89ghbB8B 9aRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature :dmarc-filter:delivered-to; bh=JoThZ/ETNv5lyE1s5EVFUvwuacbDovWEzyZq7+yahGQ=; fh=2iCwANOceVaJ/HV7wJZWuhiZOexSIBB39LJk6iFCtNs=; b=BZ2xvOWpaxsBximfZRCcMr5nkSWtE+xXzIdFOwAlBnqBlPM6vmQxqJIjrKOrNs8+u4 jxiZSdS6VWRTySA6tnC12/U+9hBpsXjBDD/uP3Y2XhO63z+Y2gTVWfliJ+apizTScvbq j4JreopNdLB2Ubkgqb0f5xgdwr+2d3yE6JbBC38prbtFaEDsts5QUveU3OnPo2eFVXOp dvvYBLHD55cZTM9l98SGdkRTMol1purYlgSzFuVy2ZMvx4DlLTHudlIfjwweI1sXQ0qY p7ccH9u2xwV0zVSMLhxwqk7aTujboSWpGQyHbYtphGh6yXENDe3o9JIeW8wN+4iIatwr d4Yg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=narsUOzN; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id s20-20020a056402165400b005360a551c4csi5537090edx.74.2023.10.02.05.07.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 05:07:05 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=narsUOzN; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 99578385ED43 for ; Mon, 2 Oct 2023 12:06:53 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by sourceware.org (Postfix) with ESMTPS id 4689E3858C5E for ; Mon, 2 Oct 2023 12:06:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4689E3858C5E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-x433.google.com with SMTP id ffacd0b85a97d-307d58b3efbso14394297f8f.0 for ; Mon, 02 Oct 2023 05:06:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696248380; x=1696853180; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=JoThZ/ETNv5lyE1s5EVFUvwuacbDovWEzyZq7+yahGQ=; b=narsUOzNoNb9VlhE7ukFPASKC19Ju903HQdjhyRHGmq+gQAHGLn1Wa+KiQ/Zbpzc1+ EoGTfj3M6fU49m9StgASQqJ0DeQ1gcSvfr5+8RycZ9AYTsLXh+vvuQ1xGy/GOqNmPWWG +IdieSXHPRCOgtu1qh3l8Hjm1qHWoA6xxTezpg6cWp2SKFzTL6QwI1rkg7UenGUawWIf aJpIZ86OHWfIlnrHQYOe5+JEGzLQmWKXEpq3QdGAQ76hW8EpMP/d4S/GUy611eM/3adw jaIrx5rBbZO1PnNQWXTylK4gF8IxPZEJLji4mkPKr2K40RMC3c9A5dDYLiCUr1uOI4dQ jMjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696248380; x=1696853180; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=JoThZ/ETNv5lyE1s5EVFUvwuacbDovWEzyZq7+yahGQ=; b=XV9veMrbA5DDz/dsBznvOmaooghkdQWODd4rrSQJOG0VN3LWX6dphi5uVsDKNkbiNI +hs0BD0jRu0TnCrzO+5Hn5d4i5jv/3Jig+xHlUX1g9f8P9kIVC9mkHkWBRTwPISDvgPd EjnDro1IXn2ODk7jCiAQ7wwlUgKHx5taVKZVkK9fnYbkOYv5EIv/eIEYcYifrxZTyI5n 77e/IkE4muGPxnO0TfNDAPP+N42W3E1lbsOc6cju+eFbKwPwh66Ybr4mje03T1yKwZYg 4WHE+pbjsrnyPDK8iCrDMFZit4wljN5O1MYFt2if6A3ZwtO6EHOf03JXbjVot6bZs0V7 4lgw== X-Gm-Message-State: AOJu0Ywp7tfjRctsF8lT1VmKErwG7s4OcdSSFp8+7c6MVCR03Xv7boOp lZ70G8apF2vtuXuMYc6Rz9NyuDaKHtM= X-Received: by 2002:adf:f38c:0:b0:323:39d2:5803 with SMTP id m12-20020adff38c000000b0032339d25803mr10559766wro.3.1696248379595; Mon, 02 Oct 2023 05:06:19 -0700 (PDT) Received: from nz.home (host86-139-202-110.range86-139.btcentralplus.com. [86.139.202.110]) by smtp.gmail.com with ESMTPSA id d12-20020adf9b8c000000b003233a8b425esm14227719wrc.115.2023.10.02.05.05.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Oct 2023 05:06:10 -0700 (PDT) Received: by nz.home (Postfix, from userid 1000) id 50738112D7FFB8; Mon, 2 Oct 2023 13:05:46 +0100 (BST) From: Sergei Trofimovich To: gcc-patches@gcc.gnu.org Cc: Sergei Trofimovich , Sergei Trofimovich Subject: [PATCH] Makefile.tpl: disable -Werror for feedback stage [PR111663] Date: Mon, 2 Oct 2023 13:05:45 +0100 Message-ID: <20231002120545.1524306-1-slyich@gmail.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 X-Spam-Status: No, score=-11.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1778645389134606216 X-GMAIL-MSGID: 1778645389134606216 From: Sergei Trofimovich Without the change profiled bootstrap fails for various warnings on master branch as: $ ../gcc/configure $ make profiledbootstrap ... gcc/genmodes.cc: In function ‘int main(int, char**)’: gcc/genmodes.cc:2152:1: error: ‘gcc/build/genmodes.gcda’ profile count data file not found [-Werror=missing-profile] ... gcc/gengtype-parse.cc: In function ‘void parse_error(const char*, ...)’: gcc/gengtype-parse.cc:142:21: error: ‘%s’ directive argument is null [-Werror=format-overflow=] The change removes -Werror just like autofeedback does today. / PR bootstrap/111663 * Makefile.tpl (STAGEfeedback_CONFIGURE_FLAGS): Disable -Werror. * Makefile.in: Regenerate. --- Makefile.in | 4 ++++ Makefile.tpl | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/Makefile.in b/Makefile.in index 2f136839c35..e0e3c4c8fe8 100644 --- a/Makefile.in +++ b/Makefile.in @@ -638,6 +638,10 @@ STAGEtrain_TFLAGS = $(filter-out -fchecking=1,$(STAGE3_TFLAGS)) STAGEfeedback_CFLAGS = $(STAGE4_CFLAGS) -fprofile-use -fprofile-reproducible=parallel-runs STAGEfeedback_TFLAGS = $(STAGE4_TFLAGS) +# Disable warnings as errors for a few reasons: +# - sources for gen* binaries do not have .gcda files available +# - inlining decisions generate extra warnings +STAGEfeedback_CONFIGURE_FLAGS = $(filter-out --enable-werror-always,$(STAGE_CONFIGURE_FLAGS)) STAGEautoprofile_CFLAGS = $(filter-out -gtoggle,$(STAGE2_CFLAGS)) -g STAGEautoprofile_TFLAGS = $(STAGE2_TFLAGS) diff --git a/Makefile.tpl b/Makefile.tpl index 5872dd03f2c..8b7783bb4f1 100644 --- a/Makefile.tpl +++ b/Makefile.tpl @@ -561,6 +561,10 @@ STAGEtrain_TFLAGS = $(filter-out -fchecking=1,$(STAGE3_TFLAGS)) STAGEfeedback_CFLAGS = $(STAGE4_CFLAGS) -fprofile-use -fprofile-reproducible=parallel-runs STAGEfeedback_TFLAGS = $(STAGE4_TFLAGS) +# Disable warnings as errors for a few reasons: +# - sources for gen* binaries do not have .gcda files available +# - inlining decisions generate extra warnings +STAGEfeedback_CONFIGURE_FLAGS = $(filter-out --enable-werror-always,$(STAGE_CONFIGURE_FLAGS)) STAGEautoprofile_CFLAGS = $(filter-out -gtoggle,$(STAGE2_CFLAGS)) -g STAGEautoprofile_TFLAGS = $(STAGE2_TFLAGS)