From patchwork Thu Sep 21 06:54:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "juzhe.zhong@rivai.ai" X-Patchwork-Id: 142747 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp4653944vqi; Wed, 20 Sep 2023 23:55:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGmEMEHJOOGDmLTxN/xlvWNX/REprcxW2glsnMY21hpG0B3/fL2xNxS7rmVQq9gwSIpDAzh X-Received: by 2002:a19:e012:0:b0:503:60e:91f5 with SMTP id x18-20020a19e012000000b00503060e91f5mr3893938lfg.36.1695279325295; Wed, 20 Sep 2023 23:55:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695279325; cv=none; d=google.com; s=arc-20160816; b=Z1EwwP406aHCFUX1fvKcojT899pV2mAc+PO0e1exfvtFI3QUXhrQWwiJEoNMz6K32H JHzfUB0KhQrWsw4bczL8W9FzdQp9c3mjnIXsBtVvTX0bfhQprF45k5gXz3t92IKfEVQo 0GDI244cZTRBMQhqq5nCfrnfMOFGPlkXKZwu0fQqysgMvWkA62kvDcePhlvAf3+9ac6z F/YbSkFt5AzbSannrwfgI0Ns6mCxyztgKN5nq7WuGhhToUKPyYyUOpvPn5ntCsxKgf2R VWDi0C2/fwj1ZKA2wGWF7UMhk2tw9qV1aBoazSAZVqosyZSjqQMCID2n/glbsEuuIzly 7BSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:feedback-id :content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dmarc-filter:delivered-to; bh=6yiL9lnJ1RjRv1m2WyaHBWt1hT+rwGNLZPz7bZPrLsU=; fh=PtMtqESxXHgFtExqzFSA1R6GKCRNC9VuCVaKqHsd/k0=; b=LcJfqMQVPUp2VkK32vLRCADCpQnGsFvc3h0JJrLT3kBUHfQVrGtU5FpgcCymtoku/4 CZJcXUzNDEwEvW5SIPpfAzCYB6db+Ug2cfdfnsOJu1Cwh6Hfj6Tg4TkqE8Bmy5NnyGRp ZE/bhSCnl9m7Xkmxn9NeU6Al4z9raE0zeVqgXMT+DZfI0OyUUQtjPnvvRTVRKu8wkb/m vmX+JAhIldGvvJ+ZKqVcjlOOtgQ+uyJRE1Atfp2d2byGDXYi6Ekcwp5F4PUgxDgdKNn3 iIsgy4Wx2R75V85OxjIxT1YOUANewpdeOwW5GFrPIn7dsZjXTJqGj9F+IY4DIDvowKxk a9xg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id k14-20020aa7d8ce000000b0051e065bbc1dsi599922eds.36.2023.09.20.23.55.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Sep 2023 23:55:25 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A82903857732 for ; Thu, 21 Sep 2023 06:55:20 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtpbgbr2.qq.com (smtpbgbr2.qq.com [54.207.22.56]) by sourceware.org (Postfix) with ESMTPS id EDE503858C52 for ; Thu, 21 Sep 2023 06:54:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EDE503858C52 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivai.ai Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivai.ai X-QQ-mid: bizesmtp79t1695279288tpeo5bcs Received: from rios-cad121.hadoop.rioslab.org ( [58.60.1.9]) by bizesmtp.qq.com (ESMTP) with id ; Thu, 21 Sep 2023 14:54:47 +0800 (CST) X-QQ-SSF: 01400000000000G0V000000A0000000 X-QQ-FEAT: RrZlkntZBfmtZLkRVo5uBePh6buO41v49fWsq7Wqpr4Awnoa3RRQLfKyaaka4 jVRi/ZBMc+Oz5lXWF9nuYTR9TxLjdvmcT2sDnjBpXNrHseSZl91OmcMtZwf9HClnkHPBNNP XcQNzDLqREa3AzeeXAvEY1OToJhU8cxOYpYt72VLiKqP5r2D/Gy9LaS/t5KVBnzH7saKJuF xwSt6giMEg/QxWZVwGTKh4VOAJAz/zm2gU3C4GLvsLHfUPi//Rj/R8O/Er9i/LJCOosMYjS dDvxNMUaBs2fRFuJ3S1uLRNb7OrZo7rUg629H53sKAoa1PN7LOYVKvDQhP2lpDhSJvdVOVk jLln0EfybXI6xAxqJ21cD7EzmWY2Xe5vKWc6wu7Tg64LQOkuj+Ei6KfGtrwzG1EEXi8bp1k keQZVdn/P94ko8RsQoBu2A== X-QQ-GoodBg: 2 X-BIZMAIL-ID: 3370697449289235310 From: Juzhe-Zhong To: gcc-patches@gcc.gnu.org Cc: kito.cheng@gmail.com, palmer@dabbelt.com, jeffreyalaw@gmail.com, rdapp.gcc@gmail.com, Juzhe-Zhong Subject: [PATCH] RISC-V: Fix SUBREG move of VLS mode[PR111486] Date: Thu, 21 Sep 2023 14:54:33 +0800 Message-Id: <20230921065433.3298121-1-juzhe.zhong@rivai.ai> X-Mailer: git-send-email 2.36.3 MIME-Version: 1.0 X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:rivai.ai:qybglogicsvrgz:qybglogicsvrgz7a-one-0 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, KAM_SHORT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, WEIRD_PORT autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777629214048934578 X-GMAIL-MSGID: 1777629214048934578 This patch fixes this bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=111486 Before this patch, we can only handle (subreg:DI (reg:V8QI)) The PR ICE: during RTL pass: reload testcase.c: In function 'foo': testcase.c:8:1: internal compiler error: in require, at machmode.h:313 8 | } | ^ 0xa40cd2 opt_mode::require() const /repo/gcc-trunk/gcc/machmode.h:313 0xa47091 opt_mode::require() const /repo/gcc-trunk/gcc/config/riscv/riscv.cc:2546 0xa47091 riscv_legitimize_move(machine_mode, rtx_def*, rtx_def*) /repo/gcc-trunk/gcc/config/riscv/riscv.cc:2543 0x1f1df10 gen_movdi(rtx_def*, rtx_def*) /repo/gcc-trunk/gcc/config/riscv/riscv.md:2024 0x10f1423 rtx_insn* insn_gen_fn::operator()(rtx_def*, rtx_def*) const /repo/gcc-trunk/gcc/recog.h:411 0x10f1423 emit_move_insn_1(rtx_def*, rtx_def*) /repo/gcc-trunk/gcc/expr.cc:4164 0x10f183d emit_move_insn(rtx_def*, rtx_def*) /repo/gcc-trunk/gcc/expr.cc:4334 0x13070ec lra_emit_move(rtx_def*, rtx_def*) /repo/gcc-trunk/gcc/lra.cc:509 0x132295b curr_insn_transform /repo/gcc-trunk/gcc/lra-constraints.cc:4748 0x1324335 lra_constraints(bool) /repo/gcc-trunk/gcc/lra-constraints.cc:5488 0x130a3d4 lra(_IO_FILE*) /repo/gcc-trunk/gcc/lra.cc:2419 0x12bb629 do_reload /repo/gcc-trunk/gcc/ira.cc:5970 0x12bb629 execute /repo/gcc-trunk/gcc/ira.cc:6156 Because of (subreg:DI (reg:V2QI)) PR target/111486 gcc/ChangeLog: * config/riscv/riscv.cc (riscv_legitimize_move): Fix bug. gcc/testsuite/ChangeLog: * gcc.target/riscv/rvv/autovec/pr111486.c: New test. --- gcc/config/riscv/riscv.cc | 3 ++- gcc/testsuite/gcc.target/riscv/rvv/autovec/pr111486.c | 11 +++++++++++ 2 files changed, 13 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.target/riscv/rvv/autovec/pr111486.c diff --git a/gcc/config/riscv/riscv.cc b/gcc/config/riscv/riscv.cc index 29d439b4282..6158953098d 100644 --- a/gcc/config/riscv/riscv.cc +++ b/gcc/config/riscv/riscv.cc @@ -2525,7 +2525,8 @@ riscv_legitimize_move (machine_mode mode, rtx dest, rtx src) machine_mode vmode = GET_MODE (SUBREG_REG (src)); unsigned int mode_size = GET_MODE_SIZE (mode).to_constant (); unsigned int vmode_size = GET_MODE_SIZE (vmode).to_constant (); - unsigned int nunits = vmode_size / mode_size; + /* We should be able to handle both partial and paradoxical subreg. */ + unsigned int nunits = vmode_size > mode_size ? vmode_size / mode_size : 1; scalar_mode smode = as_a (mode); unsigned int index = SUBREG_BYTE (src).to_constant () / mode_size; unsigned int num = smode == DImode && !TARGET_VECTOR_ELEN_64 ? 2 : 1; diff --git a/gcc/testsuite/gcc.target/riscv/rvv/autovec/pr111486.c b/gcc/testsuite/gcc.target/riscv/rvv/autovec/pr111486.c new file mode 100644 index 00000000000..2ba2a363399 --- /dev/null +++ b/gcc/testsuite/gcc.target/riscv/rvv/autovec/pr111486.c @@ -0,0 +1,11 @@ +/* { dg-do compile } */ +/* { dg-options "-march=rv64iv -mabi=lp64d -O2" } */ + +typedef char __attribute__((__vector_size__ (1))) V; + +V +foo (V v, long x) +{ + x &= v[0]; + return v + (char) x; +}