From patchwork Mon Sep 18 07:07:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "juzhe.zhong@rivai.ai" X-Patchwork-Id: 141262 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:172:b0:3f2:4152:657d with SMTP id h50csp2477382vqi; Mon, 18 Sep 2023 00:08:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGtxonioKrZzdm9JMyTyE/+u4T1aW/m9gbbVbLpyYw5r/oOurNipKVAAgClFGjkA+ottvM7 X-Received: by 2002:a05:6512:39c9:b0:500:90d1:90a6 with SMTP id k9-20020a05651239c900b0050090d190a6mr8386572lfu.63.1695020881995; Mon, 18 Sep 2023 00:08:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1695020881; cv=none; d=google.com; s=arc-20160816; b=bEe69bAMmq+MNgV2p0piQVyMhmDPqkLvGTGFbxue4jY9+QxcXoAVkUsbeqaEGv9dEN K7oIg5Nt1z11cNmzASb2aooz0XJD1cxNumCKlP8xfRHY/eJO+/hp7DKxx1u0tnlHSyQP +mkKiuO6hVPMXNKZcDDxe2cjBOf8tjZ9g2+7Kp+xW/JM+lGEgs9/oraXVEWknYXaZ/+U 5MvnVNEjBjLlwS3PsHGkbNiu7kO8qojz200HjF1/M/+AZbMukzka+OC507a4j6roA27D UmNZhlfgfXakLhtx300iKFyWHKH2CUvoMqqhtMUxBURuIUzP+pCukw+DBvZYZHY++rgf qQQQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:feedback-id :content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dmarc-filter:delivered-to; bh=1gCYwl7PftcNuwr5nhq8Ftr5cDmU429GuMTxadvG2oo=; fh=12MRPJmZ1mgDpHqWoogMKqnaGRGM2b7lcuJroqfjJiw=; b=Uhtq0Owanr+M3uNWPGhFkXrfJQDKab2DydUB6EkrNUcfHD7nVxUxxFdkP4loSAaEUx VUj63Cm7PM9sTa3UvWpoH+78gmeHe7ZR+1XRPc0qcf2xL1I8ZK6uYt4MLjUKb9RqPeg/ wtJx2kVRUCR+9/wOfjpfNih1opqyaZpyrsP7ua26niu003PcDHXPODyJKs4t8tdLurK7 VheU7vj7ckNZZrutHe3vWLRDAaqI5z8gV9NnflkbOZJwAY7J2PeCVrRDxuPApsNWLQv1 6ZRhurvPPVwQ9PTBSE7l2b0SCgf53BctF8NCniP/COCrSEvkH54yOD47J5P7fAkcc7EK CcDA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id c1-20020aa7d601000000b0052f1d7fd47esi7585089edr.577.2023.09.18.00.08.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Sep 2023 00:08:01 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 11807385843A for ; Mon, 18 Sep 2023 07:07:56 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtpbg153.qq.com (smtpbg153.qq.com [13.245.218.24]) by sourceware.org (Postfix) with ESMTPS id 026B83858D32 for ; Mon, 18 Sep 2023 07:07:27 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 026B83858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivai.ai Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivai.ai X-QQ-mid: bizesmtp67t1695020840trdob75v Received: from rios-cad121.hadoop.rioslab.org ( [58.60.1.9]) by bizesmtp.qq.com (ESMTP) with id ; Mon, 18 Sep 2023 15:07:19 +0800 (CST) X-QQ-SSF: 01400000000000G0V000000C0000000 X-QQ-FEAT: SX/WFj88WPW/CuOgalOFdwzut9r6OE0+fS+OCPXp2gtan26aTBRh/KpHolUBj JewzaWQHrGJxRL1aV1kRRyg5HRarFHsRbRi4lIHYWVL/XKv52C0eE9PcTjVy2Vex1dX9BrQ ycwV6l+6/qut7+8KlaaFVI4XBIAXGfBO1LE1ykn6jajGdpSABzjwCkx0DA0jrOat+q++8Kn sCRAx1MrfQceJvM9aePUSsPaM5xcephF+Wx2SkdPiQd1zKqYapV+jNKlynjNTjj5SQKCx8o voXlLspAjb8Pw4ErnosO9WuwI/+k9thr84t+djV7n4uE/pMM5ZhlZcNP4wBPErCNHZinlYI 7OL+Fxgeyp2KIYY0pFeD5a91CTGa2rOSt4qnW250bSEd4ptp6w5wiETxA0DVxl86uPy2s4I vGdWl2ZwxcEIwJglbp0n0g== X-QQ-GoodBg: 2 X-BIZMAIL-ID: 14254132682625901080 From: Juzhe-Zhong To: gcc-patches@gcc.gnu.org Cc: kito.cheng@gmail.com, kito.cheng@sifive.com, jeffreyalaw@gmail.com, rdapp.gcc@gmail.com, Juzhe-Zhong Subject: [PATCH] RISC-V: Remove autovec-vls.md file and clean up VLS move modes[NFC] Date: Mon, 18 Sep 2023 15:07:13 +0800 Message-Id: <20230918070713.3569601-1-juzhe.zhong@rivai.ai> X-Mailer: git-send-email 2.36.3 MIME-Version: 1.0 X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:rivai.ai:qybglogicsvrgz:qybglogicsvrgz7a-one-0 X-Spam-Status: No, score=-9.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_ASCII_DIVIDERS, KAM_DMARC_STATUS, KAM_SHORT, MEDICAL_SUBJECT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1777358216677709193 X-GMAIL-MSGID: 1777358216677709193 We have largely supportted VLS modes. Only move patterns of VLS modes are different from VLS patterns. The rest of them are the same. We always extend the current VLA patterns with VLSmodes: VI --> V_VLSI VF --> V_VLSF It makes no sense to have a separate file holding a very few VLS patterns that can not be extended from the current VLA patterns. So remove autovec-vls.md gcc/ChangeLog: * config/riscv/vector.md (mov): New pattern. (*mov_mem_to_mem): Ditto. (*mov): Ditto. (@mov_lra): Ditto. (*mov_lra): Ditto. (*mov_vls): Ditto. (movmisalign): Ditto. (@vec_duplicate): Ditto. * config/riscv/autovec-vls.md: Removed. --- gcc/config/riscv/autovec-vls.md | 196 -------------------------------- gcc/config/riscv/vector.md | 172 +++++++++++++++++++++++++++- 2 files changed, 170 insertions(+), 198 deletions(-) delete mode 100644 gcc/config/riscv/autovec-vls.md diff --git a/gcc/config/riscv/autovec-vls.md b/gcc/config/riscv/autovec-vls.md deleted file mode 100644 index 3488f452e5d..00000000000 --- a/gcc/config/riscv/autovec-vls.md +++ /dev/null @@ -1,196 +0,0 @@ -;; Machine description for VLS of RVV auto-vectorization. -;; Copyright (C) 2023 Free Software Foundation, Inc. -;; Contributed by Juzhe Zhong (juzhe.zhong@rivai.ai), RiVAI Technologies Ltd. - -;; This file is part of GCC. - -;; GCC is free software; you can redistribute it and/or modify -;; it under the terms of the GNU General Public License as published by -;; the Free Software Foundation; either version 3, or (at your option) -;; any later version. - -;; GCC is distributed in the hope that it will be useful, -;; but WITHOUT ANY WARRANTY; without even the implied warranty of -;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -;; GNU General Public License for more details. - -;; You should have received a copy of the GNU General Public License -;; along with GCC; see the file COPYING3. If not see -;; . - -;; We define VLS modes as 'define_insn_and_split' with normal -;; RTX_CODE operation, so we can gain benefits from Combine optimizations. - -;; ----------------------------------------------------------------- -;; ---- Moves Operations -;; ----------------------------------------------------------------- - -(define_expand "mov" - [(set (match_operand:VLS_AVL_IMM 0 "reg_or_mem_operand") - (match_operand:VLS_AVL_IMM 1 "general_operand"))] - "TARGET_VECTOR" -{ - if (riscv_vector::legitimize_move (operands[0], operands[1])) - DONE; -}) - -(define_insn_and_split "*mov_mem_to_mem" - [(set (match_operand:VLS_AVL_IMM 0 "memory_operand") - (match_operand:VLS_AVL_IMM 1 "memory_operand"))] - "TARGET_VECTOR && can_create_pseudo_p ()" - "#" - "&& 1" - [(const_int 0)] - { - if (GET_MODE_BITSIZE (mode).to_constant () <= MAX_BITS_PER_WORD) - { - /* Opitmize the following case: - - typedef int8_t v2qi __attribute__ ((vector_size (2))); - v2qi v = *(v2qi*)in; - *(v2qi*)out = v; - - We prefer scalar load/store instead of vle.v/vse.v when - the VLS modes size is smaller scalar mode. */ - machine_mode mode; - unsigned size = GET_MODE_BITSIZE (mode).to_constant (); - if (FLOAT_MODE_P (mode)) - mode = mode_for_size (size, MODE_FLOAT, 0).require (); - else - mode = mode_for_size (size, MODE_INT, 0).require (); - emit_move_insn (gen_lowpart (mode, operands[0]), - gen_lowpart (mode, operands[1])); - } - else - { - operands[1] = force_reg (mode, operands[1]); - emit_move_insn (operands[0], operands[1]); - } - DONE; - } - [(set_attr "type" "vmov")] -) - -(define_insn_and_split "*mov" - [(set (match_operand:VLS_AVL_IMM 0 "reg_or_mem_operand" "=vr, m, vr") - (match_operand:VLS_AVL_IMM 1 "reg_or_mem_operand" " m,vr, vr"))] - "TARGET_VECTOR - && (register_operand (operands[0], mode) - || register_operand (operands[1], mode))" - "@ - # - # - vmv%m1r.v\t%0,%1" - "&& reload_completed - && (!register_operand (operands[0], mode) - || !register_operand (operands[1], mode))" - [(const_int 0)] - { - bool ok_p = riscv_vector::legitimize_move (operands[0], operands[1]); - gcc_assert (ok_p); - DONE; - } - [(set_attr "type" "vmov")] -) - -(define_expand "mov" - [(set (match_operand:VLS_AVL_REG 0 "reg_or_mem_operand") - (match_operand:VLS_AVL_REG 1 "general_operand"))] - "TARGET_VECTOR" -{ - bool ok_p = riscv_vector::legitimize_move (operands[0], operands[1]); - gcc_assert (ok_p); - DONE; -}) - -(define_expand "@mov_lra" - [(parallel - [(set (match_operand:VLS_AVL_REG 0 "reg_or_mem_operand") - (match_operand:VLS_AVL_REG 1 "reg_or_mem_operand")) - (clobber (match_scratch:P 2))])] - "TARGET_VECTOR && (lra_in_progress || reload_completed)" -{}) - -(define_insn_and_split "*mov_lra" - [(set (match_operand:VLS_AVL_REG 0 "reg_or_mem_operand" "=vr, m,vr") - (match_operand:VLS_AVL_REG 1 "reg_or_mem_operand" " m,vr,vr")) - (clobber (match_scratch:P 2 "=&r,&r,X"))] - "TARGET_VECTOR && (lra_in_progress || reload_completed) - && (register_operand (operands[0], mode) - || register_operand (operands[1], mode))" - "#" - "&& reload_completed" - [(const_int 0)] -{ - if (REG_P (operands[0]) && REG_P (operands[1])) - emit_insn (gen_rtx_SET (operands[0], operands[1])); - else - { - emit_move_insn (operands[2], gen_int_mode (GET_MODE_NUNITS (mode), - Pmode)); - unsigned insn_flags - = GET_MODE_CLASS (mode) == MODE_VECTOR_BOOL - ? riscv_vector::UNARY_MASK_OP - : riscv_vector::UNARY_OP; - riscv_vector::emit_nonvlmax_insn (code_for_pred_mov (mode), - insn_flags, operands, operands[2]); - } - DONE; -} - [(set_attr "type" "vmov")] -) - -(define_insn "*mov_vls" - [(set (match_operand:VLS 0 "register_operand" "=vr") - (match_operand:VLS 1 "register_operand" " vr"))] - "TARGET_VECTOR" - "vmv%m1r.v\t%0,%1" - [(set_attr "type" "vmov") - (set_attr "mode" "")]) - -(define_insn "*mov_vls" - [(set (match_operand:VLSB 0 "register_operand" "=vr") - (match_operand:VLSB 1 "register_operand" " vr"))] - "TARGET_VECTOR" - "vmv1r.v\t%0,%1" - [(set_attr "type" "vmov") - (set_attr "mode" "")]) - -(define_expand "movmisalign" - [(set (match_operand:VLS 0 "nonimmediate_operand") - (match_operand:VLS 1 "general_operand"))] - "TARGET_VECTOR" - { - /* To support misalign data movement, we should use - minimum element alignment load/store. */ - unsigned int size = GET_MODE_SIZE (GET_MODE_INNER (mode)); - poly_int64 nunits = GET_MODE_NUNITS (mode) * size; - machine_mode mode = riscv_vector::get_vector_mode (QImode, nunits).require (); - operands[0] = gen_lowpart (mode, operands[0]); - operands[1] = gen_lowpart (mode, operands[1]); - if (MEM_P (operands[0]) && !register_operand (operands[1], mode)) - operands[1] = force_reg (mode, operands[1]); - riscv_vector::emit_vlmax_insn (code_for_pred_mov (mode), riscv_vector::UNARY_OP, operands); - DONE; - } -) - -;; ----------------------------------------------------------------- -;; ---- Duplicate Operations -;; ----------------------------------------------------------------- - -(define_insn_and_split "@vec_duplicate" - [(set (match_operand:VLS 0 "register_operand") - (vec_duplicate:VLS - (match_operand: 1 "reg_or_int_operand")))] - "TARGET_VECTOR && can_create_pseudo_p ()" - "#" - "&& 1" - [(const_int 0)] - { - riscv_vector::emit_vlmax_insn (code_for_pred_broadcast (mode), - riscv_vector::UNARY_OP, operands); - DONE; - } - [(set_attr "type" "vector")] -) diff --git a/gcc/config/riscv/vector.md b/gcc/config/riscv/vector.md index 939e992cad1..40512e8d864 100644 --- a/gcc/config/riscv/vector.md +++ b/gcc/config/riscv/vector.md @@ -25,7 +25,6 @@ ;; - Intrinsics (https://github.com/riscv/rvv-intrinsic-doc) ;; - Auto-vectorization (autovec.md) ;; - Optimization (autovec-opt.md) -;; - VLS patterns (autovec-vls.md) (include "vector-iterators.md") @@ -1210,6 +1209,160 @@ [(set_attr "type" "vmov,vlde,vste") (set_attr "mode" "")]) +;; ----------------------------------------------------------------- +;; ---- VLS Moves Operations +;; ----------------------------------------------------------------- + +(define_expand "mov" + [(set (match_operand:VLS_AVL_IMM 0 "reg_or_mem_operand") + (match_operand:VLS_AVL_IMM 1 "general_operand"))] + "TARGET_VECTOR" +{ + if (riscv_vector::legitimize_move (operands[0], operands[1])) + DONE; +}) + +(define_insn_and_split "*mov_mem_to_mem" + [(set (match_operand:VLS_AVL_IMM 0 "memory_operand") + (match_operand:VLS_AVL_IMM 1 "memory_operand"))] + "TARGET_VECTOR && can_create_pseudo_p ()" + "#" + "&& 1" + [(const_int 0)] + { + if (GET_MODE_BITSIZE (mode).to_constant () <= MAX_BITS_PER_WORD) + { + /* Opitmize the following case: + + typedef int8_t v2qi __attribute__ ((vector_size (2))); + v2qi v = *(v2qi*)in; + *(v2qi*)out = v; + + We prefer scalar load/store instead of vle.v/vse.v when + the VLS modes size is smaller scalar mode. */ + machine_mode mode; + unsigned size = GET_MODE_BITSIZE (mode).to_constant (); + if (FLOAT_MODE_P (mode)) + mode = mode_for_size (size, MODE_FLOAT, 0).require (); + else + mode = mode_for_size (size, MODE_INT, 0).require (); + emit_move_insn (gen_lowpart (mode, operands[0]), + gen_lowpart (mode, operands[1])); + } + else + { + operands[1] = force_reg (mode, operands[1]); + emit_move_insn (operands[0], operands[1]); + } + DONE; + } + [(set_attr "type" "vmov")] +) + +(define_insn_and_split "*mov" + [(set (match_operand:VLS_AVL_IMM 0 "reg_or_mem_operand" "=vr, m, vr") + (match_operand:VLS_AVL_IMM 1 "reg_or_mem_operand" " m,vr, vr"))] + "TARGET_VECTOR + && (register_operand (operands[0], mode) + || register_operand (operands[1], mode))" + "@ + # + # + vmv%m1r.v\t%0,%1" + "&& reload_completed + && (!register_operand (operands[0], mode) + || !register_operand (operands[1], mode))" + [(const_int 0)] + { + bool ok_p = riscv_vector::legitimize_move (operands[0], operands[1]); + gcc_assert (ok_p); + DONE; + } + [(set_attr "type" "vmov")] +) + +(define_expand "mov" + [(set (match_operand:VLS_AVL_REG 0 "reg_or_mem_operand") + (match_operand:VLS_AVL_REG 1 "general_operand"))] + "TARGET_VECTOR" +{ + bool ok_p = riscv_vector::legitimize_move (operands[0], operands[1]); + gcc_assert (ok_p); + DONE; +}) + +(define_expand "@mov_lra" + [(parallel + [(set (match_operand:VLS_AVL_REG 0 "reg_or_mem_operand") + (match_operand:VLS_AVL_REG 1 "reg_or_mem_operand")) + (clobber (match_scratch:P 2))])] + "TARGET_VECTOR && (lra_in_progress || reload_completed)" +{}) + +(define_insn_and_split "*mov_lra" + [(set (match_operand:VLS_AVL_REG 0 "reg_or_mem_operand" "=vr, m,vr") + (match_operand:VLS_AVL_REG 1 "reg_or_mem_operand" " m,vr,vr")) + (clobber (match_scratch:P 2 "=&r,&r,X"))] + "TARGET_VECTOR && (lra_in_progress || reload_completed) + && (register_operand (operands[0], mode) + || register_operand (operands[1], mode))" + "#" + "&& reload_completed" + [(const_int 0)] +{ + if (REG_P (operands[0]) && REG_P (operands[1])) + emit_insn (gen_rtx_SET (operands[0], operands[1])); + else + { + emit_move_insn (operands[2], gen_int_mode (GET_MODE_NUNITS (mode), + Pmode)); + unsigned insn_flags + = GET_MODE_CLASS (mode) == MODE_VECTOR_BOOL + ? riscv_vector::UNARY_MASK_OP + : riscv_vector::UNARY_OP; + riscv_vector::emit_nonvlmax_insn (code_for_pred_mov (mode), + insn_flags, operands, operands[2]); + } + DONE; +} + [(set_attr "type" "vmov")] +) + +(define_insn "*mov_vls" + [(set (match_operand:VLS 0 "register_operand" "=vr") + (match_operand:VLS 1 "register_operand" " vr"))] + "TARGET_VECTOR" + "vmv%m1r.v\t%0,%1" + [(set_attr "type" "vmov") + (set_attr "mode" "")]) + +(define_insn "*mov_vls" + [(set (match_operand:VLSB 0 "register_operand" "=vr") + (match_operand:VLSB 1 "register_operand" " vr"))] + "TARGET_VECTOR" + "vmv1r.v\t%0,%1" + [(set_attr "type" "vmov") + (set_attr "mode" "")]) + +(define_expand "movmisalign" + [(set (match_operand:VLS 0 "nonimmediate_operand") + (match_operand:VLS 1 "general_operand"))] + "TARGET_VECTOR" + { + /* To support misalign data movement, we should use + minimum element alignment load/store. */ + unsigned int size = GET_MODE_SIZE (GET_MODE_INNER (mode)); + poly_int64 nunits = GET_MODE_NUNITS (mode) * size; + machine_mode mode = riscv_vector::get_vector_mode (QImode, nunits).require (); + operands[0] = gen_lowpart (mode, operands[0]); + operands[1] = gen_lowpart (mode, operands[1]); + if (MEM_P (operands[0]) && !register_operand (operands[1], mode)) + operands[1] = force_reg (mode, operands[1]); + riscv_vector::emit_vlmax_insn (code_for_pred_mov (mode), riscv_vector::UNARY_OP, operands); + DONE; + } +) + ;; ----------------------------------------------------------------- ;; ---- Duplicate Operations ;; ----------------------------------------------------------------- @@ -1230,6 +1383,22 @@ } ) +(define_insn_and_split "@vec_duplicate" + [(set (match_operand:VLS 0 "register_operand") + (vec_duplicate:VLS + (match_operand: 1 "reg_or_int_operand")))] + "TARGET_VECTOR && can_create_pseudo_p ()" + "#" + "&& 1" + [(const_int 0)] + { + riscv_vector::emit_vlmax_insn (code_for_pred_broadcast (mode), + riscv_vector::UNARY_OP, operands); + DONE; + } + [(set_attr "type" "vector")] +) + ;; ----------------------------------------------------------------- ;; ---- 6. Configuration-Setting Instructions ;; ----------------------------------------------------------------- @@ -8540,4 +8709,3 @@ (include "autovec.md") (include "autovec-opt.md") -(include "autovec-vls.md")