diff mbox series

[v3] RISC-V: Elimilate warning in class vcreate

Message ID 20230912062013.9221-1-xuli1@eswincomputing.com
State Unresolved
Headers
Series [v3] RISC-V: Elimilate warning in class vcreate |

Checks

Context Check Description
snail/gcc-patch-check warning Git am fail log

Commit Message

Li Xu Sept. 12, 2023, 6:20 a.m. UTC 
  From: xuli <xuli1@eswincomputing.com>

The following is the content of class vcreate:
class vcreate : public function_base
{
public:
  gimple *fold (gimple_folder &f) const override
  {
    ....
  }

  rtx expand (function_expander &e) const override
  {
    return NULL_RTX;
  }
};

The warning caused is:
./riscv-gcc/gcc/config/riscv/riscv-vector-builtins-bases.cc:1719:34:
  warning: unused parameter 'e' [-Wunused-parameter]
  rtx expand (function_expander &e) const override
                                 ^

gcc/ChangeLog:

        * config/riscv/riscv-vector-builtins-bases.cc: remove unused parameter e and replace NULL_RTX with gcc_unreachable.
---
 gcc/config/riscv/riscv-vector-builtins-bases.cc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Li Xu Sept. 12, 2023, 6:54 a.m. UTC | #1 
Committed, thanks juzhe.
--------------
Li Xu
>lgtm
>---- Replied Message ----
>FromLi Xu<xuli1@eswincomputing.com>
>Date09/12/2023 14:20
>Togcc-patches@gcc.gnu.org<gcc-patches@gcc.gnu.org>
>Cckito.cheng@gmail.com<kito.cheng@gmail.com>,
>palmer@dabbelt.com<palmer@dabbelt.com>,
>juzhe.zhong@rivai.ai<juzhe.zhong@rivai.ai>,
>xuli<xuli1@eswincomputing.com>
>Subject[PATCH v3] RISC-V: Elimilate warning in class vcreate
diff mbox series

Patch

diff --git a/gcc/config/riscv/riscv-vector-builtins-bases.cc b/gcc/config/riscv/riscv-vector-builtins-bases.cc
index be3df2c1ea2..ee218a03017 100644
--- a/gcc/config/riscv/riscv-vector-builtins-bases.cc
+++ b/gcc/config/riscv/riscv-vector-builtins-bases.cc
@@ -1856,9 +1856,9 @@  public:
     return clobber;
   }
 
-  rtx expand (function_expander &e) const override
+  rtx expand (function_expander &) const override
   {
-    return NULL_RTX;
+    gcc_unreachable ();
   }
 };