LoongArch: Enable -fsched-pressure by default at -O1 and higher.

Message ID 20230908020021.3174-1-guojie@loongson.cn
State Unresolved
Headers
Series LoongArch: Enable -fsched-pressure by default at -O1 and higher. |

Checks

Context Check Description
snail/gcc-patch-check warning Git am fail log

Commit Message

Guo Jie Sept. 8, 2023, 2 a.m. UTC
  gcc/ChangeLog:

	* common/config/loongarch/loongarch-common.cc:
	(default_options loongarch_option_optimization_table):
	Default to -fsched-pressure.

---
 gcc/common/config/loongarch/loongarch-common.cc | 1 +
 1 file changed, 1 insertion(+)
  

Comments

Xi Ruoyao Sept. 8, 2023, 8:06 a.m. UTC | #1
On Fri, 2023-09-08 at 10:00 +0800, Guo Jie wrote:
> gcc/ChangeLog:
> 
>         * common/config/loongarch/loongarch-common.cc:

"common/" should be removed.  You can use "git gcc-verify" to figure out
this kind of error before sending a patch in the future.

>         (default_options loongarch_option_optimization_table):
>         Default to -fsched-pressure.

"Default to -fsched-pressure at -O1 or above."

Otherwise OK.

> ---
>  gcc/common/config/loongarch/loongarch-common.cc | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/gcc/common/config/loongarch/loongarch-common.cc
> b/gcc/common/config/loongarch/loongarch-common.cc
> index c5ed37d27a6..b6901910b70 100644
> --- a/gcc/common/config/loongarch/loongarch-common.cc
> +++ b/gcc/common/config/loongarch/loongarch-common.cc
> @@ -36,6 +36,7 @@ static const struct default_options
> loongarch_option_optimization_table[] =
>    { OPT_LEVELS_ALL, OPT_fasynchronous_unwind_tables, NULL, 1 },
>    { OPT_LEVELS_1_PLUS, OPT_fsection_anchors, NULL, 1 },
>    { OPT_LEVELS_2_PLUS, OPT_free, NULL, 1 },
> +  { OPT_LEVELS_1_PLUS, OPT_fsched_pressure, NULL, 1 },
>    { OPT_LEVELS_NONE, 0, NULL, 0 }
>  };
>
  
Guo Jie Sept. 8, 2023, 8:29 a.m. UTC | #2
Hi,

What I wanna change is "gcc/common/config/loongarch/loongarch-common.cc",

and the patch is automatically generated by "git gcc-commit-mklog".

Is it necessary to  to remove "common/" ?

Thanks for the review.


在 2023/9/8 下午4:06, Xi Ruoyao 写道:
> On Fri, 2023-09-08 at 10:00 +0800, Guo Jie wrote:
>> gcc/ChangeLog:
>>
>>          * common/config/loongarch/loongarch-common.cc:
> "common/" should be removed.  You can use "git gcc-verify" to figure out
> this kind of error before sending a patch in the future.
>
>>          (default_options loongarch_option_optimization_table):
>>          Default to -fsched-pressure.
> "Default to -fsched-pressure at -O1 or above."
>
> Otherwise OK.
>
>> ---
>>   gcc/common/config/loongarch/loongarch-common.cc | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/gcc/common/config/loongarch/loongarch-common.cc
>> b/gcc/common/config/loongarch/loongarch-common.cc
>> index c5ed37d27a6..b6901910b70 100644
>> --- a/gcc/common/config/loongarch/loongarch-common.cc
>> +++ b/gcc/common/config/loongarch/loongarch-common.cc
>> @@ -36,6 +36,7 @@ static const struct default_options
>> loongarch_option_optimization_table[] =
>>     { OPT_LEVELS_ALL, OPT_fasynchronous_unwind_tables, NULL, 1 },
>>     { OPT_LEVELS_1_PLUS, OPT_fsection_anchors, NULL, 1 },
>>     { OPT_LEVELS_2_PLUS, OPT_free, NULL, 1 },
>> +  { OPT_LEVELS_1_PLUS, OPT_fsched_pressure, NULL, 1 },
>>     { OPT_LEVELS_NONE, 0, NULL, 0 }
>>   };
>>
  
Xi Ruoyao Sept. 8, 2023, 8:32 a.m. UTC | #3
On Fri, 2023-09-08 at 16:29 +0800, Guo Jie wrote:
> Hi,
> 
> What I wanna change is "gcc/common/config/loongarch/loongarch-
> common.cc",
> 
> and the patch is automatically generated by "git gcc-commit-mklog".
> 
> Is it necessary to  to remove "common/" ?

My bad.  I didn't realized the file has been moved to common.

Don't change it :(.

> Thanks for the review.
> 
> 
> 在 2023/9/8 下午4:06, Xi Ruoyao 写道:
> > On Fri, 2023-09-08 at 10:00 +0800, Guo Jie wrote:
> > > gcc/ChangeLog:
> > > 
> > >          * common/config/loongarch/loongarch-common.cc:
> > "common/" should be removed.  You can use "git gcc-verify" to figure
> > out
> > this kind of error before sending a patch in the future.
> > 
> > >          (default_options loongarch_option_optimization_table):
> > >          Default to -fsched-pressure.
> > "Default to -fsched-pressure at -O1 or above."
> > 
> > Otherwise OK.
> > 
> > > ---
> > >   gcc/common/config/loongarch/loongarch-common.cc | 1 +
> > >   1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/gcc/common/config/loongarch/loongarch-common.cc
> > > b/gcc/common/config/loongarch/loongarch-common.cc
> > > index c5ed37d27a6..b6901910b70 100644
> > > --- a/gcc/common/config/loongarch/loongarch-common.cc
> > > +++ b/gcc/common/config/loongarch/loongarch-common.cc
> > > @@ -36,6 +36,7 @@ static const struct default_options
> > > loongarch_option_optimization_table[] =
> > >     { OPT_LEVELS_ALL, OPT_fasynchronous_unwind_tables, NULL, 1 },
> > >     { OPT_LEVELS_1_PLUS, OPT_fsection_anchors, NULL, 1 },
> > >     { OPT_LEVELS_2_PLUS, OPT_free, NULL, 1 },
> > > +  { OPT_LEVELS_1_PLUS, OPT_fsched_pressure, NULL, 1 },
> > >     { OPT_LEVELS_NONE, 0, NULL, 0 }
> > >   };
> > >   
>
  
chenglulu Sept. 8, 2023, 9:54 a.m. UTC | #4
Pushed to r14-3805.

在 2023/9/8 下午4:32, Xi Ruoyao 写道:
> On Fri, 2023-09-08 at 16:29 +0800, Guo Jie wrote:
>> Hi,
>>
>> What I wanna change is "gcc/common/config/loongarch/loongarch-
>> common.cc",
>>
>> and the patch is automatically generated by "git gcc-commit-mklog".
>>
>> Is it necessary to  to remove "common/" ?
> My bad.  I didn't realized the file has been moved to common.
>
> Don't change it :(.
>
>> Thanks for the review.
>>
>>
>> 在 2023/9/8 下午4:06, Xi Ruoyao 写道:
>>> On Fri, 2023-09-08 at 10:00 +0800, Guo Jie wrote:
>>>> gcc/ChangeLog:
>>>>
>>>>           * common/config/loongarch/loongarch-common.cc:
>>> "common/" should be removed.  You can use "git gcc-verify" to figure
>>> out
>>> this kind of error before sending a patch in the future.
>>>
>>>>           (default_options loongarch_option_optimization_table):
>>>>           Default to -fsched-pressure.
>>> "Default to -fsched-pressure at -O1 or above."
>>>
>>> Otherwise OK.
>>>
>>>> ---
>>>>    gcc/common/config/loongarch/loongarch-common.cc | 1 +
>>>>    1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/gcc/common/config/loongarch/loongarch-common.cc
>>>> b/gcc/common/config/loongarch/loongarch-common.cc
>>>> index c5ed37d27a6..b6901910b70 100644
>>>> --- a/gcc/common/config/loongarch/loongarch-common.cc
>>>> +++ b/gcc/common/config/loongarch/loongarch-common.cc
>>>> @@ -36,6 +36,7 @@ static const struct default_options
>>>> loongarch_option_optimization_table[] =
>>>>      { OPT_LEVELS_ALL, OPT_fasynchronous_unwind_tables, NULL, 1 },
>>>>      { OPT_LEVELS_1_PLUS, OPT_fsection_anchors, NULL, 1 },
>>>>      { OPT_LEVELS_2_PLUS, OPT_free, NULL, 1 },
>>>> +  { OPT_LEVELS_1_PLUS, OPT_fsched_pressure, NULL, 1 },
>>>>      { OPT_LEVELS_NONE, 0, NULL, 0 }
>>>>    };
>>>>
  

Patch

diff --git a/gcc/common/config/loongarch/loongarch-common.cc b/gcc/common/config/loongarch/loongarch-common.cc
index c5ed37d27a6..b6901910b70 100644
--- a/gcc/common/config/loongarch/loongarch-common.cc
+++ b/gcc/common/config/loongarch/loongarch-common.cc
@@ -36,6 +36,7 @@  static const struct default_options loongarch_option_optimization_table[] =
   { OPT_LEVELS_ALL, OPT_fasynchronous_unwind_tables, NULL, 1 },
   { OPT_LEVELS_1_PLUS, OPT_fsection_anchors, NULL, 1 },
   { OPT_LEVELS_2_PLUS, OPT_free, NULL, 1 },
+  { OPT_LEVELS_1_PLUS, OPT_fsched_pressure, NULL, 1 },
   { OPT_LEVELS_NONE, 0, NULL, 0 }
 };