From patchwork Thu Aug 24 14:39:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Malcolm X-Patchwork-Id: 136839 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a7d1:0:b0:3f2:4152:657d with SMTP id p17csp1169566vqm; Thu, 24 Aug 2023 07:44:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE1sCh/kj2JKk/MuvXUm04ZlS13G4HEd8rxj3GBwtM4KoQbKuC5UwMh0H75Ch9qYvUphG1I X-Received: by 2002:aa7:cd8f:0:b0:523:1053:9b50 with SMTP id x15-20020aa7cd8f000000b0052310539b50mr13410515edv.20.1692888283969; Thu, 24 Aug 2023 07:44:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692888283; cv=none; d=google.com; s=arc-20160816; b=cnaqtlbvJ2iH1HgsW67sBKVJWhFLhdB8i3mH74MSUSK/9SkJ2RhCfiPlAT8UAo/+DC nPlD7xaq0jJfHyIMnNj1B1CyYSXwbzt99w66HrynYzBaVUJw2F080MEmdk6oQ8I1/ZLt vntuUCcH5LzAkPXhcXpcXf1MqNXgTzofmp5rZ3UI5Z8vll/06NG2yqNSDdhVlaTiVDNP 0exq9UhMZdumohI/A/Y2KOIcMy/E7mUIk8y2mSKMEs0DtdE71lAhacHlWFtRH7CsWUpf yesxkqkOmeqfgVw2Io+eySpjbZlTY2JJ4sXxnVzlpOc6cU5DyeOKRKRpHlGdOA8BGUz/ 4jMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=wHFTTs838t7IBbRa+a5a3pDkWvMdxlNsiLF0sv3PzaY=; fh=fa0YJSH7y4k0snNuxsKgOI6vGP7j2f0jR9F1WHC95UA=; b=rEL8KjBj72rb5XQLXoZ+UadE9+T3akXae9l/tXi5YtfAoX+nAQnV/Ao+xYf1wc1fcA //ttvYbnHW27KOD5Kv0cV2z3LRdOz4q46dqzA1m1z7deqUIOhO07fOIJ7uu1sVVV2muo L9iFXVdYClOa5sUBWXZZ30HYVg1dU/W02388qSm+TLF1pw0bb0xeX7BxZ4BYd1fXW4sm boDafQitEHj0X8fQCcEE+LJ2sjICMpL2KjmH3U3mch3suGQMiofrDEGiTYlTHrTXu/Lw pVt1lFAEiY00vAUxgjUcGtqNMuq+APQjKnslN14qtXTm6Q5Cz0G3XJ3L0QVWpzw89Mbl uuMA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=AcAhNJny; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id f19-20020a056402069300b00525774c622asi10406003edy.347.2023.08.24.07.44.43 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Aug 2023 07:44:43 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=AcAhNJny; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7C4C33839073 for ; Thu, 24 Aug 2023 14:41:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7C4C33839073 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1692888112; bh=wHFTTs838t7IBbRa+a5a3pDkWvMdxlNsiLF0sv3PzaY=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=AcAhNJnylRnhjaEuCaw7Y0/N6uKLdNpc9jB8h+/cSYERZyEDy3XLuWCjhTsEHdgJu oJKfEtkfXotddllLHBnpKC9DWlz+JKTeFh5SyDecriafs5IMB0TbFkffHHirO79erb s0nybIH7os4dmVYAuOhNGV2dyheD4a5XmJPKj6+Y= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id B6CE53858426 for ; Thu, 24 Aug 2023 14:39:09 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B6CE53858426 Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-304-wX2hjxMHMluQ1j6HBmxYig-1; Thu, 24 Aug 2023 10:39:07 -0400 X-MC-Unique: wX2hjxMHMluQ1j6HBmxYig-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A039F2807D62 for ; Thu, 24 Aug 2023 14:39:07 +0000 (UTC) Received: from t14s.localdomain.com (unknown [10.22.32.117]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7E0C440C6F4C; Thu, 24 Aug 2023 14:39:07 +0000 (UTC) To: gcc-patches@gcc.gnu.org Cc: David Malcolm Subject: [PATCH 7/9] analyzer: handle INIT_VAL(ELEMENT_REG(STRING_REG), CONSTANT_SVAL) [PR105899] Date: Thu, 24 Aug 2023 10:39:01 -0400 Message-Id: <20230824143903.3161185-8-dmalcolm@redhat.com> In-Reply-To: <20230824143903.3161185-1-dmalcolm@redhat.com> References: <20230824143903.3161185-1-dmalcolm@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: David Malcolm via Gcc-patches From: David Malcolm Reply-To: David Malcolm Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1775122025386881299 X-GMAIL-MSGID: 1775122025386881299 gcc/analyzer/ChangeLog: PR analyzer/105899 * region-model-manager.cc (region_model_manager::get_or_create_initial_value): Simplify INIT_VAL(ELEMENT_REG(STRING_REG), CONSTANT_SVAL) to CONSTANT_SVAL(STRING[N]). --- gcc/analyzer/region-model-manager.cc | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/gcc/analyzer/region-model-manager.cc b/gcc/analyzer/region-model-manager.cc index 65b719056c84..22246876f8f9 100644 --- a/gcc/analyzer/region-model-manager.cc +++ b/gcc/analyzer/region-model-manager.cc @@ -310,6 +310,25 @@ region_model_manager::get_or_create_initial_value (const region *reg, get_or_create_initial_value (original_reg)); } + /* Simplify: + INIT_VAL(ELEMENT_REG(STRING_REG), CONSTANT_SVAL) + to: + CONSTANT_SVAL(STRING[N]). */ + if (const element_region *element_reg = reg->dyn_cast_element_region ()) + if (tree cst_idx = element_reg->get_index ()->maybe_get_constant ()) + if (const string_region *string_reg + = element_reg->get_parent_region ()->dyn_cast_string_region ()) + if (tree_fits_shwi_p (cst_idx)) + { + HOST_WIDE_INT idx = tree_to_shwi (cst_idx); + tree string_cst = string_reg->get_string_cst (); + if (idx >= 0 && idx <= TREE_STRING_LENGTH (string_cst)) + { + int ch = TREE_STRING_POINTER (string_cst)[idx]; + return get_or_create_int_cst (reg->get_type (), ch); + } + } + /* INIT_VAL (*UNKNOWN_PTR) -> UNKNOWN_VAL. */ if (reg->symbolic_for_unknown_ptr_p ()) return get_or_create_unknown_svalue (reg->get_type ());