From patchwork Thu Aug 24 14:38:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Malcolm X-Patchwork-Id: 136837 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a7d1:0:b0:3f2:4152:657d with SMTP id p17csp1168846vqm; Thu, 24 Aug 2023 07:43:30 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGrKpckmt+ZfQetMQmMbVZNyuics3kuC6IArB47adRRbcwB7Ke889kdDAgy3D+BwZ+n3eMr X-Received: by 2002:a17:906:3287:b0:992:a836:a194 with SMTP id 7-20020a170906328700b00992a836a194mr11602435ejw.59.1692888209733; Thu, 24 Aug 2023 07:43:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692888209; cv=none; d=google.com; s=arc-20160816; b=nN3to8FH8z76ylXUO7JQyDkn53H89VuXr110dg7LJm37Ge99vcyevcOFSH6b2VcPqu yvekjiMMADrx93m+5vz4L9XeQjP6oEK3Sf5iltpkglFZ8tK4AkefRlceD/Dm++E7YeiI 6HKZVm4zZlmH4fie72nxy+6hQbmNuiDXfDECRvz3y+mTHAwqo66nB1aLHlUe7qSc11eS P/tAY13DAB25eJKnDoemOOqfixI8OoNwOHDFZl8V6R/oUSYFwL0q7+Fy1JRvMQGaTrbw 96f+qfQkE3e5PA8BJ2Q+uzZgHm2AF5MWSI5wAHRGzOFYMsp4eHmPcV3J7YMjHIAgYmBX yZBg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=Z4E2knWIGXsB7WSi2FY93w6+ERrhewuZo5XJNbbKtq0=; fh=fa0YJSH7y4k0snNuxsKgOI6vGP7j2f0jR9F1WHC95UA=; b=MqzXS96GgBm9HjpCNCc66oTxoFVrHSsWg1cE7u3NjUfVVPYYshDltayosBGDrKbpKK CX4QhA1x78HCpuZHUhNddNhy2Ce/B+sH29IiF/zoYJyiJG4iuF+BUr8DAAb+mkxNJBJe FrlsopzmGE7+LLu+FIMxGbLuix/dluCv2MEUVTzLYqwiIhPeWj2MFnS99QF2pyMcGovh INCkEaBGIb5DeLj9bSKGwCv6poV4Zs/9hD06TAUQWvP9fwVwleYhA8kG3k4knczGLotG QF0sLJaoFv5VumxxMJuiOsQoJvAZx8ewP4k7Zuq7l5Zk8OL/IdNr3kCjYWt2A9URMyRh gLHA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=TMbXgzEQ; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id q20-20020a170906941400b009a1e73f2b52si2278452ejx.717.2023.08.24.07.43.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Aug 2023 07:43:29 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=TMbXgzEQ; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 249983882042 for ; Thu, 24 Aug 2023 14:40:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 249983882042 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1692888057; bh=Z4E2knWIGXsB7WSi2FY93w6+ERrhewuZo5XJNbbKtq0=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=TMbXgzEQIHeNUsQhJSRNPSjeBaGjrTetnK3sJgNXcjMhM/wz5RIyf2Gm+9Nh+9eb4 oMDnAlhzoBMrTAeLBSBjv3cp88BI913UPfteANUfc2jWgeVQI/TakWeSJZBiH4KAJj rBOEWVx9TAZUOqw0rLIbTMlUFViGb/Vc+OaS51CQ= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 307503858401 for ; Thu, 24 Aug 2023 14:39:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 307503858401 Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-107-6LAL6cVmNGuCC0Pyc1Fa_w-1; Thu, 24 Aug 2023 10:39:06 -0400 X-MC-Unique: 6LAL6cVmNGuCC0Pyc1Fa_w-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3F8C73C14AA9 for ; Thu, 24 Aug 2023 14:39:06 +0000 (UTC) Received: from t14s.localdomain.com (unknown [10.22.32.117]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1B0FC40D283A; Thu, 24 Aug 2023 14:39:06 +0000 (UTC) To: gcc-patches@gcc.gnu.org Cc: David Malcolm Subject: [PATCH 2/9] analyzer: handle symbolic bindings in scan_for_null_terminator [PR105899] Date: Thu, 24 Aug 2023 10:38:56 -0400 Message-Id: <20230824143903.3161185-3-dmalcolm@redhat.com> In-Reply-To: <20230824143903.3161185-1-dmalcolm@redhat.com> References: <20230824143903.3161185-1-dmalcolm@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: David Malcolm via Gcc-patches From: David Malcolm Reply-To: David Malcolm Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1775121947105427128 X-GMAIL-MSGID: 1775121947105427128 gcc/analyzer/ChangeLog: PR analyzer/105899 * region-model.cc (iterable_cluster::iterable_cluster): Add symbolic binding keys to m_symbolic_bindings. (iterable_cluster::has_symbolic_bindings_p): New. (iterable_cluster::m_symbolic_bindings): New field. (region_model::scan_for_null_terminator): Treat clusters with symbolic bindings as having unknown strlen. gcc/testsuite/ChangeLog: PR analyzer/105899 * gcc.dg/analyzer/sprintf-1.c: Include "analyzer-decls.h". (test_strlen_1): New. --- gcc/analyzer/region-model.cc | 15 +++++++++++++++ gcc/testsuite/gcc.dg/analyzer/sprintf-1.c | 11 +++++++++++ 2 files changed, 26 insertions(+) diff --git a/gcc/analyzer/region-model.cc b/gcc/analyzer/region-model.cc index 99817aee3a93..7a2f81f36e0f 100644 --- a/gcc/analyzer/region-model.cc +++ b/gcc/analyzer/region-model.cc @@ -3420,6 +3420,8 @@ public: if (concrete_key->get_byte_range (&fragment_bytes)) m_fragments.safe_push (fragment (fragment_bytes, sval)); } + else + m_symbolic_bindings.safe_push (key); } m_fragments.qsort (fragment::cmp_ptrs); } @@ -3440,8 +3442,14 @@ public: return false; } + bool has_symbolic_bindings_p () const + { + return !m_symbolic_bindings.is_empty (); + } + private: auto_vec m_fragments; + auto_vec m_symbolic_bindings; }; /* Simulate reading the bytes at BYTES from BASE_REG. @@ -3610,6 +3618,13 @@ region_model::scan_for_null_terminator (const region *reg, /* No binding for this base_region, or no binding at src_byte_offset (or a symbolic binding). */ + if (c.has_symbolic_bindings_p ()) + { + if (out_sval) + *out_sval = m_mgr->get_or_create_unknown_svalue (NULL_TREE); + return m_mgr->get_or_create_unknown_svalue (size_type_node); + } + /* TODO: the various special-cases seen in region_model::get_store_value. */ diff --git a/gcc/testsuite/gcc.dg/analyzer/sprintf-1.c b/gcc/testsuite/gcc.dg/analyzer/sprintf-1.c index f8dc806d6192..e7c2b3089c5b 100644 --- a/gcc/testsuite/gcc.dg/analyzer/sprintf-1.c +++ b/gcc/testsuite/gcc.dg/analyzer/sprintf-1.c @@ -1,6 +1,8 @@ /* See e.g. https://en.cppreference.com/w/c/io/fprintf and https://www.man7.org/linux/man-pages/man3/sprintf.3.html */ +#include "analyzer-decls.h" + extern int sprintf(char* dst, const char* fmt, ...) __attribute__((__nothrow__)); @@ -64,3 +66,12 @@ test_fmt_not_terminated (char *dst) return sprintf (dst, fmt); /* { dg-warning "stack-based buffer over-read" } */ /* { dg-message "while looking for null terminator for argument 2 \\('&fmt'\\) of 'sprintf'..." "event" { target *-*-* } .-1 } */ } + +void +test_strlen_1 (void) +{ + char buf[10]; + sprintf (buf, "msg: %s\n", "abc"); + __analyzer_eval (__builtin_strlen (buf) == 8); /* { dg-warning "UNKNOWN" } */ + // TODO: ideally would be TRUE +}