From patchwork Thu Aug 24 09:02:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hongyu Wang X-Patchwork-Id: 136776 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a7d1:0:b0:3f2:4152:657d with SMTP id p17csp985926vqm; Thu, 24 Aug 2023 02:05:31 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHUtjVGCynOonW10l/h70ot7oEhHRvNM4zrm5wwNJyNp575iVKH3YbeDznCrrxyqjhJPLzV X-Received: by 2002:a17:907:2cd3:b0:9a2:1c88:b94 with SMTP id hg19-20020a1709072cd300b009a21c880b94mr606393ejc.65.1692867931379; Thu, 24 Aug 2023 02:05:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692867931; cv=none; d=google.com; s=arc-20160816; b=wFRYpnfLrdPbXdXsxNIzt/TF3fjJDpLvvcr3GfTa/0CDnhH0w6s9lXbQ23pQM0PNb3 TAq6N8Y3Eo+y2Z5+1Jd5gjhu8HEKitgGtofq14oGWa8uLtiGin+s6JHtJwnDhXvkSFuj 4HzeMg0CIcOncECqxTyGyGExiMFTFY8ntCEPPWRGa+Wpt9N+hWnezp1wFmHCR5hOeaz4 IJEeCrReXCtU36qmhTS6RzmqMZLwVZx/dooinuG+JXNWCiSUm8+koBwBbBVOadJTLdpj WjICQFHkIvKfCHzVZzVNuT7HkQp1jt9iIbl+Pwa2aYxxLhE6jNmo2GPmsl5Fxl499Ibm VdQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:message-id:date:subject:cc :to:dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=6E1FsoUDChoADGfC0cSSYAUWZ2lQkskpJw/qE0nBpAA=; fh=fS69CmxDqhXRDnrz/eIrlE8G86Mq37b9o+7hIe0xZ2k=; b=OrUs3y/B5Qxn9GQMtfPaqRAuNcYY9onLWzEm5xsJrRLbA7dKMeUioI2oHHyEwHIG1b X3MCZl8j6zerVLlb44Zqe6zYwQBpVki5WncFYDo70R/asFXiAZfsOIqjE3adV47EN/Nm RqGsK7QyybMtw7XXUOtTzd5BdkeQoMFhZOb+h5Ss9d6lqGY7LM0eUW8xSaTFI3nOZD3h XNQuXWw7Hv8qMMn7DzRyX0IPH1J0Ayus4OjTDp3rRxKwupX4c3202KLDV3krma2pw169 egSyPzL1vCPWAxu4LJN4vRQilamvSpBF89h04JJb/hZ4X6CaZH5LZNp3Sy8VHnD13w/4 BBKw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=qgbZUs+M; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id e20-20020a1709061e9400b009a1b54e52d2si4038584ejj.952.2023.08.24.02.05.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Aug 2023 02:05:31 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=qgbZUs+M; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 12BA33853D34 for ; Thu, 24 Aug 2023 09:05:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 12BA33853D34 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1692867930; bh=6E1FsoUDChoADGfC0cSSYAUWZ2lQkskpJw/qE0nBpAA=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=qgbZUs+MJSMd0HFIa1xLBq8sRVgxU+PMlnYnYVWTxVoDwrYvLjnVlmZ3D3fqBhB5v zZo7aY2+nW41YSiDAZcPO3OEG+M3LYdGcCPK9DXRMjlCYu1mlrCbzLXmTM9GiI8p/H N7Y15ls3ws3+5ozbSc5ZAbSlRtxMtwqgzmirkimg= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by sourceware.org (Postfix) with ESMTPS id 9C751385DC04 for ; Thu, 24 Aug 2023 09:04:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 9C751385DC04 X-IronPort-AV: E=McAfee;i="6600,9927,10811"; a="378141088" X-IronPort-AV: E=Sophos;i="6.01,195,1684825200"; d="scan'208";a="378141088" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Aug 2023 02:04:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10811"; a="860630202" X-IronPort-AV: E=Sophos;i="6.01,195,1684825200"; d="scan'208";a="860630202" Received: from shvmail03.sh.intel.com ([10.239.245.20]) by orsmga004.jf.intel.com with ESMTP; 24 Aug 2023 02:04:43 -0700 Received: from shliclel4217.sh.intel.com (shliclel4217.sh.intel.com [10.239.240.127]) by shvmail03.sh.intel.com (Postfix) with ESMTP id 123AF1007814; Thu, 24 Aug 2023 17:04:43 +0800 (CST) To: gcc-patches@gcc.gnu.org Cc: hongtao.liu@intel.com Subject: [PATCH] Fix avx512ne2ps2bf16 wrong code [PR 111127] Date: Thu, 24 Aug 2023 17:02:42 +0800 Message-Id: <20230824090242.2997731-1-hongyu.wang@intel.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-Spam-Status: No, score=-10.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_SHORT, SPF_HELO_NONE, SPF_SOFTFAIL, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Hongyu Wang via Gcc-patches From: Hongyu Wang Reply-To: Hongyu Wang Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1775100683764469538 X-GMAIL-MSGID: 1775100683764469538 Hi, For PR111127, the wrong code was caused by wrong expander for maskz. correct the parameter order for avx512ne2ps2bf16_maskz expander Bootstrapped/regtested on x86-64-pc-linux-gnu{m32,}. OK for master and backport to GCC13? gcc/ChangeLog: PR target/111127 * config/i386/sse.md (avx512f_cvtne2ps2bf16__maskz): Adjust paramter order. gcc/testsuite/ChangeLog: PR target/111127 * gcc.target/i386/pr111127.c: New test. --- gcc/config/i386/sse.md | 4 ++-- gcc/testsuite/gcc.target/i386/pr111127.c | 24 ++++++++++++++++++++++++ 2 files changed, 26 insertions(+), 2 deletions(-) create mode 100644 gcc/testsuite/gcc.target/i386/pr111127.c diff --git a/gcc/config/i386/sse.md b/gcc/config/i386/sse.md index da85223a9b4..194dab9a9d0 100644 --- a/gcc/config/i386/sse.md +++ b/gcc/config/i386/sse.md @@ -30006,8 +30006,8 @@ (define_expand "avx512f_cvtne2ps2bf16__maskz" (match_operand: 3 "register_operand")] "TARGET_AVX512BF16" { - emit_insn (gen_avx512f_cvtne2ps2bf16__mask(operands[0], operands[2], - operands[1], CONST0_RTX(mode), operands[3])); + emit_insn (gen_avx512f_cvtne2ps2bf16__mask(operands[0], operands[1], + operands[2], CONST0_RTX(mode), operands[3])); DONE; }) diff --git a/gcc/testsuite/gcc.target/i386/pr111127.c b/gcc/testsuite/gcc.target/i386/pr111127.c new file mode 100644 index 00000000000..c124bc18bc4 --- /dev/null +++ b/gcc/testsuite/gcc.target/i386/pr111127.c @@ -0,0 +1,24 @@ +/* PR target/111127 */ +/* { dg-do compile } */ +/* { dg-options "-O2 -mavx512bf16 -mavx512vl" } */ +/* { dg-final { scan-assembler-times "vcvtne2ps2bf16\[ \\t\]+\[^\{\n\]*%zmm1, %zmm0, %zmm0\{%k\[0-9\]\}\{z\}\[^\n\r]*(?:\n|\[ \\t\]+#)" 1 } } */ +/* { dg-final { scan-assembler-times "vcvtne2ps2bf16\[ \\t\]+\[^\{\n\]*%ymm1, %ymm0, %ymm0\{%k\[0-9\]\}\{z\}\[^\n\r]*(?:\n|\[ \\t\]+#)" 1 } } */ +/* { dg-final { scan-assembler-times "vcvtne2ps2bf16\[ \\t\]+\[^\{\n\]*%xmm1, %xmm0, %xmm0\{%k\[0-9\]\}\{z\}\[^\n\r]*(?:\n|\[ \\t\]+#)" 1 } } */ + +#include + +__m512bh cvttest(__mmask32 k, __m512 a, __m512 b) +{ + return _mm512_maskz_cvtne2ps_pbh (k,a,b); +} + +__m256bh cvttest2(__mmask16 k, __m256 a, __m256 b) +{ + return _mm256_maskz_cvtne2ps_pbh (k,a,b); +} + +__m128bh cvttest3(__mmask8 k, __m128 a, __m128 b) +{ + return _mm_maskz_cvtne2ps_pbh (k,a,b); +} +