From patchwork Wed Aug 23 14:14:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Stubbs X-Patchwork-Id: 136672 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a7d1:0:b0:3f2:4152:657d with SMTP id p17csp491839vqm; Wed, 23 Aug 2023 07:18:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF1syQuTV34ohQ/TkaVLxOahgea4zuNYh7yEqqxy4udLGy8X2AEHeI+mHBXlDbnhwVZRups X-Received: by 2002:a2e:83d7:0:b0:2b6:d790:d1a3 with SMTP id s23-20020a2e83d7000000b002b6d790d1a3mr8928889ljh.11.1692800280777; Wed, 23 Aug 2023 07:18:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1692800280; cv=none; d=google.com; s=arc-20160816; b=Jf032LKX53CzM5Ai687wSKZfpNKR7LwMxwI5QZHHxvBXttHaPiFjAGXiWcAFeuC20x 8rwcCrAemLrs6KIf0dYa92vl4myxCnPA23aknl2uyEoIIJF++H7HgiP8tKWAMKVwf8up 87szFmJyPPLdkxsv3tc83WkstjAwbOHJFGQdg5EJMBm3hdbdkgSYIO5BXNj+QjNra9s7 WfZGHDAYg/ba3JfJamARqml7Ozbd9h0wUOr/AbAhaS2mYoU8o8ltDu30i/GcWKPoHWeI y8qG7FMhpOk9erjMdVuh01RVXPRpvzoC6rbgosYHbVFud0/AtdvcaBV7i30H53FWgs/X 5RuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:date:subject:to:from :ironport-sdr:dmarc-filter:delivered-to; bh=vR5PO0atlIDY72+ltuDNYWd9ocjGYYX5adNu1dG5Cc8=; fh=9xD62naDDQ44CEuxrRV0ts5PrjZies6B3X/DCYdxTRw=; b=FFPNvwYV5CJeomA6TGnmE92yWrywchC9hGhv1WJe5waY7WO9Bj6VnQgfRa/yHNEUFg 1k+EAYzw0NhVBRvYq3EXL0KCAYfTpdpv5zrNvvK4SUZsQb66kKhJdJHuuBR4nZp6KE62 Gt1GDZDOmg65p6BxPG2vU9AqWGCDwH+C16BuUICoYisCOrpfqbUg1e40AAqOlZcCqs0M 3vkY37qjC2h0dpGi1MPFRd144xSoHbleoCBh8Xm00wg9f7kWvkS4v0YXfxuQ3qyL/2vt rhsQ+SZ5XRHpUXZG4PR86Ag6Cf4wvvzReCgzChcZ2YPrORrjQUNpPnlJfIafLwPq3SsP J80w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id m15-20020a1709062acf00b00992c25357a8si8987944eje.252.2023.08.23.07.18.00 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Aug 2023 07:18:00 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B721A3850877 for ; Wed, 23 Aug 2023 14:15:40 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from esa1.mentor.iphmx.com (esa1.mentor.iphmx.com [68.232.129.153]) by sourceware.org (Postfix) with ESMTPS id A6A9C385DC28 for ; Wed, 23 Aug 2023 14:14:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A6A9C385DC28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="6.01,195,1684828800"; d="scan'208";a="17132453" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa1.mentor.iphmx.com with ESMTP; 23 Aug 2023 06:14:45 -0800 IronPort-SDR: n9LR2PiiS+hHN/+N6rRAriqgP2jBuGrlByNUvaLNdgg/A9hr5xf2Jl0VEeI9UyaKwKKAdeG3zJ WvNHmz1HGtFo97Ym4XAfZYKlWvTbtyLUEQUo6oZthLKOf3CvUrbMOJsh/4c09l/tU8eYcjShCB aSloqUoRePCdCweloHiFpI0xKleI4U0rlPZw+DSK6VwOLG16WXijOUzZxmeQOmhP/DPjUNoizc bU2XZSZ5JdKZj0NKyX3rgNdifokD5PzOHb7ktdjT8+tHG6SG7Ai4TZIWF1UvV67XsXpCWx4a0U v0k= From: Andrew Stubbs To: Subject: [PATCH v2 3/6] openmp: Add -foffload-memory Date: Wed, 23 Aug 2023 15:14:23 +0100 Message-ID: <20230823141426.320160-4-ams@codesourcery.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230823141426.320160-1-ams@codesourcery.com> References: <20230823141426.320160-1-ams@codesourcery.com> MIME-Version: 1.0 X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-15.mgc.mentorg.com (139.181.222.15) To svr-ies-mbx-11.mgc.mentorg.com (139.181.222.11) X-Spam-Status: No, score=-12.0 required=5.0 tests=BAYES_00, GIT_PATCH_0, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1775029747481792281 X-GMAIL-MSGID: 1775029747481792281 Add a new option. It's inactive until I add some follow-up patches. gcc/ChangeLog: * common.opt: Add -foffload-memory and its enum values. * coretypes.h (enum offload_memory): New. * doc/invoke.texi: Document -foffload-memory. --- gcc/common.opt | 16 ++++++++++++++++ gcc/coretypes.h | 7 +++++++ gcc/doc/invoke.texi | 16 +++++++++++++++- 3 files changed, 38 insertions(+), 1 deletion(-) diff --git a/gcc/common.opt b/gcc/common.opt index 0888c15b88f..541213d285f 100644 --- a/gcc/common.opt +++ b/gcc/common.opt @@ -2243,6 +2243,22 @@ Enum(offload_abi) String(ilp32) Value(OFFLOAD_ABI_ILP32) EnumValue Enum(offload_abi) String(lp64) Value(OFFLOAD_ABI_LP64) +foffload-memory= +Common Joined RejectNegative Enum(offload_memory) Var(flag_offload_memory) Init(OFFLOAD_MEMORY_NONE) +-foffload-memory=[none|unified|pinned] Use an offload memory optimization. + +Enum +Name(offload_memory) Type(enum offload_memory) UnknownError(Unknown offload memory option %qs) + +EnumValue +Enum(offload_memory) String(none) Value(OFFLOAD_MEMORY_NONE) + +EnumValue +Enum(offload_memory) String(unified) Value(OFFLOAD_MEMORY_UNIFIED) + +EnumValue +Enum(offload_memory) String(pinned) Value(OFFLOAD_MEMORY_PINNED) + fomit-frame-pointer Common Var(flag_omit_frame_pointer) Optimization When possible do not generate stack frames. diff --git a/gcc/coretypes.h b/gcc/coretypes.h index 3e9a2f19e27..a7feed51b0b 100644 --- a/gcc/coretypes.h +++ b/gcc/coretypes.h @@ -207,6 +207,13 @@ enum offload_abi { OFFLOAD_ABI_ILP32 }; +/* Types of memory optimization for an offload device. */ +enum offload_memory { + OFFLOAD_MEMORY_NONE, + OFFLOAD_MEMORY_UNIFIED, + OFFLOAD_MEMORY_PINNED +}; + /* Types of profile update methods. */ enum profile_update { PROFILE_UPDATE_SINGLE, diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi index ef3f4098986..be780dc41d8 100644 --- a/gcc/doc/invoke.texi +++ b/gcc/doc/invoke.texi @@ -202,7 +202,7 @@ in the following sections. -fno-builtin -fno-builtin-@var{function} -fcond-mismatch -ffreestanding -fgimple -fgnu-tm -fgnu89-inline -fhosted -flax-vector-conversions -fms-extensions --foffload=@var{arg} -foffload-options=@var{arg} +-foffload=@var{arg} -foffload-options=@var{arg} -foffload-memory=@var{arg} -fopenacc -fopenacc-dim=@var{geom} -fopenmp -fopenmp-simd -fopenmp-target-simd-clone@r{[}=@var{device-type}@r{]} -fpermitted-flt-eval-methods=@var{standard} @@ -2740,6 +2740,20 @@ Typical command lines are -foffload-options=amdgcn-amdhsa=-march=gfx906 @end smallexample +@opindex foffload-memory +@cindex OpenMP offloading memory modes +@item -foffload-memory=none +@itemx -foffload-memory=unified +@itemx -foffload-memory=pinned +Enable a memory optimization mode to use with OpenMP. The default behavior, +@option{-foffload-memory=none}, is to do nothing special (unless enabled via +a requires directive in the code). @option{-foffload-memory=unified} is +equivalent to @code{#pragma omp requires unified_shared_memory}. +@option{-foffload-memory=pinned} forces all host memory to be pinned (this +mode may require the user to increase the ulimit setting for locked memory). +All translation units must select the same setting to avoid undefined +behavior. + @opindex fopenacc @cindex OpenACC accelerator programming @item -fopenacc