From patchwork Mon Aug 21 21:03:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Faust X-Patchwork-Id: 136427 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b82d:0:b0:3f2:4152:657d with SMTP id z13csp3253957vqi; Mon, 21 Aug 2023 14:05:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE2VNOIUkbBDoCGN4WQTxafxJx263HFBJS5rVpu1IX3O1UdDUBcYiZeB5wKdoS3HjceGRWM X-Received: by 2002:a05:6000:1cce:b0:317:dd94:ed38 with SMTP id bf14-20020a0560001cce00b00317dd94ed38mr5930091wrb.42.1692651909877; Mon, 21 Aug 2023 14:05:09 -0700 (PDT) Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id k26-20020a170906681a00b00993cdec0182si6555674ejr.143.2023.08.21.14.05.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Aug 2023 14:05:09 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=Zh8wPpcV; arc=fail (signature failed); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8AFED3857706 for ; Mon, 21 Aug 2023 21:05:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8AFED3857706 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1692651908; bh=pveJszHmSllgJpmSqTtFODwdglA4IGijmIeRW2fkyQc=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=Zh8wPpcVkEu90pJn9SL/65mPtocVA1f/nOJUkDxgrCzEL/otnYlxp6Y2rPioSSC9a 2nFn5/IBuZrA7dl50PzCQi5iz7C8cfO3SJSMfziZPdjbQv53okjghPI1WGoo9R4G+3 pZ5EPMHfkSj6lWksdYbzNrh82hAE4lT/rBBZ77mA= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 40F513858D33 for ; Mon, 21 Aug 2023 21:04:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 40F513858D33 Received: from pps.filterd (m0246632.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 37LFxUoa014093 for ; Mon, 21 Aug 2023 21:04:23 GMT Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3sjnbtuveg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 21 Aug 2023 21:04:23 +0000 Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 37LJsGYt030331 for ; Mon, 21 Aug 2023 21:04:15 GMT Received: from nam02-bn1-obe.outbound.protection.outlook.com (mail-bn1nam02lp2049.outbound.protection.outlook.com [104.47.51.49]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3sjm6403nf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 21 Aug 2023 21:04:15 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=cj66mP5OX7uwn/muKJpWtIXgP0ZuUnBZIMqJlZs/y/edh7n1dN+LDSYEWogl/EL6kApyiOLe9/2icRAdK/78uGT/++FeSrBPvGRXu3e1FrTtp46CuFrm+WpCRRC3wf5A1wFkpQ8NR/Y1H2vY1CijHJfKaINgKNvHDGSIWzGESOyAwW6vBUi2VnXntDiJZ1zVJn7ieT1hDVY6+tvDtbSX5CPHqoici3YeeU/hQ6IAP3YSzCZqtvupCahZZQeBmJ0+sQPcLcsf1p+05VnvEwbeb3cQcorV3TYnIemL7u2EygrtT2TEcL8AZCys4UTahbgY+sDlTMPlFZvHGzgLq8LLIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=pveJszHmSllgJpmSqTtFODwdglA4IGijmIeRW2fkyQc=; b=epstKtFt9CWYyZNsjqMXlUnmXM0IHlOkxC+xo9sGXtpTsuUAsS30u5emtTr6kGuIP0zwLt/tu7gjWJ4wTcuxmmrgq6eojgwfF8T+qSZNDHDuyB7otvZmUTXZi4nhK6T+t4hW+gZ9DtmPE2nAQ1M5B+heum8+X+qTlKOT3xqvzGpe9JR8UCLq0YKWSes1SMrHX0PlQ3TWkZIq785xvQOJuKGDDFExvef0+aCUMmXylSHbRk5lHWq9mdkyrNpDOqluSrseeeLrCRmGmLkVXAOs3ks8ynuKdCSHcCH3IQRrJiJZio9Cs4rFy5/lm7bMwWEGNKKfbx3LHUwkTxNYAZ7z2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from MN2PR10MB3213.namprd10.prod.outlook.com (2603:10b6:208:131::33) by CH2PR10MB4358.namprd10.prod.outlook.com (2603:10b6:610:a8::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6699.24; Mon, 21 Aug 2023 21:04:13 +0000 Received: from MN2PR10MB3213.namprd10.prod.outlook.com ([fe80::6269:77c6:e6b9:ac03]) by MN2PR10MB3213.namprd10.prod.outlook.com ([fe80::6269:77c6:e6b9:ac03%6]) with mapi id 15.20.6699.022; Mon, 21 Aug 2023 21:04:12 +0000 To: gcc-patches@gcc.gnu.org Cc: jose.marchesi@oracle.com Subject: [PATCH] bpf: neg instruction does not accept an immediate Date: Mon, 21 Aug 2023 14:03:47 -0700 Message-ID: <20230821210347.19947-1-david.faust@oracle.com> X-Mailer: git-send-email 2.41.0 X-ClientProxiedBy: BYAPR11CA0096.namprd11.prod.outlook.com (2603:10b6:a03:f4::37) To MN2PR10MB3213.namprd10.prod.outlook.com (2603:10b6:208:131::33) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR10MB3213:EE_|CH2PR10MB4358:EE_ X-MS-Office365-Filtering-Correlation-Id: ce658864-3549-477a-3dbb-08dba28a2bc2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WrNR3xzNlXeGgdzgiyVJooKNJByQrHqeWD5ZdbEfMfMnVCPXBZqnvE/EzAYoy8hHVlYX/WWl9gkjI5MHJeVtZ4/l4RtdlnS4ohcrbHJjxuvoyLrfKau+Mh+YHRb/CuvM2+dzRb9Jyh+rTQMdOf5oAW5df8M7qSy4B18SFOGNLaFa06X0WEKIVejJBAojVDIcU67e+MziBzMPtMu1ci5cZmW1ayHPgd3t25n6fI2K4YkPFOPz9bh/LwqNwM/TDZrfKYo/6npmiP3ggJP1TkrlyD9hpxyd507Xy+sNSPobXc7E2KyVd549eYuxkiqArclRPlNjxZpPodairEWMLm9NozncN/VjWdUEWb1m/z7vRILKvaQh4HLz4d74jE352e7Z40kix/4izaaPgR36Ddh7AngLyr4y8w9/kGmZDFTovNrLHPRX/UC919Ar8kq/weqQ0Ug0Fm62l//xapt7P+cjHh1NKjS+DSl/wAU3kZRytDk0HjqQaSgnCn2GVWcKr3VgrvGXvZG74cOL1xjOfc1hvPacN+VTzA90LKE+mRMPFx77Ikm2w+jvXqclay8YFFAfFLPzVEBe1ZzN3U08Jb5rBb66NY0ZSaYV26yB09lMfUE= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR10MB3213.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(376002)(136003)(346002)(39860400002)(366004)(186009)(1800799009)(451199024)(6916009)(66476007)(66556008)(316002)(66946007)(6512007)(8676002)(8936002)(2616005)(107886003)(4326008)(1076003)(36756003)(41300700001)(966005)(478600001)(6666004)(38100700002)(6506007)(6486002)(83380400001)(2906002)(86362001)(44832011)(5660300002)(26005)(14773001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: yyvmkOfSUlbXOwA4p/x5n+b2DnjMjdyY7AFapJ04HMRFUyiIQMfoiHynkIiIN0j8+Ug6EzRGJC55oOb2JR3CLsnauMUzmozS/157EnQvwhy+yXySASltoOgGFOD6Fx27ovz+6Z6wKRVoG5VKc0VjLskt1tnHCIVgN3ni/9iKEka1XAQLKLwukEGeINKRrkd36b3UAhGiGGKeybBZnL2yfIT4/PG7uC2eUnrdU1wxDM9NrIrD2CA2E8l0r1IBOEWwfBbCH2jSI0cFRD+iId3nAnsyGfqVGBFTsVhCtRTPpAEGuORITnSk5QtnuTCVMDwFNl5/gPz3YadV89Rk0g/ZOz5dAqJ+IKXDtNU4MBRjeqwhnWv4O/IejVWKrldfo182YeH85Xhg8ini9lV9EEu3Xw+rZrPPcV3WqPjoJMVGK5msEitDprBm9GnBd/2uCcR+5KqFfh+iuR7qbPNsoFu/F7F3O6/T3cTXexDmGbx3uTZVFWU3Ej1l8+vSJSUbt84Lau3nMf1g1tMv2MYdr5aPRO10Zsf4zcx9sTuKu1GLsoJvvQXleE++rHO8q5C/FWHong0BgATWtg+4I7ayxRiOBk/jrNc2PL1Hzhm4Xpifc647MsBn5gtsLNyfeVkwiEvc2Gbn4Ed6y8CtMEt0yj5Qq5FdABdNwgZIA5+HLOo52fcd83YoBkcyASBdPXyfN2nkT+FReukhZKsOhKbV0bNe16Ds0zHvP55+J5rHaVZUpin+0Z6oHkO70DZHGEXTmFlw11Qx7vipBOf/7vOdmSKxsdU3W2WNZsgKr5KSn5Lpqod5zPJNMqeUVoTbVm6E7di2gaPhnMe+J6hL4UDJtOnHylKbsD8DNgTvnZIv2tdLcDwE0wI+9oQA+B8dK0WJ1FXFgHJF3jcztTkX7ldh2n2X/TxxSA9HDD9xpsyL5ZbaNIQZ1S7ehkTRpuoget85fNe9qJoFWi3mzE85IItx3GiUahKoXde4MazpajWAwxgWa01EhyhlW3x50TmgFr0OQPYC6PF+ftSIR2nTtVZsjcGRz2Cz+LMrjXI/qjX+6Ejp4fnJQFGPsP29GHO0IGBtu0zFcuhYjWp1BcyMz3kVc0MUquTc7+nPJPPuFFtWIEBAKJf3loX15IEqfw0b65M3d1mHCkuv/jtH9UxJs7ngvzVYVnSNcryF8Vk89ltWa5mnjGkHW3Kt14bHFse28D2HqMM8X4G+0ZzaCpJy3gKMfSOApFFepq5sUTeRaT8M+xuogxKLfRTXIO0q60a3iMO6cHbNdxElYM+jyuMqvL86xCqdjZ9p5iFNmzCwh9gcDOv2LlcmdxNlrW0VX3W0HMi8acLOyei9tLCnNDGPaYAReKFAblIUTQ5P0nITe4CqMtTBQxMld7WpufzKC4z5OmqeOhP624lxuJsPenalW6cuI/UqLI+cYJxmgeKj6ChoabffqkQrfUuAHn6wZKnSy/1fofr9AsAths103ZJiZvxdsShY8YOq8Rs41rEmak9E7KoKBDJlUb8O0qlSo88RHWMNPduNeY7v6XK14yXYA7TuP93npeOWFuNHxWs1VeGk9oFUWBt6pu1MLscjVZh9jBqp3P/b X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: N7hq3PXDyZ5XxLJxIMhpulULgSoe7l6wzMka7g2+AGWFNWxICZo5Tf3fFiv+ZQOtE2DV+P5alRtRfHnqzxfGCMppajl8NjQszcp1Svggfy3N9uDETzxK5ZnKkmGlJd+YUzh7OcZ3hSaujQEYtM9/Rz8DQw2i7swkZjluoTBeSeug3ZUMF7tFtgwBOFE7qZRwyOAFkt1/GW/qMwfHsT9DLQliy2fLU3+WLnK3hOXL2O6zW4IlHow7Ko1vTjGstx6IvEyqLDv1DrjEp63HicwuiLX7SgV5sLxFr6WGsk4jqyqwKRsxkjuPmaw2sbgdg/hfJOX8UXJiTBet7DwxMMv6mde1O1tfO8ln9/NtwCuAyBR5w5lmE71QYmki5HKLiSvvgVZ51XcekghSRD10N1beZlfDsM0ayRx+ISMLilN1zo8E6l1rx0wZjfyRX79ba6WxieQljPw67tlmkybpbCOruCovxqNtGXMA/kZjHn4OS3/4Yla2V6bQh9Ubuo3d3Ih65BBt6uxWQyw18UJM1gR/8zWj/kDj7g/fadz6RrLtSXYUuReJ+BLAMjZZdNzqDtW1BgrOoXVhqViwvjthhfzSZhKXYBXJzYnH3tH0kGZ+6TpnYEa8iSjd5oksMGYoXYMH1D/oXmlvnHADuwLUC3zb7EM0+gz5ciiMlItEnCmZo0LnuWNrgMEBWCNpPVtsoG8UMqxbU3evKtLPoXG6aGNsmCCI07PJaDNs3YcpDrtCdSPf25G9D8s72rkv5OqZierS X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: ce658864-3549-477a-3dbb-08dba28a2bc2 X-MS-Exchange-CrossTenant-AuthSource: MN2PR10MB3213.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Aug 2023 21:04:12.8846 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JN9B5NJKC5t1b41oJuwdhYscc6A2hCgtGuBXA470asdKE6TqNDk/rCKl4Vm7PmUnm7FE+82PPLODzHUWQ4R+6g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB4358 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-08-21_10,2023-08-18_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 mlxscore=0 spamscore=0 mlxlogscore=967 malwarescore=0 bulkscore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2308210196 X-Proofpoint-GUID: uQgWqXoCdCIImpWQbpYCODwacQ_cPM-Y X-Proofpoint-ORIG-GUID: uQgWqXoCdCIImpWQbpYCODwacQ_cPM-Y X-Spam-Status: No, score=-13.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: David Faust via Gcc-patches From: David Faust Reply-To: David Faust Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1774874169078482360 X-GMAIL-MSGID: 1774874169078482360 The BPF virtual machine does not support neg nor neg32 instructions with an immediate. The erroneous instructions were removed from binutils: https://sourceware.org/pipermail/binutils/2023-August/129135.html Change the define_insn so that an immediate cannot be accepted. From testing, a neg-immediate was probably never chosen over a mov-immediate anyway. Tested on x86_64-linux-gnu host for bpf-unknown-none target. gcc/ * config/bpf/bpf.md (neg): Second operand must be a register. --- gcc/config/bpf/bpf.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gcc/config/bpf/bpf.md b/gcc/config/bpf/bpf.md index a64de1095ed..e87d72182bb 100644 --- a/gcc/config/bpf/bpf.md +++ b/gcc/config/bpf/bpf.md @@ -163,8 +163,8 @@ (define_insn "sub3" ;;; Negation (define_insn "neg2" - [(set (match_operand:AM 0 "register_operand" "=r,r") - (neg:AM (match_operand:AM 1 "reg_or_imm_operand" " 0,I")))] + [(set (match_operand:AM 0 "register_operand" "=r") + (neg:AM (match_operand:AM 1 "register_operand" " 0")))] "" "{neg\t%0|%w0 = -%w1}" [(set_attr "type" "")])