diff mbox series

[23/24] bfd: linker: merge .sframe sections

Message ID 20230807105935.2098236-24-arsen@aarsen.me
State Unresolved
Headers
Series Sync shared build infrastructure with binutils-gdb |

Checks

Context Check Description
snail/gcc-patch-check warning Git am fail log

Commit Message

Arsen Arsenović Aug. 7, 2023, 10:33 a.m. UTC 
  From: Indu Bhagat <indu.bhagat@oracle.com>

The linker merges all the input .sframe sections.  When merging, the
linker verifies that all the input .sframe sections have the same
abi/arch.

The linker uses libsframe library to perform key actions on the
.sframe sections - decode, read, and create output data.  This
implies buildsystem changes to make and install libsframe before
libbfd.

The linker places the output .sframe section in a new segment of its
own: PT_GNU_SFRAME.  A new segment is not added, however, if the
generated .sframe section is empty.

When a section is discarded from the final link, the corresponding
entries in the .sframe section for those functions are also deleted.

The linker sorts the SFrame FDEs on start address by default and sets
the SFRAME_F_FDE_SORTED flag in the .sframe section.

This patch also adds support for generation of SFrame unwind
information for the .plt* sections on x86_64.  SFrame unwind info is
generated for IBT enabled PLT, lazy/non-lazy PLT.

The existing linker option --no-ld-generated-unwind-info has been
adapted to include the control of whether .sframe unwind information
will be generated for the linker generated sections like PLT.

Changes to the linker script have been made as necessary.

ChangeLog:

	* Makefile.def: Add install dependency on libsframe for libbfd.
	* Makefile.in: Regenerated.
---
 Makefile.def |  4 ++++
 Makefile.in  | 11 +++++++++++
 2 files changed, 15 insertions(+)

Comments

Jeff Law Aug. 7, 2023, 5:59 p.m. UTC | #1 
On 8/7/23 04:33, Arsen Arsenović via Gcc-patches wrote:
> From: Indu Bhagat <indu.bhagat@oracle.com>
> 
> The linker merges all the input .sframe sections.  When merging, the
> linker verifies that all the input .sframe sections have the same
> abi/arch.
> 
> The linker uses libsframe library to perform key actions on the
> .sframe sections - decode, read, and create output data.  This
> implies buildsystem changes to make and install libsframe before
> libbfd.
> 
> The linker places the output .sframe section in a new segment of its
> own: PT_GNU_SFRAME.  A new segment is not added, however, if the
> generated .sframe section is empty.
> 
> When a section is discarded from the final link, the corresponding
> entries in the .sframe section for those functions are also deleted.
> 
> The linker sorts the SFrame FDEs on start address by default and sets
> the SFRAME_F_FDE_SORTED flag in the .sframe section.
> 
> This patch also adds support for generation of SFrame unwind
> information for the .plt* sections on x86_64.  SFrame unwind info is
> generated for IBT enabled PLT, lazy/non-lazy PLT.
> 
> The existing linker option --no-ld-generated-unwind-info has been
> adapted to include the control of whether .sframe unwind information
> will be generated for the linker generated sections like PLT.
> 
> Changes to the linker script have been made as necessary.
> 
> ChangeLog:
> 
> 	* Makefile.def: Add install dependency on libsframe for libbfd.
> 	* Makefile.in: Regenerated.
OK
jeff
diff mbox series

Patch

diff --git a/Makefile.def b/Makefile.def
index 86d25f43762..0c6784b6da1 100644
--- a/Makefile.def
+++ b/Makefile.def
@@ -459,11 +459,14 @@  dependencies = { module=all-gdbsupport; on=all-gnulib; };
 dependencies = { module=all-gdbsupport; on=all-intl; };
 
 // Host modules specific to binutils.
+// build libsframe before bfd for encoder/decoder support for linking
+// SFrame sections
 dependencies = { module=configure-bfd; on=configure-libiberty; hard=true; };
 dependencies = { module=configure-bfd; on=configure-intl; };
 dependencies = { module=all-bfd; on=all-libiberty; };
 dependencies = { module=all-bfd; on=all-intl; };
 dependencies = { module=all-bfd; on=all-zlib; };
+dependencies = { module=all-bfd; on=all-libsframe; };
 dependencies = { module=configure-opcodes; on=configure-libiberty; hard=true; };
 dependencies = { module=all-opcodes; on=all-libiberty; };
 
@@ -489,6 +492,7 @@  dependencies = { module=install-binutils; on=install-opcodes; };
 dependencies = { module=install-strip-binutils; on=install-strip-opcodes; };
 
 // Likewise for ld, libctf, and bfd.
+dependencies = { module=install-bfd; on=install-libsframe; };
 dependencies = { module=install-libctf; on=install-bfd; };
 dependencies = { module=install-ld; on=install-bfd; };
 dependencies = { module=install-ld; on=install-libctf; };
diff --git a/Makefile.in b/Makefile.in
index 214a2a15544..35a5d8c575d 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -66354,6 +66354,16 @@  all-stagetrain-bfd: maybe-all-stagetrain-zlib
 all-stagefeedback-bfd: maybe-all-stagefeedback-zlib
 all-stageautoprofile-bfd: maybe-all-stageautoprofile-zlib
 all-stageautofeedback-bfd: maybe-all-stageautofeedback-zlib
+all-bfd: maybe-all-libsframe
+all-stage1-bfd: maybe-all-stage1-libsframe
+all-stage2-bfd: maybe-all-stage2-libsframe
+all-stage3-bfd: maybe-all-stage3-libsframe
+all-stage4-bfd: maybe-all-stage4-libsframe
+all-stageprofile-bfd: maybe-all-stageprofile-libsframe
+all-stagetrain-bfd: maybe-all-stagetrain-libsframe
+all-stagefeedback-bfd: maybe-all-stagefeedback-libsframe
+all-stageautoprofile-bfd: maybe-all-stageautoprofile-libsframe
+all-stageautofeedback-bfd: maybe-all-stageautofeedback-libsframe
 configure-opcodes: configure-libiberty
 configure-stage1-opcodes: configure-stage1-libiberty
 configure-stage2-opcodes: configure-stage2-libiberty
@@ -66486,6 +66496,7 @@  all-stageautoprofile-binutils: maybe-all-stageautoprofile-libsframe
 all-stageautofeedback-binutils: maybe-all-stageautofeedback-libsframe
 install-binutils: maybe-install-opcodes
 install-strip-binutils: maybe-install-strip-opcodes
+install-bfd: maybe-install-libsframe
 install-libctf: maybe-install-bfd
 install-ld: maybe-install-bfd
 install-ld: maybe-install-libctf