diff mbox series

[v1] RISC-V: Fix one comment for binop_frm insn

Message ID 20230803143152.2087444-1-pan2.li@intel.com
State Unresolved
Headers
Series [v1] RISC-V: Fix one comment for binop_frm insn |

Checks

Context Check Description
snail/gcc-patch-check warning Git am fail log

Commit Message

Li, Pan2 via Gcc-patches Aug. 3, 2023, 2:31 p.m. UTC 
  From: Pan Li <pan2.li@intel.com>

The previous patch missed the vfsub comment for binop_frm, this
patch would like to fix this.

Signed-off-by: Pan Li <pan2.li@intel.com>

gcc/ChangeLog:

	* config/riscv/riscv-vector-builtins-bases.cc: Add vfsub.
---
 gcc/config/riscv/riscv-vector-builtins-bases.cc | 1 +
 1 file changed, 1 insertion(+)

Comments

Kito Cheng Aug. 3, 2023, 2:35 p.m. UTC | #1 
lgtm

On Thu, Aug 3, 2023 at 10:32 PM <pan2.li@intel.com> wrote:
>
> From: Pan Li <pan2.li@intel.com>
>
> The previous patch missed the vfsub comment for binop_frm, this
> patch would like to fix this.
>
> Signed-off-by: Pan Li <pan2.li@intel.com>
>
> gcc/ChangeLog:
>
>         * config/riscv/riscv-vector-builtins-bases.cc: Add vfsub.
> ---
>  gcc/config/riscv/riscv-vector-builtins-bases.cc | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/gcc/config/riscv/riscv-vector-builtins-bases.cc b/gcc/config/riscv/riscv-vector-builtins-bases.cc
> index 3adc11138a3..36c9aadd19c 100644
> --- a/gcc/config/riscv/riscv-vector-builtins-bases.cc
> +++ b/gcc/config/riscv/riscv-vector-builtins-bases.cc
> @@ -277,6 +277,7 @@ public:
>
>  /* Implements below instructions for now.
>     - vfadd
> +   - vfsub
>     - vfmul
>  */
>  template<rtx_code CODE>
> --
> 2.34.1
>
Li, Pan2 via Gcc-patches Aug. 3, 2023, 2:40 p.m. UTC | #2 
Committed, thanks Kito.

Pan

-----Original Message-----
From: Kito Cheng <kito.cheng@sifive.com> 
Sent: Thursday, August 3, 2023 10:35 PM
To: Li, Pan2 <pan2.li@intel.com>
Cc: gcc-patches@gcc.gnu.org; juzhe.zhong@rivai.ai; Wang, Yanzhang <yanzhang.wang@intel.com>
Subject: Re: [PATCH v1] RISC-V: Fix one comment for binop_frm insn

lgtm

On Thu, Aug 3, 2023 at 10:32 PM <pan2.li@intel.com> wrote:
>
> From: Pan Li <pan2.li@intel.com>
>
> The previous patch missed the vfsub comment for binop_frm, this
> patch would like to fix this.
>
> Signed-off-by: Pan Li <pan2.li@intel.com>
>
> gcc/ChangeLog:
>
>         * config/riscv/riscv-vector-builtins-bases.cc: Add vfsub.
> ---
>  gcc/config/riscv/riscv-vector-builtins-bases.cc | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/gcc/config/riscv/riscv-vector-builtins-bases.cc b/gcc/config/riscv/riscv-vector-builtins-bases.cc
> index 3adc11138a3..36c9aadd19c 100644
> --- a/gcc/config/riscv/riscv-vector-builtins-bases.cc
> +++ b/gcc/config/riscv/riscv-vector-builtins-bases.cc
> @@ -277,6 +277,7 @@ public:
>
>  /* Implements below instructions for now.
>     - vfadd
> +   - vfsub
>     - vfmul
>  */
>  template<rtx_code CODE>
> --
> 2.34.1
>
diff mbox series

Patch

diff --git a/gcc/config/riscv/riscv-vector-builtins-bases.cc b/gcc/config/riscv/riscv-vector-builtins-bases.cc
index 3adc11138a3..36c9aadd19c 100644
--- a/gcc/config/riscv/riscv-vector-builtins-bases.cc
+++ b/gcc/config/riscv/riscv-vector-builtins-bases.cc
@@ -277,6 +277,7 @@  public:
 
 /* Implements below instructions for now.
    - vfadd
+   - vfsub
    - vfmul
 */
 template<rtx_code CODE>