From patchwork Tue Jul 25 13:40:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 125621 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9010:0:b0:3e4:2afc:c1 with SMTP id l16csp2477848vqg; Tue, 25 Jul 2023 06:40:52 -0700 (PDT) X-Google-Smtp-Source: APBJJlH/khUCrACsGFsQ6agRON3aq1XFHdC5O2KWVNBxhdvFpwGHfuiGcfZd9S2I05JmNLD2gc8K X-Received: by 2002:a17:906:5393:b0:997:bb66:3ce with SMTP id g19-20020a170906539300b00997bb6603cemr14780710ejo.7.1690292452686; Tue, 25 Jul 2023 06:40:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690292452; cv=none; d=google.com; s=arc-20160816; b=fxOVT7bnjJUxqzI4LALPyQuFIgSQjO+0bXWdJAo2w+xfmGZ2VzdJK6YHC0HZJW/nZx nIKVJUv7g3PUHYpVaFEyo2AL8gULZWqB8jV2BdNElNyEcFlI51ssh+k6rQaIYXRhg8Zl 4fM+IIasfKPqCMBVfDfK93yvLIWiaEHNpdRDqUXFIRcFSatE1yEJTRu8mmV1Z6gzDWdF lfVPV+KxOtBQ28VkTPfm7+FXh1+0/ZPVxad5GIclh1ublB0IE+Z01LnpwAVCuuRPa6iD DLOQgrXD5wZPYVcWWGLxvyeRqGeHK5bKYYOfKZ+OOwZ5kAZsl13iIvFQ+k++MiAGX2Id Gsuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:sender:errors-to:reply-to:from:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence :mime-version:user-agent:subject:cc:to:date:dmarc-filter :delivered-to:dkim-signature:dkim-filter; bh=EDgd4yaV6JVf1tbgbcQShjNmSkTXSAbZ535IRI+MO2U=; fh=F1l8l14I3wcpM0YDuF0IEl9Pl+tMXKr21/RxoF08Ffo=; b=ai4snzVJGCmwI9n6RSybEXEKkz4t3o4/1AXjhv7DwK34E0TlJ/XJ7WAti088cV+Lh3 TTdy5aS5RUt4/d4vTeGDdTCFwTI8EbM8t5ej5Mb4WnlnjdfUlXbHd1IxrBYmrkPbqEtd EiH+VEtQ0iVUa2HWbO+Pg0aDpRb6yHZF5IvxHyRNUAD55sl5jppbmQFhp0ao+vyUAQrb 1fhNufvbLu4OdBWhCUsHSoJ90F2/BbLMkCW8JPWR+nMxLXiCUk7awI3yiZBqXF5p/JMq END+bUTPH9wIPHZVa/3DsgWf43llk+nr3lMsY3k+h2CpRBoufHsmm+J6FSYId7se4Blu 7SZQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=jp1cBwC9; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id qc6-20020a170906d8a600b0099332d4ed30si8312844ejb.677.2023.07.25.06.40.52 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 25 Jul 2023 06:40:52 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=jp1cBwC9; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 706193856DF4 for ; Tue, 25 Jul 2023 13:40:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 706193856DF4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1690292450; bh=EDgd4yaV6JVf1tbgbcQShjNmSkTXSAbZ535IRI+MO2U=; h=Date:To:cc:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=jp1cBwC9D31BhXlYXrd7Pho/MZtmsqSv1CCZHrtFUUwILuoM2HZmOgpQmF2YewdzN IBly7vvByJWAj06wMcHQTzEnLDwqEPNr2sjtR21+YMDHdjWB+rDAfIpb9shoZL6ZMv BT2n6G4dO/F5FpLHnlyGk9+LKqTjpLUdXZ4rrXis= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id A356C3858D3C for ; Tue, 25 Jul 2023 13:40:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A356C3858D3C Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 2450D1FD6D; Tue, 25 Jul 2023 13:40:04 +0000 (UTC) Received: from wotan.suse.de (wotan.suse.de [10.160.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 12C002C143; Tue, 25 Jul 2023 13:40:04 +0000 (UTC) Date: Tue, 25 Jul 2023 13:40:04 +0000 (UTC) To: gcc-patches@gcc.gnu.org cc: vmakarov@redhat.com Subject: [PATCH] rtl-optimization/110587 - remove quadratic regno_in_use_p User-Agent: Alpine 2.22 (LSU 394 2020-01-19) MIME-Version: 1.0 X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Biener via Gcc-patches From: Richard Biener Reply-To: Richard Biener Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" Message-Id: <20230725134050.706193856DF4@sourceware.org> X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1772400098740067564 X-GMAIL-MSGID: 1772400098740067564 The following removes the code checking whether a noop copy is between something involved in the return sequence composed of a SET and USE. Instead of checking for this special-case the following makes us only ever remove noop copies between pseudos - which is the case that is necessary for IRA/LRA interfacing to function according to the comment. That makes looking for the return reg special case unnecessary, reducing the compile-time in LRA non-specific to zero for the testcase. Bootstrapped and tested on x86_64-unknown-linux-gnu with all languages and {,-m32}. OK? Thanks, Richard. PR rtl-optimization/110587 * lra-spills.cc (return_regno_p): Remove. (regno_in_use_p): Likewise. (lra_final_code_change): Do not remove noop moves between hard registers. --- gcc/lra-spills.cc | 69 +---------------------------------------------- 1 file changed, 1 insertion(+), 68 deletions(-) diff --git a/gcc/lra-spills.cc b/gcc/lra-spills.cc index 3a7bb7e8cd9..fe58f162d05 100644 --- a/gcc/lra-spills.cc +++ b/gcc/lra-spills.cc @@ -705,72 +705,6 @@ alter_subregs (rtx *loc, bool final_p) return res; } -/* Return true if REGNO is used for return in the current - function. */ -static bool -return_regno_p (unsigned int regno) -{ - rtx outgoing = crtl->return_rtx; - - if (! outgoing) - return false; - - if (REG_P (outgoing)) - return REGNO (outgoing) == regno; - else if (GET_CODE (outgoing) == PARALLEL) - { - int i; - - for (i = 0; i < XVECLEN (outgoing, 0); i++) - { - rtx x = XEXP (XVECEXP (outgoing, 0, i), 0); - - if (REG_P (x) && REGNO (x) == regno) - return true; - } - } - return false; -} - -/* Return true if REGNO is in one of subsequent USE after INSN in the - same BB. */ -static bool -regno_in_use_p (rtx_insn *insn, unsigned int regno) -{ - static lra_insn_recog_data_t id; - static struct lra_static_insn_data *static_id; - struct lra_insn_reg *reg; - int i, arg_regno; - basic_block bb = BLOCK_FOR_INSN (insn); - - while ((insn = next_nondebug_insn (insn)) != NULL_RTX) - { - if (BARRIER_P (insn) || bb != BLOCK_FOR_INSN (insn)) - return false; - if (! INSN_P (insn)) - continue; - if (GET_CODE (PATTERN (insn)) == USE - && REG_P (XEXP (PATTERN (insn), 0)) - && regno == REGNO (XEXP (PATTERN (insn), 0))) - return true; - /* Check that the regno is not modified. */ - id = lra_get_insn_recog_data (insn); - for (reg = id->regs; reg != NULL; reg = reg->next) - if (reg->type != OP_IN && reg->regno == (int) regno) - return false; - static_id = id->insn_static_data; - for (reg = static_id->hard_regs; reg != NULL; reg = reg->next) - if (reg->type != OP_IN && reg->regno == (int) regno) - return false; - if (id->arg_hard_regs != NULL) - for (i = 0; (arg_regno = id->arg_hard_regs[i]) >= 0; i++) - if ((int) regno == (arg_regno >= FIRST_PSEUDO_REGISTER - ? arg_regno : arg_regno - FIRST_PSEUDO_REGISTER)) - return false; - } - return false; -} - /* Final change of pseudos got hard registers into the corresponding hard registers and removing temporary clobbers. */ void @@ -821,8 +755,7 @@ lra_final_code_change (void) if (NONJUMP_INSN_P (insn) && GET_CODE (pat) == SET && REG_P (SET_SRC (pat)) && REG_P (SET_DEST (pat)) && REGNO (SET_SRC (pat)) == REGNO (SET_DEST (pat)) - && (! return_regno_p (REGNO (SET_SRC (pat))) - || ! regno_in_use_p (insn, REGNO (SET_SRC (pat))))) + && REGNO (SET_SRC (pat)) >= FIRST_PSEUDO_REGISTER) { lra_invalidate_insn_data (insn); delete_insn (insn);