diff mbox series

bpf: fixed template for neg (added second operand)

Message ID 20230721164332.29163-1-cupertino.miranda@oracle.com
State Accepted
Headers
Series bpf: fixed template for neg (added second operand) |

Checks

Context Check Description
snail/gcc-patch-check success Github commit url

Commit Message

Cupertino Miranda July 21, 2023, 4:43 p.m. UTC 
  gcc/ChangeLog:

	* config/bpf/bpf.md: fixed template for neg instruction.
---
 gcc/config/bpf/bpf.md | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Faust July 21, 2023, 4:57 p.m. UTC | #1 
Hi Cupertino,

On 7/21/23 09:43, Cupertino Miranda wrote:
> gcc/ChangeLog:
> 
> 	* config/bpf/bpf.md: fixed template for neg instruction.
> ---
>  gcc/config/bpf/bpf.md | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gcc/config/bpf/bpf.md b/gcc/config/bpf/bpf.md
> index 329f62f55c33..bb414d8a4428 100644
> --- a/gcc/config/bpf/bpf.md
> +++ b/gcc/config/bpf/bpf.md
> @@ -142,7 +142,7 @@
>    [(set (match_operand:AM 0 "register_operand" "=r")
>          (neg:AM (match_operand:AM 1 "register_operand" " 0")))]
>    ""
> -  "neg<msuffix>\t%0"
> +  "neg<msuffix>\t%0,%1"
>    [(set_attr "type" "<mtype>")])

I think you will need to update the constraint for the second
operand as well; it could be any register, or a 32-bit immediate.

>  
>  ;;; Multiplication
Jose E. Marchesi July 21, 2023, 6:06 p.m. UTC | #2 
Hi Cuper.
OK.  Thanks!

> From 7756a4becd1934e55d6d14ac4a9fd6d408a4797b Mon Sep 17 00:00:00 2001
> From: Cupertino Miranda <cupertino.miranda@oracle.com>
> Date: Fri, 21 Jul 2023 17:40:07 +0100
> Subject: [PATCH v3] bpf: fixed template for neg (added second operand)
>
> gcc/ChangeLog:
>
> 	* config/bpf/bpf.md: fixed template for neg instruction.
> ---
>  gcc/config/bpf/bpf.md | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gcc/config/bpf/bpf.md b/gcc/config/bpf/bpf.md
> index 329f62f55c33..adf11e151df1 100644
> --- a/gcc/config/bpf/bpf.md
> +++ b/gcc/config/bpf/bpf.md
> @@ -139,10 +139,10 @@
>  
>  ;;; Negation
>  (define_insn "neg<AM:mode>2"
> -  [(set (match_operand:AM 0 "register_operand" "=r")
> -        (neg:AM (match_operand:AM 1 "register_operand" " 0")))]
> +  [(set (match_operand:AM         0 "register_operand" "=r,r")
> +        (neg:AM (match_operand:AM 1 "register_operand" " r,I")))]
>    ""
> -  "neg<msuffix>\t%0"
> +  "neg<msuffix>\t%0,%1"
>    [(set_attr "type" "<mtype>")])
>  
>  ;;; Multiplication
Cupertino Miranda July 21, 2023, 6:40 p.m. UTC | #3 
This patch fixes define_insn for "neg" to support 2 operands.
Initial implementation assumed the format "neg %0" while the instruction
allows both a destination and source operands. The second operand can
either be a register or an immediate value.

gcc/ChangeLog:

	* config/bpf/bpf.md: fixed template for neg instruction.
---
 gcc/config/bpf/bpf.md | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gcc/config/bpf/bpf.md b/gcc/config/bpf/bpf.md
index 329f62f55c33..adf11e151df1 100644
--- a/gcc/config/bpf/bpf.md
+++ b/gcc/config/bpf/bpf.md
@@ -139,10 +139,10 @@

 ;;; Negation
 (define_insn "neg<AM:mode>2"
-  [(set (match_operand:AM 0 "register_operand" "=r")
-        (neg:AM (match_operand:AM 1 "register_operand" " 0")))]
+  [(set (match_operand:AM         0 "register_operand" "=r,r")
+        (neg:AM (match_operand:AM 1 "register_operand" " r,I")))]
   ""
-  "neg<msuffix>\t%0"
+  "neg<msuffix>\t%0,%1"
   [(set_attr "type" "<mtype>")])

 ;;; Multiplication
--
2.38.1
diff mbox series

Patch

diff --git a/gcc/config/bpf/bpf.md b/gcc/config/bpf/bpf.md
index 329f62f55c33..bb414d8a4428 100644
--- a/gcc/config/bpf/bpf.md
+++ b/gcc/config/bpf/bpf.md
@@ -142,7 +142,7 @@ 
   [(set (match_operand:AM 0 "register_operand" "=r")
         (neg:AM (match_operand:AM 1 "register_operand" " 0")))]
   ""
-  "neg<msuffix>\t%0"
+  "neg<msuffix>\t%0,%1"
   [(set_attr "type" "<mtype>")])
 
 ;;; Multiplication