diff mbox series

LoongArch: Allow using --with-arch=native if host CPU is LoongArch

Message ID 20230720132910.210043-1-xry111@xry111.site
State Accepted
Headers
Series LoongArch: Allow using --with-arch=native if host CPU is LoongArch |

Checks

Context Check Description
snail/gcc-patch-check success Github commit url

Commit Message

Xi Ruoyao July 20, 2023, 1:28 p.m. UTC 
  If the host triple and the target triple are different but the host is
LoongArch, in some cases --with-arch=native can be useful.  For example,
if we are bootstrapping a loongarch64-linux-musl toolchain on a
Glibc-based system and we don't intend to use the toolchain on other
machines, we can use

    ../gcc/configure --{build,host}=loongarch64-linux-gnu \
                     --target=loongarch64-linux-musl --with-arch=native

Relax the check in config.gcc to allow such configurations.

gcc/ChangeLog:

	* config.gcc [target=loongarch*-*-*, with_arch=native]: Allow
	building cross compiler if the host CPU is LoongArch.
---

Tested on x86_64-linux-gnu (building a cross compiler targeting
LoongArch --with-arch=native still rejected) and loongarch64-linux-gnu
(building a cross compiler targeting loongarch64-linux-musl allowed).
Ok for trunk?

 gcc/config.gcc | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

Comments

chenglulu July 22, 2023, 9:11 a.m. UTC | #1 
在 2023/7/20 下午9:28, Xi Ruoyao 写道:
> If the host triple and the target triple are different but the host is
> LoongArch, in some cases --with-arch=native can be useful.  For example,
> if we are bootstrapping a loongarch64-linux-musl toolchain on a
> Glibc-based system and we don't intend to use the toolchain on other
> machines, we can use
>
>      ../gcc/configure --{build,host}=loongarch64-linux-gnu \
>                       --target=loongarch64-linux-musl --with-arch=native
>
> Relax the check in config.gcc to allow such configurations.
>
> gcc/ChangeLog:
>
> 	* config.gcc [target=loongarch*-*-*, with_arch=native]: Allow
> 	building cross compiler if the host CPU is LoongArch.
> ---
>
> Tested on x86_64-linux-gnu (building a cross compiler targeting
> LoongArch --with-arch=native still rejected) and loongarch64-linux-gnu
> (building a cross compiler targeting loongarch64-linux-musl allowed).
> Ok for trunk?


Hi, Ruoyao:

  I'm sorry that some things at home are late, can this usage scenario 
be described in detail? I didn't really understand that.

>
>   gcc/config.gcc | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/gcc/config.gcc b/gcc/config.gcc
> index 1446eb2b3ca..146bca22a38 100644
> --- a/gcc/config.gcc
> +++ b/gcc/config.gcc
> @@ -4939,10 +4939,13 @@ case "${target}" in
>   		case ${with_arch} in
>   		"" | loongarch64 | la464) ;; # OK, append here.
>   		native)
> -			if test x${host} != x${target}; then
> +			case ${host} in
> +			loongarch*) ;; # OK
> +			*)
>   				echo "--with-arch=native is illegal for cross-compiler." 1>&2
>   				exit 1
> -			fi
> +				;;
> +			esac
>   			;;
>   		"")
>   			echo "Please set a default value for \${with_arch}" \
diff mbox series

Patch

diff --git a/gcc/config.gcc b/gcc/config.gcc
index 1446eb2b3ca..146bca22a38 100644
--- a/gcc/config.gcc
+++ b/gcc/config.gcc
@@ -4939,10 +4939,13 @@  case "${target}" in
 		case ${with_arch} in
 		"" | loongarch64 | la464) ;; # OK, append here.
 		native)
-			if test x${host} != x${target}; then
+			case ${host} in
+			loongarch*) ;; # OK
+			*)
 				echo "--with-arch=native is illegal for cross-compiler." 1>&2
 				exit 1
-			fi
+				;;
+			esac
 			;;
 		"")
 			echo "Please set a default value for \${with_arch}" \