From patchwork Tue Jul 18 06:27:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ken Matsui X-Patchwork-Id: 121797 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:c923:0:b0:3e4:2afc:c1 with SMTP id j3csp1543285vqt; Mon, 17 Jul 2023 23:34:16 -0700 (PDT) X-Google-Smtp-Source: APBJJlFeN6DtdOYOs0IkK9/Qx4cjG+rAUdsWEhhrsbJMK3DdPrj9MwH5MZPOmcKlkaz67+xPQAyn X-Received: by 2002:a17:906:d5:b0:993:d5bd:a757 with SMTP id 21-20020a17090600d500b00993d5bda757mr13218468eji.19.1689662056538; Mon, 17 Jul 2023 23:34:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689662056; cv=none; d=google.com; s=arc-20160816; b=Sm8AjCDRNQ34ZA24eM2BXd0MWzkqAQn/6y5YTYb+ZRTKpCZwDyXM9vE7TL3npFD34j 5ZvfjfdfT8w4ikBOAiHGi9c3vn30/BLFM0FRCDdS45VRRlukweC0silGdJitRVA0cwJD jkfmhnfy7mx3TNOboymPwYeEPUccMFJBmbNggL+PqRF8LG8vVRbN/XXiTLc6qGHQnuPb 7fdTpC2O9GnqUOm/0SN/+ZbSo81Jb4UJ7DaNFxIxlOX0F6EupIQJAT+02TXiGe0T0J4c DFC3C0lLZ2Z7V4C8V6/BHda+n+i8spHd84xkjaF5uAznpRYSAFGA42qGSmO6l8DmuLGi 0QKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=0GjzdamQmr9DnkSfHxLMt+P2emmZnT2abzT4qgGTR7c=; fh=1CAabwJrK+ugngH18pg8mqZVlwzSJe6ffxxXK5OO7Vs=; b=HYjIBa8DuTGmiZXofswF52nKkyYZvM9K8N/I49QqsQzbtA7lIIat2fZYhVZ0+Qeq8b cx/T9xcJai7q0FKihXYlCtUXtTkuEby4VAFvuh6iD+ymjvOs2cMR71NNC+yeHTIkmSir xCA+kGAIf1ia0A2LCo/MKo9oKMqBLXQ4xQNh4dqKLbHzZrHY+HvfJJ4VsT2lIZ+CCVVY 0RI84Gp89T407Rw5OR2KOCRk/lSOgMq0ExVY5giJAPV9cqMVs8glfszLJZnK8aXoGuGl 2QwZyyo9AmWfcINhNgjImrJRpcrnoV40LHaQucEsHEa4Puphzwkft4aIy9lyYRrtQYOn 1kDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=rz82cXer; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id v27-20020a1709060b5b00b0098655fb6608si729277ejg.158.2023.07.17.23.34.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Jul 2023 23:34:16 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=rz82cXer; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D6A4B385624C for ; Tue, 18 Jul 2023 06:30:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D6A4B385624C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1689661844; bh=0GjzdamQmr9DnkSfHxLMt+P2emmZnT2abzT4qgGTR7c=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=rz82cXercUIwvhNsD22Ax2vdEb8n6x8QaLi+iUgN48xMIn5CSboDo3jkODSRvG0ui 3wGiOqFo8WZNeKOmYDamdiiqhQCGH+qjD6bXxeJAbZI7vAwrqb3IJFl0v/X6l5eFIg ouj+x3IMRXh/Ueqpu8iGjBKDpWBRiosAVppqhzh8= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0b-00641c01.pphosted.com (mx0b-00641c01.pphosted.com [205.220.177.146]) by sourceware.org (Postfix) with ESMTPS id C887A385AF9B; Tue, 18 Jul 2023 06:29:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C887A385AF9B Received: from pps.filterd (m0247480.ppops.net [127.0.0.1]) by mx0a-00641c01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 36I6SDtZ000707; Tue, 18 Jul 2023 06:29:58 GMT Received: from mxout21.s.uw.edu (mxout21.s.uw.edu [140.142.32.139]) by mx0a-00641c01.pphosted.com (PPS) with ESMTPS id 3rwc68jhfw-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 18 Jul 2023 06:29:58 +0000 Received: from smtp.washington.edu (smtp.washington.edu [128.208.60.54]) by mxout21.s.uw.edu (8.14.4+UW20.07/8.14.4+UW22.04) with ESMTP id 36I6TXhQ014528 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 17 Jul 2023 23:29:33 -0700 X-Auth-Received: from localhost.localdomain ([10.154.74.234]) (authenticated authid=kmatsui) by smtp.washington.edu (8.16.1+UW21.10/8.14.4+UW19.10) with ESMTPSA id 36I6Rko8019954 (version=TLSv1.2 cipher=DHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Mon, 17 Jul 2023 23:29:33 -0700 X-UW-Orig-Sender: kmatsui@smtp.washington.edu To: gcc-patches@gcc.gnu.org Cc: libstdc++@gcc.gnu.org, Ken Matsui Subject: [PATCH v3 3/3] libstdc++: Optimize is_fundamental performance by __is_arithmetic built-in Date: Mon, 17 Jul 2023 23:27:45 -0700 Message-ID: <20230718062745.29470-3-kmatsui@gcc.gnu.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230718062745.29470-1-kmatsui@gcc.gnu.org> References: <20230715045519.50684-1-kmatsui@gcc.gnu.org> <20230718062745.29470-1-kmatsui@gcc.gnu.org> MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: Cq9ev_kLKIWXUMsAe8RII8J9e2Bwku8y X-Proofpoint-GUID: Cq9ev_kLKIWXUMsAe8RII8J9e2Bwku8y X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-17_15,2023-07-13_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxlogscore=633 clxscore=1034 priorityscore=1501 bulkscore=0 lowpriorityscore=0 suspectscore=0 mlxscore=0 malwarescore=0 impostorscore=0 spamscore=0 phishscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2306200000 definitions=main-2307180058 X-Spam-Status: No, score=-13.0 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NEUTRAL, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Ken Matsui via Gcc-patches From: Ken Matsui Reply-To: Ken Matsui Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771461315731651338 X-GMAIL-MSGID: 1771739080567911035 This patch optimizes the performance of the is_fundamental trait by dispatching to the new __is_arithmetic built-in trait. libstdc++-v3/ChangeLog: * include/std/type_traits (is_fundamental_v): Use __is_arithmetic built-in trait. (is_fundamental): Likewise. Optimize the original implementation. Signed-off-by: Ken Matsui --- libstdc++-v3/include/std/type_traits | 21 +++++++++++++++++---- 1 file changed, 17 insertions(+), 4 deletions(-) diff --git a/libstdc++-v3/include/std/type_traits b/libstdc++-v3/include/std/type_traits index 7ebbe04c77b..cf24de2fcac 100644 --- a/libstdc++-v3/include/std/type_traits +++ b/libstdc++-v3/include/std/type_traits @@ -668,11 +668,21 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION #endif /// is_fundamental +#if __has_builtin(__is_arithmetic) + template + struct is_fundamental + : public __bool_constant<__is_arithmetic(_Tp) + || is_void<_Tp>::value + || is_null_pointer<_Tp>::value> + { }; +#else template struct is_fundamental - : public __or_, is_void<_Tp>, - is_null_pointer<_Tp>>::type + : public __bool_constant::value + || is_void<_Tp>::value + || is_null_pointer<_Tp>::value> { }; +#endif /// is_object template @@ -3209,13 +3219,16 @@ template #if __has_builtin(__is_arithmetic) template inline constexpr bool is_arithmetic_v = __is_arithmetic(_Tp); +template + inline constexpr bool is_fundamental_v + = __is_arithmetic(_Tp) || is_void_v<_Tp> || is_null_pointer_v<_Tp>; #else template inline constexpr bool is_arithmetic_v = is_arithmetic<_Tp>::value; -#endif - template inline constexpr bool is_fundamental_v = is_fundamental<_Tp>::value; +#endif + template inline constexpr bool is_object_v = is_object<_Tp>::value; template