From patchwork Tue Jul 11 10:22:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 118406 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:a6b2:0:b0:3e4:2afc:c1 with SMTP id c18csp373400vqm; Tue, 11 Jul 2023 03:23:26 -0700 (PDT) X-Google-Smtp-Source: APBJJlHg1Ba1SXhcQSggFnII9a7pWX3UDC8M120LW+/K+y/3+pQqoIKgehQOTbvlTo4ck+8UL0X/ X-Received: by 2002:a17:906:8251:b0:987:5147:7498 with SMTP id f17-20020a170906825100b0098751477498mr13191844ejx.32.1689071005987; Tue, 11 Jul 2023 03:23:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1689071005; cv=none; d=google.com; s=arc-20160816; b=OEv6xZiDTeII1X/HukgxiKge0sxOUgXuMjRcAbTBD2eE0fPm52f2FAy78p8/9MbOgE 4wB4Rrj4krD9DoQ2TJhRBhWzsOsYjLjT8XW65HErcw1YH7AVBuRdItv15xXOIlWNHI8d kdRfAsl6vv4BHrqpFmp7kRXY1afQZTe0R8vR9nCnj/3wnqxwhEcLGyjgwUHvRykDosNE LBnVTRBDz/96fubeK3PpO+sJtH5aTU6GeOG0Xlqrn59Wy3mBv+AoHcBFMXLsMK6l4ti5 2ccSZ3VjKxFnhHUGuaRA2OV0Vg8Icvq5TlVZc1TdOQEr5vC674rxoZCsLksBC4EY15QR dFJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:sender:errors-to:reply-to:from:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence :mime-version:user-agent:subject:to:date:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=xZXSWLhCjt1eL3UW23NwZVPnRuKFNVfZgDi35aAEmVw=; fh=etb9MYHN7HLF/sff76ICVdPeKiI8ZsjoOL2bcdG0aog=; b=ELST0VuopfQhWaZaZUyCPNg0tVKrvxGlHUJMujoMikq1xCupReclwyRk5JwQk1Q63y zfUnOalkTwsM60fAFHEF54BTCg1y3J7uzuM6D0nakTAvym7JmBTrM3we+38bk0ape2hX nkn70HDpje3zTHK04ZVGzfRMXrIUgLNs7tDPHvC4MgCIPQs4jhkIYMgoB5GO3jg2imRr KLq0jYcnJp8RmwHDZDrBsxWJEw9bptcp8gfGW1M6WzKHHJ3L940mHKnQtyH7Puy7l1uX OtaHjE0cNAgPfuOzkIA+jHHcRNjnojPlAirrMjNPtZkWXDXqb2BlK6QlWAYY+SRmoauw LEog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=tm79Qksj; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id qq23-20020a17090720d700b0098d0a88d4fasi1854146ejb.808.2023.07.11.03.23.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jul 2023 03:23:25 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=tm79Qksj; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 129C83855587 for ; Tue, 11 Jul 2023 10:23:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 129C83855587 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1689070988; bh=xZXSWLhCjt1eL3UW23NwZVPnRuKFNVfZgDi35aAEmVw=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=tm79Qksjdq00Dc2k5uJjPz/2A47wpSWrFKpihMMqOpWvXfNXvq4ezJ7OXWCzzmD3+ I7jbm6uYNw20QiuV9pTKd1jCuJvCentFA5EP619ZSS6zklDAvJ6Gqx8R0uriUWi9HN 45pdJpg2lYvpnQMlytiHui6nlsCK+4UvqjFH4Kgo= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id 4F4FE385770B for ; Tue, 11 Jul 2023 10:22:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4F4FE385770B Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id BD99E20263 for ; Tue, 11 Jul 2023 10:22:23 +0000 (UTC) Received: from wotan.suse.de (wotan.suse.de [10.160.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id B36ED2C145 for ; Tue, 11 Jul 2023 10:22:23 +0000 (UTC) Date: Tue, 11 Jul 2023 10:22:23 +0000 (UTC) To: gcc-patches@gcc.gnu.org Subject: [PATCH] tree-optimization/110614 - SLP splat and re-align (optimized) User-Agent: Alpine 2.22 (LSU 394 2020-01-19) MIME-Version: 1.0 X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Biener via Gcc-patches From: Richard Biener Reply-To: Richard Biener Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" Message-Id: <20230711102308.129C83855587@sourceware.org> X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1771119318972008158 X-GMAIL-MSGID: 1771119318972008158 The following properly guards the re-align (optimized) paths used on old power CPUs for the added case of SLP splats from non-grouped loads. Testcases are existing in dg-torture. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. PR tree-optimization/110614 * tree-vect-data-refs.cc (vect_supportable_dr_alignment): SLP splats are not suitable for re-align ops. --- gcc/tree-vect-data-refs.cc | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/gcc/tree-vect-data-refs.cc b/gcc/tree-vect-data-refs.cc index ab2af103cb4..9edc8989de9 100644 --- a/gcc/tree-vect-data-refs.cc +++ b/gcc/tree-vect-data-refs.cc @@ -6829,10 +6829,11 @@ vect_supportable_dr_alignment (vec_info *vinfo, dr_vec_info *dr_info, same alignment, instead it depends on the SLP group size. */ if (loop_vinfo && STMT_SLP_TYPE (stmt_info) - && !multiple_p (LOOP_VINFO_VECT_FACTOR (loop_vinfo) - * (DR_GROUP_SIZE - (DR_GROUP_FIRST_ELEMENT (stmt_info))), - TYPE_VECTOR_SUBPARTS (vectype))) + && (!STMT_VINFO_GROUPED_ACCESS (stmt_info) + || !multiple_p (LOOP_VINFO_VECT_FACTOR (loop_vinfo) + * (DR_GROUP_SIZE + (DR_GROUP_FIRST_ELEMENT (stmt_info))), + TYPE_VECTOR_SUBPARTS (vectype)))) ; else if (!loop_vinfo || (nested_in_vect_loop