From patchwork Wed Jun 28 09:12:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 113720 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp8780307vqr; Wed, 28 Jun 2023 02:13:36 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6EX2zNAgxjBkihkvBUBgMdUlNEbd0IlX9ghHYRI5TzwnL+oIaacuxJasi12h2FHzX6csSU X-Received: by 2002:a17:907:7291:b0:98d:d26c:e142 with SMTP id dt17-20020a170907729100b0098dd26ce142mr11278546ejc.46.1687943616734; Wed, 28 Jun 2023 02:13:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687943616; cv=none; d=google.com; s=arc-20160816; b=kGPUif22O5a0EZD9w3mmZB8Qd3y5uiIvG5YE5+G+p3Qyn+oQE5ktPhq/iVIN9TuPDr Avqx4447UbyS7Ou2ORhhfSQhiKvATQNHLBqFfP9nRHf7aKCXr9Sz6eraroIiewjcUvSu TrqqD0mDYfXoQjitJ7ldXI9MIyHdDraktOALHGoKpgb8c1J92ONGkjYuJcdhoTDpMfWr RSUxGdmKkvOejjRpl2hCbjDxSxyaZSBQHHZQSN+FUpTFUoXqrJZWbJUKG2MSoNQHGsZE lSIYL5HUpN45zoV+U9CGgTJW9cC74nqTp/bAyFl3UPReOKxHc3NhJe7pEfH03MHa76Of yl6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:sender:errors-to:reply-to:from:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence :mime-version:user-agent:subject:to:date:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=8vUf38sT+XnlK1uReHEZpMJAVntOfk/sEnpXBnmKYVI=; fh=hPrbWPhweUx4V0GV9uXJqbyAzg2ABmTz7kczrAQqMmM=; b=BZiel2aiM4rnvGKqS2leZ1KcKe118JGyhX8GzE52Wuw0CvDJ0fr/rSQF7tBUfOhdZe 5VYFuRntij4S6yUVd6mT0+CrGBFEWSqOqNCmfMjfK/MBRrNqoPpHKfhN81nuCv/QgU+B I3t/COQH58ILhzYXpIb2frUmCnzI0zbYYiV6ApOFZ3sxfvGTmGNQt8OCoG2c6745guaa P/u/RLJFEkDjF01l4WTfIiJYXJCylUBYfemQpjoMGE+sN0gT/POarhXdmxCF9Bnqjobw qDzWX4tc3w2zYv8qjr57vKLRSE2RqUBcXrW07JK/vM1HwjfFQWEGO2ivlm5rK3EXzucb Onhg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=eoxMQ2Tm; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id ox27-20020a170907101b00b00987accb14aesi5321134ejb.893.2023.06.28.02.13.36 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jun 2023 02:13:36 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=eoxMQ2Tm; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3400C3858416 for ; Wed, 28 Jun 2023 09:13:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3400C3858416 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1687943611; bh=8vUf38sT+XnlK1uReHEZpMJAVntOfk/sEnpXBnmKYVI=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=eoxMQ2TmaDLsRxs4KK3NjKFNQ/tGV0dM7Fh7Z8y8Kj823hjEKdCPfYWfwrTdbPsf8 sXOt5ab0MQ4h/bw2GFjrVs2JxfMMm6/wI0rmgnK1ubsGp0T/8bxV3jIZrRbJpQop60 u3kG0CcomTC5k/MFbfv7yn4L6R+OlXRd2UwhOqpg= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id A07273858D35 for ; Wed, 28 Jun 2023 09:12:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A07273858D35 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 8D17E1F8C4 for ; Wed, 28 Jun 2023 09:12:33 +0000 (UTC) Received: from wotan.suse.de (wotan.suse.de [10.160.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 81CC22C2D4 for ; Wed, 28 Jun 2023 09:12:33 +0000 (UTC) Date: Wed, 28 Jun 2023 09:12:33 +0000 (UTC) To: gcc-patches@gcc.gnu.org Subject: [PATCH] tree-optimization/110443 - prevent SLP splat of gathers User-Agent: Alpine 2.22 (LSU 394 2020-01-19) MIME-Version: 1.0 X-Spam-Status: No, score=-10.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Biener via Gcc-patches From: Richard Biener Reply-To: Richard Biener Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" Message-Id: <20230628091331.3400C3858416@sourceware.org> X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769937166079992680?= X-GMAIL-MSGID: =?utf-8?q?1769937166079992680?= The following prevents non-grouped load SLP in case the element to splat is from a gather operation. While it should be possible to support this it is not similar to the single element interleaving case I was trying to mimic here. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. PR tree-optimization/110443 * tree-vect-slp.cc (vect_build_slp_tree_1): Reject non-grouped gather loads. * gcc.dg/torture/pr110443.c: New testcase. --- gcc/testsuite/gcc.dg/torture/pr110443.c | 21 +++++++++++++++++++++ gcc/tree-vect-slp.cc | 3 ++- 2 files changed, 23 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.dg/torture/pr110443.c diff --git a/gcc/testsuite/gcc.dg/torture/pr110443.c b/gcc/testsuite/gcc.dg/torture/pr110443.c new file mode 100644 index 00000000000..61cf705869c --- /dev/null +++ b/gcc/testsuite/gcc.dg/torture/pr110443.c @@ -0,0 +1,21 @@ +/* { dg-do compile } */ + +typedef struct { + float real; + float imag; +} complex_t; +extern unsigned char fftorder[]; +float *a52_imdct_256_data; +int a52_imdct_256_i, a52_imdct_256_k; +float a52_imdct_256_b_r; +void a52_imdct_256() +{ + complex_t buf1[64]; + a52_imdct_256_i = 0; + for (; a52_imdct_256_i < 64; a52_imdct_256_i++) { + a52_imdct_256_k = fftorder[a52_imdct_256_i]; + buf1[a52_imdct_256_i].real = buf1[a52_imdct_256_i].imag = + a52_imdct_256_data[a52_imdct_256_k]; + } + a52_imdct_256_b_r = buf1[0].real * buf1[0].imag; +} diff --git a/gcc/tree-vect-slp.cc b/gcc/tree-vect-slp.cc index 8cb1ac1f319..355d078d66e 100644 --- a/gcc/tree-vect-slp.cc +++ b/gcc/tree-vect-slp.cc @@ -1291,7 +1291,8 @@ vect_build_slp_tree_1 (vec_info *vinfo, unsigned char *swap, vectorization. For loop vectorization we can handle splats the same we handle single element interleaving. */ && (is_a (vinfo) - || stmt_info != first_stmt_info)) + || stmt_info != first_stmt_info + || STMT_VINFO_GATHER_SCATTER_P (stmt_info))) { /* Not grouped load. */ if (dump_enabled_p ())