From patchwork Fri Jun 23 08:27:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 111978 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp5617100vqr; Fri, 23 Jun 2023 01:28:08 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7P3cduqagxz8vEgVMKGgHP0EYIEPc0VmG3CVxaw7ywFk5JxHJQMLXv3XrIhHI/+diPx/ok X-Received: by 2002:aa7:db47:0:b0:51a:512b:1b2 with SMTP id n7-20020aa7db47000000b0051a512b01b2mr10799290edt.5.1687508888284; Fri, 23 Jun 2023 01:28:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687508888; cv=none; d=google.com; s=arc-20160816; b=cAgBOQ9/htLZqBbSiOA6hQNrn3x11WqK7kWQIkx1C4d1IGcG/Oz8lQ3Wq/22UV1lKj AQKSC0i8U7gNXfCrjOt7yDtFAAXWWL0Z58cKe05HYuTj13QB+fFHxGEkJBR8DbBLoMiN 5Hr622FPdeHsGMaHqDTT2oLpkBh0ehM52gf8UGSr21RcWZfWOZOKUqhjqZrVwMpobK2J cCp6mZYo74/Qgi/m/OwwMK3wyrN+9PQF12QMg0xon2paHvA1mhivQSLssx6p9fn1WmQY 0hlDSAqyHjNg1omHM7CAcHQzB6jhR12XDhxviqV/I4TqowQxN7Plz37eFGmFNvsZxzjH jSJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:message-id :mime-version:subject:to:date:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=3wbHXJ4umxP50X8N4l6uxwnI3l0bXV8RpGPuHmCelQ8=; b=AD43rOBPu0MBd4nOfHrQXdncwtty+KDgx0yBHGySbD8hDiCDFAx0RTsyS8YP7NMNeG PcmXxyFVlOvbKDLhS0ab07r93WzAKK0u2j0IN2FbZvYF58hvC/w27+pqSzCmmXIfZ/3c cceeBQkf4/ZWwfIG/bCurEFPtSpDkhL9hGtye08zcEUiGh2Ci6LoNQtw64xPNILuVfFZ +ZcKr4ZQNjMTZ0Jz42GpeGEyx8k09et6/WcyMoLgczmrw1izLUKLxqMNBlMqlZt7eHqq p0wPsgfcgI54IcE2WxRm+Gm/u3Ac70UeIT1Wd2Asyjtb7EpTWBJ+iXi7b5HvJq3ozfN+ 2eRg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=eCfuNNwE; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id d9-20020aa7ce09000000b0051827a10497si4378076edv.212.2023.06.23.01.28.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jun 2023 01:28:08 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=eCfuNNwE; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C22A63857025 for ; Fri, 23 Jun 2023 08:27:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C22A63857025 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1687508872; bh=3wbHXJ4umxP50X8N4l6uxwnI3l0bXV8RpGPuHmCelQ8=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=eCfuNNwEQ1VUHryxG7ZWTWUDaMUqkXxUaTqhk6Nu6rNdX4aMn4sN9hQ+Qxy4NN/ef z24kZykfZGwyKt1S4x+SXlW9n+OTkt9089Z/efdsAjXiPctOyTPgWb+jhIz/Ug+USr DdIJteM6Zt5/SLjmPh/828AL1iIDVXC42VhAISD8= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 35C433858C2F for ; Fri, 23 Jun 2023 08:27:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 35C433858C2F Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 7037D21B9D for ; Fri, 23 Jun 2023 08:27:04 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 5D4AB1331F for ; Fri, 23 Jun 2023 08:27:04 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id XIScFVhXlWQRTQAAMHmgww (envelope-from ) for ; Fri, 23 Jun 2023 08:27:04 +0000 Date: Fri, 23 Jun 2023 10:27:04 +0200 (CEST) To: gcc-patches@gcc.gnu.org Subject: [PATCH 2/6] Fix TYPE_PRECISION use in hashable_expr_equal_p MIME-Version: 1.0 Message-Id: <20230623082704.5D4AB1331F@imap2.suse-dmz.suse.de> X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Biener via Gcc-patches From: Richard Biener Reply-To: Richard Biener Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769481320068363823?= X-GMAIL-MSGID: =?utf-8?q?1769481320068363823?= While the checks look unnecessary they probably are quick and thus done early. The following avoids using TYPE_PRECISION on VECTOR_TYPEs by making the code match the comment which talks about precision and signedness. An alternative would be to only retain the ERROR_MARK and TYPE_MODE checks or use TYPE_PRECISION_RAW (but I like that least). Bootstrap and regtest ongoing on x86_64-unknown-linux-gnu, OK? * tree-ssa-scopedtables.cc (hashable_expr_equal_p): Use element_precision. --- gcc/tree-ssa-scopedtables.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/tree-ssa-scopedtables.cc b/gcc/tree-ssa-scopedtables.cc index 528ddf2a2ab..e698ef97343 100644 --- a/gcc/tree-ssa-scopedtables.cc +++ b/gcc/tree-ssa-scopedtables.cc @@ -574,7 +574,7 @@ hashable_expr_equal_p (const struct hashable_expr *expr0, && (TREE_CODE (type0) == ERROR_MARK || TREE_CODE (type1) == ERROR_MARK || TYPE_UNSIGNED (type0) != TYPE_UNSIGNED (type1) - || TYPE_PRECISION (type0) != TYPE_PRECISION (type1) + || element_precision (type0) != element_precision (type1) || TYPE_MODE (type0) != TYPE_MODE (type1))) return false;