From patchwork Fri Jun 23 08:26:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 111977 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp5616929vqr; Fri, 23 Jun 2023 01:27:39 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5RuYJQvMjypL6xFWWwx8GMcG/fq12w7nsR1kOmXxr20nJ/WysrjwQQL7fgg2SXNWMNVDSu X-Received: by 2002:a17:907:805:b0:989:450:e57d with SMTP id wv5-20020a170907080500b009890450e57dmr9049740ejb.73.1687508859271; Fri, 23 Jun 2023 01:27:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687508859; cv=none; d=google.com; s=arc-20160816; b=KBvc5wcPCMAWH4VhMoJwbGe85qaH3UNVGtm+LyWjjU5aKFvYLBlHwNH2dpwvgt/XG/ htUQDo9fy09BA6OEAazm3cD6CpR5YkH40V8hV0eaH1Zs71GYFX0tJEdYkleRo7qHj9rn 6mvLFRJ4sKHxI46QI6Q/nCv3R3iRlPQhKE/eyESlNskgPApExhQUsEK7NJW+Lxqgw6t/ WBcwFAOznrKLdNvsCcckne6Kp/pkyEGUcssR8wa8cfKOGjXE/tFt+/WM+HNZ91Q/uZ+2 A8WLt/WF/PLEbiTrULyfhRDAvKqoSLMdXGqgDj9/oRP2PTNwKDm0hhoQDeqaoUvAgPsJ 7XHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:message-id :mime-version:subject:cc:to:date:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=tVRVzH0imIlN0zOre0iPmouIYcfhc/vNpp/4FDE/YDY=; b=WC3wRdJWMXEED0moP/FP3ktqiBrjub57XmGaoDzN8djFi8/gcDQMHYN7OsIaoyx5/W iG3gOCk9zpXMLqSZaskygsk7o/umM7F8PPDMTR/twmXxyZbjSJQqFlqoK3ktGTvSizX3 BkL1OyqYTejm/aUvXp+6TK9GISI/QQZF9xyGDplIUKB6h8FzwIXQA5c4Juf8BvNIMPnC uPiqpbd/GLgF8LQZ/w7a8pVhNx231JbkeNLmVMOHA47BTmXHN9znAYB4iUJIEGdNb+zy 37VCm4AY0q6txAJVXi02C9Es6bY88wYfI8Es75uBQq6CSoI2DdDtesF8TsVrTWmNJ1Nq JwjA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b="NE1l/11T"; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id m24-20020a1709062ad800b00987312f6d80si1341940eje.378.2023.06.23.01.27.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jun 2023 01:27:39 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b="NE1l/11T"; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 575FB385770D for ; Fri, 23 Jun 2023 08:27:29 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 575FB385770D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1687508849; bh=tVRVzH0imIlN0zOre0iPmouIYcfhc/vNpp/4FDE/YDY=; h=Date:To:cc:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=NE1l/11TJXZCgszjpA/wRbxDp7X1+3VdTx7Wvy3BgvbrczExZHW3z4gIQGFzZBBVl fqYC2w7+aEmkztDIAOJukvavSGDiPgkBEPBYEFTqAQkPYxjv9eAbfkGrNK8fcnTDUN tQJOCosdziFiY5oVpSAv8U/HePqwFDW6cJk5wftA= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id E1E793858288 for ; Fri, 23 Jun 2023 08:26:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E1E793858288 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 21A6721B98; Fri, 23 Jun 2023 08:26:42 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 0811A1331F; Fri, 23 Jun 2023 08:26:42 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id Cx3EAEJXlWT3TAAAMHmgww (envelope-from ); Fri, 23 Jun 2023 08:26:42 +0000 Date: Fri, 23 Jun 2023 10:26:41 +0200 (CEST) To: gcc-patches@gcc.gnu.org cc: polacek@redhat.com Subject: [PATCH 1/6] Avoid shorten_binary_op on VECTOR_TYPE MIME-Version: 1.0 Message-Id: <20230623082642.0811A1331F@imap2.suse-dmz.suse.de> X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Biener via Gcc-patches From: Richard Biener Reply-To: Richard Biener Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769481289267596369?= X-GMAIL-MSGID: =?utf-8?q?1769481289267596369?= When we disallow TYPE_PRECISION on VECTOR_TYPEs it shows that shorten_binary_op performs some checks on that that are likely harmless in the end. The following bails out early for VECTOR_TYPE operations to avoid those questionable checks. Bootstrap and regtest ongoing on x86_64-unknown-linux-gnu. OK? gcc/c-family/ * c-common.cc (shorten_binary_op): Exit early for VECTOR_TYPE operations. --- gcc/c-family/c-common.cc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/gcc/c-family/c-common.cc b/gcc/c-family/c-common.cc index 9c8eed5442a..34566a342bd 100644 --- a/gcc/c-family/c-common.cc +++ b/gcc/c-family/c-common.cc @@ -1338,6 +1338,10 @@ shorten_binary_op (tree result_type, tree op0, tree op1, bool bitwise) int uns; tree type; + /* Do not shorten vector operations. */ + if (VECTOR_TYPE_P (result_type)) + return result_type; + /* Cast OP0 and OP1 to RESULT_TYPE. Doing so prevents excessive narrowing when we call get_narrower below. For example, suppose that OP0 is of unsigned int extended