From patchwork Fri Jun 23 08:11:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 111966 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp5610998vqr; Fri, 23 Jun 2023 01:12:27 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7Gq9/Sqv1gROR10zLxzeaHG7whaX0uUcLOv/ynatrVMHYHbyQ2S51HX2oVnNRxIUzDUp96 X-Received: by 2002:a05:651c:407:b0:2b5:974f:385 with SMTP id 7-20020a05651c040700b002b5974f0385mr1106964lja.9.1687507946880; Fri, 23 Jun 2023 01:12:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687507946; cv=none; d=google.com; s=arc-20160816; b=jx4wyIHeMaKyTt96i3bdsoAB61IB5cuFs6W1OlG8X5PPXfdq/MAjPmjBK8X1/q45dq WU+JNOqvKfNIcPs26WQZQ68mYzuPlXeJfNn0WJfCU59MxujGqCUNznsqusUQu0QoIWvz aYxx3HzCHa3Zl6pqtWGmqBPeYa1J6VX511jAu643fRb4dN4Pq+leEbBYTVIK54SRVEWo qvxIpbt1rVf7k8HWLXXB5w5gF1TyYNtbIE+Bm0bxAQtMJtVQUXOZ5GTce9KEKbRor1U6 FkiuaEMhGPJ2fHRMc3g1AuzMgc8T9Kd/mrU2NZgmoQNH+w/nPIvSRqWYHxb0u+8LUsEj +hXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:message-id :mime-version:subject:to:date:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=zwXgjppa3pxnhAnyGLIpIV4PUdss9i1DNv/DsEm/tfc=; b=kuOBqZNhdI8Hvt/wZ1tv5PbGc+ZpS+PauhmQ0lAwrEHFYwXItQDb9c5jfa3686uX1q DNsQqHku8io9vkxApf6YMFo+0M+LRrMso4mH6eEgis/7ttdidjG/djjbz4z0gBMC05+z XJIk5Qu3jjUmAXu8fTa/vN/WLImhhiH1ER2hi1//e9R9eg/pzMm5pkiN2wfq5Kxu5H2J funEY+0z8sO7jkR999JENEofBfPpdhguh/ZRBoDAXTz41S4tmyZMvxAuaD/W4LxwQWkK ag2y1M00rnGvGvzIKQoR/KUGx8oK/2uK8NzSiY+cx5lB7Ic//XE7xaG5L8Xt3Irv+KjV wAcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=Si3YjyLY; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id ay27-20020a056402203b00b0051bef676b34si881231edb.393.2023.06.23.01.12.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jun 2023 01:12:26 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=Si3YjyLY; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C50D63858C2B for ; Fri, 23 Jun 2023 08:12:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C50D63858C2B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1687507945; bh=zwXgjppa3pxnhAnyGLIpIV4PUdss9i1DNv/DsEm/tfc=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=Si3YjyLYFsic8PqJ+5rH/YSgrFGx1UwPdQFCtZmexfsdud64z7qKHCUD2Tq2+xmB9 vJKnIt/oPw5Rqa5dUD/z6eDtXoHulOajHaJPpb2AUAJiFjUT7m9+iMvL0dGbkUxywB IwGxZJyvvCfbDwM9ZgoLLTtMyxj8jMYoWeReL1v8= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 593F33858425 for ; Fri, 23 Jun 2023 08:11:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 593F33858425 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 686531F45A for ; Fri, 23 Jun 2023 08:11:38 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 552D21331F for ; Fri, 23 Jun 2023 08:11:38 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id NRE6E7pTlWRaRwAAMHmgww (envelope-from ) for ; Fri, 23 Jun 2023 08:11:38 +0000 Date: Fri, 23 Jun 2023 10:11:37 +0200 (CEST) To: gcc-patches@gcc.gnu.org Subject: [PATCH] Optimize vector codegen for invariant loads, fix SLP support MIME-Version: 1.0 Message-Id: <20230623081138.552D21331F@imap2.suse-dmz.suse.de> X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Biener via Gcc-patches From: Richard Biener Reply-To: Richard Biener Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769480332744798032?= X-GMAIL-MSGID: =?utf-8?q?1769480332744798032?= The following avoids creating duplicate stmts for invariant loads which was necessary when the vector stmts were in a linked list. It also fixes SLP support which didn't correctly create the appropriate number of copies. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. * tree-vect-stmts.cc (vectorizable_load): Avoid useless copies of VMAT_INVARIANT vectorized stmts, fix SLP support. --- gcc/tree-vect-stmts.cc | 39 +++++++++++++++++++-------------------- 1 file changed, 19 insertions(+), 20 deletions(-) diff --git a/gcc/tree-vect-stmts.cc b/gcc/tree-vect-stmts.cc index 1b160cecfce..b1b08238dc3 100644 --- a/gcc/tree-vect-stmts.cc +++ b/gcc/tree-vect-stmts.cc @@ -9612,27 +9612,26 @@ vectorizable_load (vec_info *vinfo, gimple_set_vuse (new_stmt, vuse); gsi_insert_on_edge_immediate (pe, new_stmt); } - /* These copies are all equivalent, but currently the representation - requires a separate STMT_VINFO_VEC_STMT for each one. */ - gimple_stmt_iterator gsi2 = *gsi; - gsi_next (&gsi2); - for (j = 0; j < ncopies; j++) + /* These copies are all equivalent. */ + if (hoist_p) + new_temp = vect_init_vector (vinfo, stmt_info, scalar_dest, + vectype, NULL); + else { - if (hoist_p) - new_temp = vect_init_vector (vinfo, stmt_info, scalar_dest, - vectype, NULL); - else - new_temp = vect_init_vector (vinfo, stmt_info, scalar_dest, - vectype, &gsi2); - gimple *new_stmt = SSA_NAME_DEF_STMT (new_temp); - if (slp) - SLP_TREE_VEC_STMTS (slp_node).quick_push (new_stmt); - else - { - if (j == 0) - *vec_stmt = new_stmt; - STMT_VINFO_VEC_STMTS (stmt_info).safe_push (new_stmt); - } + gimple_stmt_iterator gsi2 = *gsi; + gsi_next (&gsi2); + new_temp = vect_init_vector (vinfo, stmt_info, scalar_dest, + vectype, &gsi2); + } + gimple *new_stmt = SSA_NAME_DEF_STMT (new_temp); + if (slp) + for (j = 0; j < (int) SLP_TREE_NUMBER_OF_VEC_STMTS (slp_node); ++j) + SLP_TREE_VEC_STMTS (slp_node).quick_push (new_stmt); + else + { + for (j = 0; j < ncopies; ++j) + STMT_VINFO_VEC_STMTS (stmt_info).safe_push (new_stmt); + *vec_stmt = new_stmt; } return true; }