From patchwork Thu Jun 1 10:37:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Wakely X-Patchwork-Id: 101874 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp205084vqr; Thu, 1 Jun 2023 03:38:38 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ44Le8tmUMWeZWtVWq9nW7Vj8A3Q3k8TE2m1WKdgR0SBV0LCSjgOqNOs2xUhNfZShoNTZTm X-Received: by 2002:aa7:d695:0:b0:514:9bb7:d0bd with SMTP id d21-20020aa7d695000000b005149bb7d0bdmr5820377edr.24.1685615918063; Thu, 01 Jun 2023 03:38:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685615918; cv=none; d=google.com; s=arc-20160816; b=BnMyu5dDsW+aZD7Ix1/Fo7yz0fyPzbCMbxgY72EqMRy6xNaQhsjMjD4a/iR7cb5ioz IAqKjcd3/Bj1WuQUkYcn8J9zoObOue8jNqvW8X431bMYN3CseUOcvfa/TinKYZW+2YHp MVujag1o06GtO4n1VXejn/Z8KuVaEMS22NM92X7NEqmHD6+oBW1claNCFaF/vrcMhRkt Nu+mSV6lBDOpoZ8jCPtsxTmjmiIvXvdgY3y8m38PFebfvPKtN/FEc/5JolRXiqQ8DWZY fiurrpb32qYk27PHC5HeZ13wZcMx6bkLKk5mxwhtlpazNWgA+huTVo69Qq6l8nr8UX2F bdLg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:message-id:date:subject:to :dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=EuQQ08CsnS8MVoih3Sj+LvArpLJk529cKLGIGfw/Fvc=; b=Zejyaj3PNHS+wVvRpAiPA9gVBxM8KcXe4lmZDxwYBqw8/Nk9Mt39GGdr8lRvYJIWte QutKyJyi4wtj1ikqxfI+P/wxQyJR8RKN5FwY4a5x+oglLEGMthKYnVu0JhCG1Q1IQk+4 RX9q5MV7cIpc00gd3eqChF/nfuEa1AmWxiTCOO30Bj0qM3scvsqDq7sVoVUDQbQU9iw2 br48BBC99goq5ZEPOfU6EGjTdIWTm0Z0ciDMn7GOa2l5chKkIYfHvzs/b0aMzlk6+6B9 dw67dfAJqNtYTqm6nQUZ1ZdmAsduMO7SvHO5CFdMZvwwASrukSf2UFNG1FQWqh1Y/Kwq 4sVQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=YJMSCq19; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id vi7-20020a170907d40700b0096630ee29e0si2753541ejc.151.2023.06.01.03.38.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Jun 2023 03:38:38 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=YJMSCq19; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B5BD53857C4F for ; Thu, 1 Jun 2023 10:38:36 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B5BD53857C4F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1685615916; bh=EuQQ08CsnS8MVoih3Sj+LvArpLJk529cKLGIGfw/Fvc=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=YJMSCq19qkIVfKnmYa+MuJe9makxJOevbyJWFXXVopPTQ2np08slZRzEnhldKDvne Rnkwf0OuZUfNg/FvZQ7UlZwqsxniJ92UYjYjL6/iwBE/lcjQSLC87lfS7K1wq9K1rt 8WFPlr07GwT91VL7BnT1TyoJ3gMS4IMzKvA7Vxdk= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id AA0D93858C41 for ; Thu, 1 Jun 2023 10:37:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AA0D93858C41 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-647-lxt8D5SMPs-JMx67r_osMA-1; Thu, 01 Jun 2023 06:37:39 -0400 X-MC-Unique: lxt8D5SMPs-JMx67r_osMA-1 Received: from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com [10.11.54.10]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D088F38294A0 for ; Thu, 1 Jun 2023 10:37:38 +0000 (UTC) Received: from localhost (unknown [10.42.28.9]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8FABC492B0B for ; Thu, 1 Jun 2023 10:37:38 +0000 (UTC) To: gcc-patches@gcc.gnu.org Subject: [PATCH] doc: Fix description of x86 -m32 option [PR109954] Date: Thu, 1 Jun 2023 11:37:37 +0100 Message-Id: <20230601103737.99717-1-jwakely@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.10 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-12.2 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jonathan Wakely via Gcc-patches From: Jonathan Wakely Reply-To: Jonathan Wakely Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767496396787020590?= X-GMAIL-MSGID: =?utf-8?q?1767496396787020590?= In https://gcc.gnu.org/PR109954 I suggested also adding: "N.B., using @option{-march} might be required to produce code suitable for a specific CPU family, e.g., @option{-march=i486}." I realise that that is true for all of -m32, -m64 and -mx32, and similar rules apply for other targets too. But I still feel that saying it explicitly for -m32 doesn't hurt, and would avoid a common misunderstanding by putting that info somewhere it's more likely to be read. But I'd prefer to just fix the part that is *wrong*, and then we can discuss whether or not that other part is an improvement. This patch fixes the wrongness. OK for trunk and release branches? -- >8 -- This option does not imply -march=i386 so it's incorrect to say it generates code that will run on "any i386 system". gcc/ChangeLog: PR target/109954 * doc/invoke.texi (x86 Options): Fix description of -m32 option. --- gcc/doc/invoke.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/doc/invoke.texi b/gcc/doc/invoke.texi index 898a88ce33e..ec71c2e9e0f 100644 --- a/gcc/doc/invoke.texi +++ b/gcc/doc/invoke.texi @@ -34091,7 +34091,7 @@ on x86-64 processors in 64-bit environments. Generate code for a 16-bit, 32-bit or 64-bit environment. The @option{-m32} option sets @code{int}, @code{long}, and pointer types to 32 bits, and -generates code that runs on any i386 system. +generates code that runs in 32-bit mode. The @option{-m64} option sets @code{int} to 32 bits and @code{long} and pointer types to 64 bits, and generates code for the x86-64 architecture.