From patchwork Tue May 30 18:27:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Faust X-Patchwork-Id: 101064 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2379070vqr; Tue, 30 May 2023 11:28:32 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6cHhfPKIthWYoO9HYoxewZ/zORyg1lE1tgueEparVzoASG1fj8CP671tVVeXjHXGRpxvnW X-Received: by 2002:a2e:9ed3:0:b0:2af:20c9:3f8a with SMTP id h19-20020a2e9ed3000000b002af20c93f8amr1192964ljk.7.1685471312148; Tue, 30 May 2023 11:28:32 -0700 (PDT) Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id be17-20020a0564021a3100b00514a6d05de1si2457550edb.409.2023.05.30.11.28.31 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 May 2023 11:28:32 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=UvzorxzO; arc=fail (signature failed); spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E16B7385843E for ; Tue, 30 May 2023 18:28:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E16B7385843E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1685471296; bh=vNSH2kq+H2fiPVCXLtqEBuolRiGkXrjqpWANZC+CcLA=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=UvzorxzO+m7yFkS/mv8I1FzscpA0Ap1joJp6Cg2EANeM1irN5yC++lh+xaRQGZgFI sSjcYcf9uVs8MkVLuuRQWKtDD7kjPSN0Mmw1+TK9HI3/HbhynfRaKNP4NQ3FiGE24M h4URIQ1ZoDbA3PC6dpYpZmFdzhjuZ1LLvrrKuK7s= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0b-00069f02.pphosted.com (mx0b-00069f02.pphosted.com [205.220.177.32]) by sourceware.org (Postfix) with ESMTPS id 0FAC33858D20 for ; Tue, 30 May 2023 18:27:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0FAC33858D20 Received: from pps.filterd (m0333520.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 34UE45PQ002519 for ; Tue, 30 May 2023 18:27:30 GMT Received: from phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta02.appoci.oracle.com [147.154.114.232]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3qvhd9ujw2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 30 May 2023 18:27:30 +0000 Received: from pps.filterd (phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19) with ESMTP id 34UI6UEH019757 for ; Tue, 30 May 2023 18:27:29 GMT Received: from nam10-mw2-obe.outbound.protection.outlook.com (mail-mw2nam10lp2104.outbound.protection.outlook.com [104.47.55.104]) by phxpaimrmta02.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 3qu8a4hket-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 30 May 2023 18:27:29 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=gwtJYdRxS0srhwzMdANFTIhfqwSjn0P4K6AlnQtmYzBF7Kll6gNurHZN2/giYcW4ncklwqHa2UQ9+GYcmAUd4/u6PIlQcbgTiU6pdxUTrGE2VEqVyTK2tnY2UIELxuB9jLcck99oN6ZUY4+WHTFI6Iuw+TqmpMypph0tDAN+LIRRow5ZlBg7zTOenJPVRj5WAvZRHSsa4cIoVcAvCAOVStxa+regpFaAvJVLcdV4goRt7tnY84noSTmBrCyhaIRW1l5X0D8doPoG8OVj8jO2q8A7lz7CIT9psDolt7L/rCn57jlm9zZYAWsAj8R8pG7xfa6d7ZTw25dzuh0AS/KdrA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vNSH2kq+H2fiPVCXLtqEBuolRiGkXrjqpWANZC+CcLA=; b=dQ6iinaYXuwACmEY/hjKp7qL2n58X//ax+0yZBAC4Em1giU58qZl+gZY1nETboJV/bD1wy/LWW3cN4tV3NeF8q/Iz6kMbLLwc3zr+p9ATf5ATzazr63iAKNztfQklj7ZTAY1D7mI2eshmK5KmGR/YXZQXyVOe2JHCuncc/1/SJ/YPVbA0no9FtSaJld0c9/PyoJjpBHgcnufumhDl/DtkH+CQB+QqyS7Yw8G6RQ/ha+adHeKlFU8S/WPFonDUFFVCvrHukEKu5QODZHp5gUUwbErJwUZZ/BRQIEbFK+duLUxFdG9GQaBv29m5Yx8jxgJ6WCkDN0sTHjLmLCd+GA7XA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none Received: from MN2PR10MB3213.namprd10.prod.outlook.com (2603:10b6:208:131::33) by SN7PR10MB6620.namprd10.prod.outlook.com (2603:10b6:806:2af::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.22; Tue, 30 May 2023 18:27:27 +0000 Received: from MN2PR10MB3213.namprd10.prod.outlook.com ([fe80::6ff6:bf43:d990:858a]) by MN2PR10MB3213.namprd10.prod.outlook.com ([fe80::6ff6:bf43:d990:858a%3]) with mapi id 15.20.6433.022; Tue, 30 May 2023 18:27:27 +0000 To: gcc-patches@gcc.gnu.org Cc: indu.bhagat@oracle.com Subject: [PATCH 1/2] btf: be clear when record size/type is not used Date: Tue, 30 May 2023 11:27:01 -0700 Message-Id: <20230530182702.8020-1-david.faust@oracle.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230525163740.6062-1-david.faust@oracle.com> References: <20230525163740.6062-1-david.faust@oracle.com> X-ClientProxiedBy: BY5PR04CA0016.namprd04.prod.outlook.com (2603:10b6:a03:1d0::26) To MN2PR10MB3213.namprd10.prod.outlook.com (2603:10b6:208:131::33) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN2PR10MB3213:EE_|SN7PR10MB6620:EE_ X-MS-Office365-Filtering-Correlation-Id: 9e55c707-05e9-4240-1a34-08db613b8539 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: QZWIaU5lFZhQjevmh+H9SgvYqu4iAyJtQV3Ny9YEt7uiXA2zVeJfftg0L33Eu54/F0hSuVMMCWXN2kEsTnk22paKsbJMQGWezPzYVtK/YO5qdvcqIgkep1j9RPkuOJ/FVy1HbXt5ARVGAxYLTde3uRwO42XuoDlTc7EjoO9f8VE1PpSsvXcWRHwXwo4OPJM6dYx05To2mjEdzi3fSZ0dIGRdqAsVsWE3MnMYnzQosWdI/TECPQ/71ZNm38tUzXpYSDXLr2LKN/mRYqiC9mhpuCpDeWYs6dzncSOCUwVwxsyYEfvcwHkPLtdeB4NdABbATaYd4/psI6Usp21ouxh1DuKWe9XgpondD1bJeu9kxgRU9gkp4RnDFeB4h3PsRRBBJBIy2077p9WLV8Lcwm1NaRFE9RnYcJ7BzojX5lYSHQMyFbAPJ53poohGzSUeKIwmmO1jOosC1k1UeSGy7aEHbzJjPRnjw+UewGIaOo/9myybdC7WqQF33bRWuUf4W5Tf4ReXN3+H0nED4uWGDmh+Fr4fRpSe7yOu5up8WpmfAsSYPEYGOGBCfAxStQ8knEAJ X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:MN2PR10MB3213.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(136003)(39860400002)(396003)(366004)(346002)(376002)(451199021)(6512007)(6506007)(186003)(2616005)(2906002)(26005)(478600001)(1076003)(44832011)(83380400001)(86362001)(8936002)(8676002)(6486002)(41300700001)(38100700002)(66556008)(316002)(6666004)(66476007)(36756003)(66946007)(5660300002)(107886003)(6916009)(4326008); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 2DYQUomg3t0oj5gNOhyEj/TwZnoAcG/eJxLQ2T2Ef02eGsFX99WwQ5Yd4qjDaMrJ058JACmtXGEcOaXv9sNOB99AZ7teSQVgXBrkW4hN+dkjObruWzNAt+6kOw5lGyQ3gWis03BcLtlqF6TmpKu6V1ZGSNArrKelV0LGy9r/7vx88AymxXNT3QN3hzCKm250tKT3S7AqcUElsKrnsQtBtrOfpcUtPlpbkoY33fQM8CjaSk/PgGffQ6ROZp/q8/tw/ir7AmcJkZtkpZ0XX6P4C2XtmXez23DNiHSrwQKaryWRMgy21rmV9mvAs3FBV+fl+XtO4mTUxkgMnUbNaGYX1CGTJb6y1y48dKVlJa+V7v5M6SoBtxVY1t+TphHdvSkDDMFkJg6deF4Cl0eAU5sxKX9CLHjVC0mJ0aHrZz1JV1VAYL4Z9dFFsI5pI2u6+2AjErVu78KoQnivZCP8ihA+77F4F7D7jG8t/xif25Lh4PM/RijCzYY3rGCsrLdtw4Eg1cQLPmWGfkMfjV8i4aiY7yXTO1D2jvWtWsH56Wjb7uSllVu/dz04DM/Nh6tfCN0zLTKsEfuBFCJuDttkmvTD1kfjnaoXPPWlJ5nuEUTYa/w0+6P5bn2ijuLbOp6K4NDoTgC16r1z2C1olGKL8gNCT7O0PoPdzsXwtW2uaA+RdRFQMFBY/GvZlQe2EHI9ldvD+oeImlBu8IC4FFB0v0N1WGH/R0WBaLZU9WY+so9kSKI288eRl6B7fiZ20DSy+HCKu8+vIpmpfkw9rE90aB0iVHC9q6J9JExn6qqZGGxOb6F92wyIB9aGQCotx27yyeQayTf6PfF9AxmE9ujLdldSgl7qXqSvUd/q2PRWb0Nyi3qHIJDB1w3AY7IgBPzvvajIPDaIXPHjm3JtnS6mLYuWvflq4gKGKXFiHysO6nYrYq7Sks+X3OY3zq1H7YH1J0CE4XhSb8DmbYn6WjAJpDOIE9QVtVK+5m+c8Oic9LXZ7rjIQHTt4KUy02T6RUNgmiXH6hEq8qP2EkdNLfSvLLt0zrZ2YY4Cp984k5EEXr/HXO5YqXFQPk3Ld3xY1du0uanmQz1s5nsrD5t+6ez0weZh1c9AbeP9/DKbj2zPvQfS4bqFvxNRVOxM9N0CRXEgjZd2gCCdUK7jyuS0mBFlBv0oMptkTQRFohmYSCTA1/brCF+QkrCHEen/Rn3VnvdyuEL348O+Ij7z7wiC6bou93UkzJOmbreRp0mwFCqkjgADa6ZZl0GolL/hsMWNqbyw0GcyTsDmYKqcgvZEcDmsGMlJrTsuyYNO8luf+eiWn+LUkWT9tI3AGfTxjC8jt1PvAZrlaRF++4X9oJs2CWU14D7iAI/xbFoHmgc7zZ8Unf5KBUQgy+Lm/bIbA2TEAc8UD6Su5J6Hg/oZT5su0xBtm54T/cfLzeRrViT2TuzxiJ+ImmddCR1a3DmQYcfsTOpOSCNxDHWMq/5W5pYdVBg3ptRzoFrhg+SjtfhO1e9YLwYQKXSNIPtP+46NsOUBUqbPBsHRN272wywHDAuNseCn/GS86/+nXCvPdbevfIxRob0WdcrORbmSJyqNhtRNbe7gaaU0 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: BS96X5ohociugLrW0OSlU2aPrg5lHRnUFGzujbIEnD46TmameFpBLPY8URbGKwwwMBNJhtqoq5weT0gROFU5T7QuzGYkdozB5UVQ1OLkRliPZ6OujbHQgJ9MU4N6DAdSilz4y65QIK2JwPHDuU+3Ucyu5C6JSYjLKXRCbAW+8qDDJUJ0LajW+c8Vfe5582azeoscixQLdkgeflANZY1mC6ieriw3STc/l+aRJLeghapjCrYsY2yYZGul2kf8AjpQ5q2zGXAek0RYazaBHkkBpGeyEWV3DSCsKVgdzmB9XNinVIq2kjkBgGnqrMxVAfDFHUlKTkx1kdAcIxXtQWSFJDlEuZWDSxYSfBXKja8lQrShGtCSwIrHLXJfUu6FU+trZp9jZHQP6UC/cshPSFjtOpqZQZK/sxlymHNGHLp2buZQWxVja++gwooL1Q1A5HWfjanWypcEP6GtwocG0nMYAuGOP4hgHGipoO/H4FKxbKDPUtz/QJz1nSjUNAIeQ/RLR012GpvYccMHpiFRUQY/4UhRF2BjrAyoZxbUwAfM10RVpCseZh2XNE3r/8fc9mrRE/Rqgs5AZRQ2o9GbHRg9LyS5tUVS0LbRx/dLMxJVorCmKEnhPeCtkcvYTBTsX8dIJ9bx2toy2E1Y8bGRFcoW7jrUcXpAATKceVURIggqNPIYwToQ1rFR7pWRzHiuxQqibtQAEqovtJs6cbYFGSnYJi9HnRYSiiJ844bJj7o+Lr60K241HnPXNGBy/VBN/nJC X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9e55c707-05e9-4240-1a34-08db613b8539 X-MS-Exchange-CrossTenant-AuthSource: MN2PR10MB3213.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2023 18:27:27.1716 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TJZ5NRIbMHX+/kHZhfKIwbynruTfGMR9kf7p6lcFsS8MZ8ITvKRY9zFQCZ5I9I2Kb4ovdi9hiQtSIwNlwe+W5Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR10MB6620 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.573,FMLib:17.11.176.26 definitions=2023-05-30_14,2023-05-30_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 malwarescore=0 phishscore=0 bulkscore=0 adultscore=0 mlxscore=0 suspectscore=0 mlxlogscore=998 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2304280000 definitions=main-2305300147 X-Proofpoint-GUID: Nb81qlfIVg-EKadlFjWSWdefRX_-T2Zw X-Proofpoint-ORIG-GUID: Nb81qlfIVg-EKadlFjWSWdefRX_-T2Zw X-Spam-Status: No, score=-13.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: David Faust via Gcc-patches From: David Faust Reply-To: David Faust Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767344766672201074?= X-GMAIL-MSGID: =?utf-8?q?1767344766672201074?= [Changes from v1: split this change into own commit.] All BTF type records have a 4-byte field used to encode a size or link to another type, depending on the type kind. But BTF_KIND_ARRAY and BTF_KIND_FWD do not use this field at all, and should write zero. GCC already correctly writes zero in this field for these type kinds, but the process is not straightforward and results in the -dA comment claiming the field is a reference to another type. This patch makes the behavior explicit and updates the assembler comment to state clearly that the field is unused. gcc/ * btfout.cc (btf_asm_type): Add dedicated cases for BTF_KIND_ARRAY and BTF_KIND_FWD which do not use the size/type field at all. --- gcc/btfout.cc | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/gcc/btfout.cc b/gcc/btfout.cc index 497c1ca06e6..ae9855716eb 100644 --- a/gcc/btfout.cc +++ b/gcc/btfout.cc @@ -705,6 +705,12 @@ btf_asm_type (ctf_container_ref ctfc, ctf_dtdef_ref dtd) dw2_asm_output_data (4, dtd->dtd_data.ctti_size, "btt_size: %uB", dtd->dtd_data.ctti_size); return; + case BTF_KIND_ARRAY: + case BTF_KIND_FWD: + /* These types do not encode any information in the size/type field + and should write 0. */ + dw2_asm_output_data (4, 0, "(unused)"); + return; default: break; }