diff mbox series

[COMMITTED] ada: Remove unnecessary call to Detach.

Message ID 20230523080842.1874165-1-poulhies@adacore.com
State Accepted
Headers
Series [COMMITTED] ada: Remove unnecessary call to Detach. |

Checks

Context Check Description
snail/gcc-patch-check success Github commit url

Commit Message

Marc Poulhiès May 23, 2023, 8:08 a.m. UTC 
  From: Vadim Godunko <godunko@adacore.com>

Holder object is constant and protected from modification by tampering
rules.

gcc/ada/

	* libgnat/a-coinho__shared.adb (Constant_Reference): Remove call
	of Detach
	(Query_Element): Likewise.

Tested on x86_64-pc-linux-gnu, committed on master.

---
 gcc/ada/libgnat/a-coinho__shared.adb | 4 ----
 1 file changed, 4 deletions(-)
diff mbox series

Patch

diff --git a/gcc/ada/libgnat/a-coinho__shared.adb b/gcc/ada/libgnat/a-coinho__shared.adb
index 367089048af..f49ac4ad817 100644
--- a/gcc/ada/libgnat/a-coinho__shared.adb
+++ b/gcc/ada/libgnat/a-coinho__shared.adb
@@ -149,8 +149,6 @@  package body Ada.Containers.Indefinite_Holders is
          raise Constraint_Error with "container is empty";
       end if;
 
-      Detach (Container);
-
       declare
          Ref : constant Constant_Reference_Type :=
                  (Element => Container.Reference.Element.all'Access,
@@ -305,8 +303,6 @@  package body Ada.Containers.Indefinite_Holders is
          raise Constraint_Error with "container is empty";
       end if;
 
-      Detach (Container);
-
       B := B + 1;
 
       begin