From patchwork Tue May 23 08:08:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Marc_Poulhi=C3=A8s?= X-Patchwork-Id: 97894 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1982416vqo; Tue, 23 May 2023 01:32:13 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ55T4ls/oQ4kgHXwToLH5XWqb0PSyWfcOj7H3uxVyV/oxWbohDl9WgXHa/G7qjGBQUBwihc X-Received: by 2002:a17:906:58d2:b0:96f:e79c:d441 with SMTP id e18-20020a17090658d200b0096fe79cd441mr5407312ejs.57.1684830732952; Tue, 23 May 2023 01:32:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684830732; cv=none; d=google.com; s=arc-20160816; b=aQOIApmzrv214Gh9LV8XIRtFPm9KccS7mXJXYziwvsNOItV0+smMsi6zvBvYoEjmVu bccMQX5XuPU1/sHI1imYTDFRTRkDqno0SNIIDIzu19eu/WKeBezCYtxPlJZf1EK0E2aj IJcj+ly4nvryys6vUGsl/FaaW49NiYou5aKWL3ir6L0IuuDz9v+HnCDjKoxzTZoo5D/I wq8zPppxDNnzKzH6WPVvKq8koygZeOkRQp8dQogKZJle/oKRiHnJDED4EdFrHAXkG6YY kFW3iG7pFJrpev03574ONu8irJpCuaAqOZiCiuhnGibNKO12yE67jbEEQEGVGzXpgM+x ztzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:message-id:date:subject:cc :to:dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=rue3NxJ2+CbO+2ZewV6uo54zBRLUK42k5A2z1R26NS0=; b=cqquiPhiqU/AI5CVQ2IT03lv5Lp3s8OI6Bz9cTyPPZbnnZIt7FedzUIylN5h9Kgu+f Uq0I4HLK+9Rcd68/eCWxNE6YvohHNCVBNGgv5bbMZ4LDELs0jfbUqp5wPubGugsGZdPx loxk49VV97EJcXQyzVJuR5DWXVLZg/pFDgWox4cayE5bMex8WjIK36nnH/2rtECfVQw/ eGpcAhxDKqaOWOmAwuqy1y/PkIRXC0quChZOPi1NB6X96if+mZOGw2akiJ8FLU1o3TfX DA55amJT2w3WRQMXDf9HZsPNDR2mPBHf0Lwd06HdFLLU5p7e3PSvKaP/AyTIaCbz6f3M 2QZw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=iWxwduWN; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id qk9-20020a170906d9c900b0096f70608f91si5188205ejb.149.2023.05.23.01.32.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 May 2023 01:32:12 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=iWxwduWN; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F34373894C17 for ; Tue, 23 May 2023 08:20:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F34373894C17 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1684830048; bh=rue3NxJ2+CbO+2ZewV6uo54zBRLUK42k5A2z1R26NS0=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=iWxwduWNqtbzCyaEARnHq3A8Qv4opWoC+B6rMpGtHsMDaFRfZUUH/LwveQp3GJ7j4 60DV9PnvutyeqXJ+1UZfF6l9RuhsEO6LBDh1uBmr2trNV5GjC0ukodp8qnE0CgH3nT MZHgSdvaWdjzii4W4hcJtWcsVbs29edEONtdOHP8= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by sourceware.org (Postfix) with ESMTPS id CB0F03858C2B for ; Tue, 23 May 2023 08:08:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CB0F03858C2B Received: by mail-wm1-x331.google.com with SMTP id 5b1f17b1804b1-3f6042d60b5so21226835e9.2 for ; Tue, 23 May 2023 01:08:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684829315; x=1687421315; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rue3NxJ2+CbO+2ZewV6uo54zBRLUK42k5A2z1R26NS0=; b=jZESxKs+AU0XFAq2q/C8SLTR0517s9p69ih6hMVbXjdaWQdhQQeFZLCGrhpfAIvpqb w8UF71K3GYFB+s9X9s0B+ie0MqRhWJhnf79f805WJeYaChGgK2DkTFoKNYxV9YTzxUX+ Y0ZEYCC5W75sfy+MGa78zUrsRcMBFzqs1hKcKDd0YaTiyOYuOvVPXuI7mSb969yK2eb+ z5FUdA8pAkRETUYmDXcr2eIlu7wgXojlM9gGfUVjpuha8lI6h7u3KOXPpZJrMQajlUTg 62uLt+YDsSgoYpd7fzOqujFofy5qr3Kd4j9DxTT8HyvJ9Ta45HZ84OqWVA8x2o6wtCAn 9k/w== X-Gm-Message-State: AC+VfDwSCUYyQgxlH0P/jsXLqLpwcZs7bTaZq0vyqm7ewUj5uJVG5O9r BGsoU68vNNzroVE18bEQn/NzNpqANAhtkCWrSAfB2Q== X-Received: by 2002:adf:fd07:0:b0:309:3b27:9baa with SMTP id e7-20020adffd07000000b003093b279baamr9716540wrr.52.1684829315684; Tue, 23 May 2023 01:08:35 -0700 (PDT) Received: from poulhies-Precision-5550.telnowedge.local (lmontsouris-659-1-24-67.w81-250.abo.wanadoo.fr. [81.250.175.67]) by smtp.gmail.com with ESMTPSA id r14-20020adfce8e000000b00306c5900c10sm10309456wrn.9.2023.05.23.01.08.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 May 2023 01:08:35 -0700 (PDT) To: gcc-patches@gcc.gnu.org Cc: Steve Baird Subject: [COMMITTED] ada: A discriminant of a variable is not a variable Date: Tue, 23 May 2023 10:08:34 +0200 Message-Id: <20230523080834.1873919-1-poulhies@adacore.com> X-Mailer: git-send-email 2.40.0 MIME-Version: 1.0 X-Spam-Status: No, score=-13.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: =?utf-8?q?Marc_Poulhi=C3=A8s_via_Gcc-patches?= From: =?utf-8?q?Marc_Poulhi=C3=A8s?= Reply-To: =?utf-8?q?Marc_Poulhi=C3=A8s?= Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766673070633700374?= X-GMAIL-MSGID: =?utf-8?q?1766673070633700374?= From: Steve Baird gcc/ada/ * sem_util.adb (Is_Variable): Correctly return False for a selected component name of the form Some_Object.Some_Discriminant, even if Some_Object is a variable. We don't want to allow such a name as an actual parameter in a call if the corresponding formal parameter's mode is not "in". Tested on x86_64-pc-linux-gnu, committed on master. --- gcc/ada/sem_util.adb | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/gcc/ada/sem_util.adb b/gcc/ada/sem_util.adb index baf4cefdfb3..7e302897888 100644 --- a/gcc/ada/sem_util.adb +++ b/gcc/ada/sem_util.adb @@ -21196,11 +21196,8 @@ package body Sem_Util is return Is_Variable_Prefix (Prefix (Orig_Node)); when N_Selected_Component => - return (Is_Variable (Selector_Name (Orig_Node)) - and then Is_Variable_Prefix (Prefix (Orig_Node))) - or else - (Nkind (N) = N_Expanded_Name - and then Scope (Entity (N)) = Entity (Prefix (N))); + return Is_Variable (Selector_Name (Orig_Node)) + and then Is_Variable_Prefix (Prefix (Orig_Node)); -- For an explicit dereference, the type of the prefix cannot -- be an access to constant or an access to subprogram.