[COMMITTED] ada: A discriminant of a variable is not a variable

Message ID 20230523080834.1873919-1-poulhies@adacore.com
State Accepted
Headers
Series [COMMITTED] ada: A discriminant of a variable is not a variable |

Checks

Context Check Description
snail/gcc-patch-check success Github commit url

Commit Message

Marc Poulhiès May 23, 2023, 8:08 a.m. UTC
  From: Steve Baird <baird@adacore.com>

gcc/ada/

	* sem_util.adb
	(Is_Variable): Correctly return False for a selected component
	name of the form Some_Object.Some_Discriminant, even if
	Some_Object is a variable. We don't want to allow such a name as
	an actual parameter in a call if the corresponding formal
	parameter's mode is not "in".

Tested on x86_64-pc-linux-gnu, committed on master.

---
 gcc/ada/sem_util.adb | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)
  

Patch

diff --git a/gcc/ada/sem_util.adb b/gcc/ada/sem_util.adb
index baf4cefdfb3..7e302897888 100644
--- a/gcc/ada/sem_util.adb
+++ b/gcc/ada/sem_util.adb
@@ -21196,11 +21196,8 @@  package body Sem_Util is
                return Is_Variable_Prefix (Prefix (Orig_Node));
 
             when N_Selected_Component =>
-               return (Is_Variable (Selector_Name (Orig_Node))
-                        and then Is_Variable_Prefix (Prefix (Orig_Node)))
-                 or else
-                   (Nkind (N) = N_Expanded_Name
-                     and then Scope (Entity (N)) = Entity (Prefix (N)));
+               return Is_Variable (Selector_Name (Orig_Node))
+                       and then Is_Variable_Prefix (Prefix (Orig_Node));
 
             --  For an explicit dereference, the type of the prefix cannot
             --  be an access to constant or an access to subprogram.