From patchwork Thu May 18 12:56:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Wakely X-Patchwork-Id: 95856 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp470674vqo; Thu, 18 May 2023 05:59:38 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7Cg6J+MS06ivH4QoHQ91P39MbhJPJGj5Ao1RS/NQaty5ZHS1qpQiioh07Bg7nKJN781KYq X-Received: by 2002:a17:906:9b88:b0:96a:8a7f:4aa5 with SMTP id dd8-20020a1709069b8800b0096a8a7f4aa5mr26587908ejc.18.1684414778304; Thu, 18 May 2023 05:59:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1684414778; cv=none; d=google.com; s=arc-20160816; b=DogyLrdC3PPUARoDiz9AvuxsAr5yWKub7N3cNy13riRD7ovOHkAucX6WWrR32jRfr8 2Tg+7hxw162bJ49Q49sA12osBwx6UT3pe6Kc6O3aH/dpUSu9fz0kq7zl9ClGf1RdlakL NBcFNOxYAuR6NSKAsDE+BViFX0Yy7rjMVvZFs6z2nHUuhzXgBPgo6eIxqYx8L1df7Yee yxuL4j5nBf8meGwGohFVy0l+qz+q3GeovcWuJKiFekPVE5sLw4azAgcKAmJBfmT6mebu kIBPqJ/U3ZWPep7x0VCoILnnqUuPmw3JyLf7NX92pV9ZqlChI6px3AHAfJjzdqutv9Hm Mwzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:to:dmarc-filter:delivered-to:dkim-signature :dkim-filter; bh=c32aHhoNhDUZEBw/3QnwBVxbozePgAT2pxEyet4e1u8=; b=B/R7IEdE5c3un1G1d+2x1jUIs68AEBlJi36SUMeWml5zcYKjtchFvmNTgZ7+KrSojR Tq52M58EFBGyLq53b5+1z2NnRtN5bsQ7A9Eq5K4l2/py2uVFNGkwsX+wUGEVUG+4hRlP MyJ3V6sMqqwbcxj63ORLrBZ/4JXz7x85cxusNj7AVWsgaS+5riZ9MYc6+rqmZ9lIu9vX m2D7C2gDqAthp9DL4cQQXIQmJSbxDTVSX6mvieUP2xIXxb2IT8OXdauGA86I4J1sekaN WqPunOyMuxYiBvLWKaWeF+NaEPF59/4yMUiu5Oc1D3e4mZO5AK87hM7p2a5s+GilNPgy C9ow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=S7KZyc2v; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id f15-20020a056402160f00b0050bc115779esi931702edv.647.2023.05.18.05.59.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 May 2023 05:59:38 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=S7KZyc2v; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1720A3846444 for ; Thu, 18 May 2023 12:58:40 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1720A3846444 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1684414720; bh=c32aHhoNhDUZEBw/3QnwBVxbozePgAT2pxEyet4e1u8=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=S7KZyc2vtrCH4jNzFDyykT2E4J0l+pHuLSr9qntmtkzdLHWxm/fpYb8BL16Tq9D8r aikyt8Sda9dJsdDr6qCWatt1fLANnvlBQoFi4GFTVShOThZ9OtqjNH34vdueko/br3 DovZgJZU27hpwTcPjPWWOS+iGhkJtlmzZvt7m/98= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 7C3683858434 for ; Thu, 18 May 2023 12:56:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7C3683858434 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-98-ZA7R9IfDNx6jPL1o6VF3Ew-1; Thu, 18 May 2023 08:56:55 -0400 X-MC-Unique: ZA7R9IfDNx6jPL1o6VF3Ew-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C131B80269A for ; Thu, 18 May 2023 12:56:54 +0000 (UTC) Received: from localhost (unknown [10.42.28.213]) by smtp.corp.redhat.com (Postfix) with ESMTP id 632871415304 for ; Thu, 18 May 2023 12:56:54 +0000 (UTC) To: gcc-patches@gcc.gnu.org Subject: [PATCH 3/3] contrib: Fix nonportable shell syntax in "test" and "[" commands [PR105831] Date: Thu, 18 May 2023 13:56:47 +0100 Message-Id: <20230518125647.2105203-4-jwakely@redhat.com> In-Reply-To: <20230518125647.2105203-1-jwakely@redhat.com> References: <20230518125647.2105203-1-jwakely@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jonathan Wakely via Gcc-patches From: Jonathan Wakely Reply-To: Jonathan Wakely Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1766236910633583651?= X-GMAIL-MSGID: =?utf-8?q?1766236910633583651?= POSIX sh does not support the == for string comparisons, use = instead. These contrib scripts all use a bash shebang so == does work, but there's no reason they can't just use the more portable form anyway. PR bootstrap/105831 contrib/ChangeLog: * bench-stringop: Use = operator instead of ==. * repro_fail: Likewise. contrib/reghunt/ChangeLog: * bin/reg-hunt: Use = operator instead of ==. --- contrib/bench-stringop | 4 ++-- contrib/reghunt/bin/reg-hunt | 2 +- contrib/repro_fail | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/contrib/bench-stringop b/contrib/bench-stringop index daf1bce6e6f..f058e066b3a 100755 --- a/contrib/bench-stringop +++ b/contrib/bench-stringop @@ -87,7 +87,7 @@ test "$2" "$3" "-mstringop-strategy=rep_byte -malign-stringops" rep1 test "$2" "$3" "-mstringop-strategy=rep_byte -mno-align-stringops" rep1noalign test "$2" "$3" "-mstringop-strategy=rep_4byte -malign-stringops" rep4 test "$2" "$3" "-mstringop-strategy=rep_4byte -mno-align-stringops" rep4noalign -if [ "$mode" == 64 ] +if [ "$mode" = 64 ] then test "$2" "$3" "-mstringop-strategy=rep_8byte -malign-stringops" rep8 test "$2" "$3" "-mstringop-strategy=rep_8byte -mno-align-stringops" rep8noalign @@ -109,7 +109,7 @@ echo " $best" test_all_sizes() { -if [ "$mode" == 64 ] +if [ "$mode" = 64 ] then echo " block size libcall rep1 noalg rep4 noalg rep8 noalg loop noalg unrl noalg sse noalg byte PGO dynamic BEST" else diff --git a/contrib/reghunt/bin/reg-hunt b/contrib/reghunt/bin/reg-hunt index 6427535dabe..aff4e9005b5 100755 --- a/contrib/reghunt/bin/reg-hunt +++ b/contrib/reghunt/bin/reg-hunt @@ -142,7 +142,7 @@ process_patch () { # build failures, quit now. if [ ${SKIP} -eq 0 ]; then - if [ "x${REG_NEWMID}" == "x" \ + if [ "x${REG_NEWMID}" = "x" \ -o ${TEST_ID} -eq ${LATER_THAN} \ -o ${TEST_ID} -eq ${EARLIER_THAN} ]; then error "build failed for ${TEST_ID}" diff --git a/contrib/repro_fail b/contrib/repro_fail index 9ea79f2bccf..abb479d08aa 100755 --- a/contrib/repro_fail +++ b/contrib/repro_fail @@ -42,10 +42,10 @@ if [ $# -lt 2 ] ; then exit 1 fi -if [ "$1" == "--debug" ] ; then +if [ "$1" = "--debug" ] ; then debug_args="-wrapper gdb,--args" shift -elif [ "$1" == "--debug-tui" ] ; then +elif [ "$1" = "--debug-tui" ] ; then debug_args="-wrapper gdb,--tui,--args" shift else