[COMMITTED] ada: Add Check_Error_Detected before "raise Bad_Attribute"

Message ID 20230515094254.1407902-1-poulhies@adacore.com
State Accepted
Headers
Series [COMMITTED] ada: Add Check_Error_Detected before "raise Bad_Attribute" |

Checks

Context Check Description
snail/gcc-patch-check success Github commit url

Commit Message

Marc Poulhiès May 15, 2023, 9:42 a.m. UTC
  From: Bob Duff <duff@adacore.com>

We shouldn't raise Bad_Attribute if there is no error.
This patch adds a call to Check_Error_Detected to make sure that's true.
(There are other cases where we raise Bad_Attribute;
this patch doesn't try to fix them all.)

gcc/ada/

	* sem_attr.adb
	(Analyze_Attribute): Add a call to Check_Error_Detected.

Tested on x86_64-pc-linux-gnu, committed on master.

---
 gcc/ada/sem_attr.adb | 1 +
 1 file changed, 1 insertion(+)
  

Patch

diff --git a/gcc/ada/sem_attr.adb b/gcc/ada/sem_attr.adb
index 77c56aa587b..9de9884069e 100644
--- a/gcc/ada/sem_attr.adb
+++ b/gcc/ada/sem_attr.adb
@@ -3299,6 +3299,7 @@  package body Sem_Attr is
             --  Check for missing/bad expression (result of previous error)
 
             if No (E1) or else Etype (E1) = Any_Type then
+               Check_Error_Detected;
                raise Bad_Attribute;
             end if;
          end if;