From patchwork Fri Apr 14 09:45:24 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 83315 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp253021vqo; Fri, 14 Apr 2023 02:46:17 -0700 (PDT) X-Google-Smtp-Source: AKy350ZcAN2gofLFsk4ys6DHqaxXh5BLiAX2bN52MQlaTHmruQcfRkzCBqkWfvJQ2UPAKHPJ71UL X-Received: by 2002:a05:6402:3514:b0:506:775a:6bec with SMTP id b20-20020a056402351400b00506775a6becmr3198952edd.20.1681465577063; Fri, 14 Apr 2023 02:46:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681465577; cv=none; d=google.com; s=arc-20160816; b=D/2ozROIH+FZhuDzv+kw2NuNFvhkHJr7Ze7chnNd4n2fcwVf+NS/2Hvp9zw4GFHS97 VjY0Njz2mGENxEkt15iMnUf2t/2b/5bXe42HERT53+0tB0DO3hBY5Ys0yqWDYLOBfUEE DfRlhYGc7hD8iABnTJhVvBT+eylUw243pQEDFr35HCEGxQRdBMwbF5bF3wJrSkuUQeg7 PHYJ3eOxcueVvrUALKQSf/ip8BOlZYr1nAsx9zm79yzdpGlFDTyB9MB3U0NTsZ5alTOt EtZ5+bduOvkHyZ6tI2VzosVPG/lKrjKUcI5AYj0G7vSia/alT42Kp35kepCM08ecbVgg JtJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:message-id :mime-version:subject:to:date:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=W3j1+lMYc/GCK8JZJX7X2NlA4lpKZKjzWXQo2uAikuY=; b=c+MNkmnc6i4mA78ikenfki3Mdx2S61vJFoUz6yXimd6YmOnXAkRV5UxvWUXKeLcvH9 JRQ2w7Vf8FdvYPsDkkr18U97viwdAqGwW7nfYple5wiZqNjbQ+o9pnV7TgMjUSpEb0ND BQ8+JrGLvG3c1csa12vyGIjaIeP0BKjW5qcd6oV+2GA7zvpU2SYep4iNH7uUFr0uRMOw KNGWDAM42FZCBni3ieLB3BZYB6mwMrEMAwB+UsJxoBSlHqm4dR5U5+rbA21fFV2F4rE2 VvUlNaASh0U+R33mwH9Nab0a8urIqzTAV7AjSxmNqvw91Uon74W9fIkGjuyOIv204+bl 3DWg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=NkFkMyac; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id e22-20020a056402089600b005067c1fdb13si2346897edy.641.2023.04.14.02.46.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 14 Apr 2023 02:46:17 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=NkFkMyac; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A8F793858422 for ; Fri, 14 Apr 2023 09:46:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A8F793858422 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1681465572; bh=W3j1+lMYc/GCK8JZJX7X2NlA4lpKZKjzWXQo2uAikuY=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=NkFkMyacMTfEz3NlSMrCuGUO4iO3b34sT/VWd8+p9GW4ql5xDmE3pauJUSstUg8Xr gyYo4WVlOJYRHf1bTa6OjOEOQs3wWiZEPujErZenjB0h/6OQnQv/fax4Wg0HjcXd6i Sb6uKYZ/gbVw7EBmLYS7QPNK5O4v4xUh5v5EbHqQ= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id 17DE33858D20 for ; Fri, 14 Apr 2023 09:45:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 17DE33858D20 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 298361FD95 for ; Fri, 14 Apr 2023 09:45:25 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 1645E13498 for ; Fri, 14 Apr 2023 09:45:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ouchBLUgOWSFEgAAMHmgww (envelope-from ) for ; Fri, 14 Apr 2023 09:45:25 +0000 Date: Fri, 14 Apr 2023 11:45:24 +0200 (CEST) To: gcc-patches@gcc.gnu.org Subject: [PATCH] tree-optimization/109502 - vector conversion between mask and non-mask MIME-Version: 1.0 Message-Id: <20230414094525.1645E13498@imap2.suse-dmz.suse.de> X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Biener via Gcc-patches From: Richard Biener Reply-To: Richard Biener Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1763144449298466930?= X-GMAIL-MSGID: =?utf-8?q?1763144449298466930?= The following fixes a check that should have rejected vectorizing a conversion between a mask and non-mask type. Those should be done via pattern statements. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed. PR tree-optimization/109502 * tree-vect-stmts.cc (vectorizable_assignment): Fix check for conversion between mask and non-mask types. * gcc.dg/vect/pr109502.c: New testcase. --- gcc/testsuite/gcc.dg/vect/pr109502.c | 21 +++++++++++++++++++++ gcc/tree-vect-stmts.cc | 3 +-- 2 files changed, 22 insertions(+), 2 deletions(-) create mode 100644 gcc/testsuite/gcc.dg/vect/pr109502.c diff --git a/gcc/testsuite/gcc.dg/vect/pr109502.c b/gcc/testsuite/gcc.dg/vect/pr109502.c new file mode 100644 index 00000000000..970c63e931b --- /dev/null +++ b/gcc/testsuite/gcc.dg/vect/pr109502.c @@ -0,0 +1,21 @@ +/* { dg-do run } */ +/* { dg-additional-options "-O" } */ + +unsigned g; + +unsigned +foo (void) +{ + unsigned a = !g; + a += !(a % 6); + return a; +} + +int +main () +{ + unsigned x = foo (); + if (x != 1) + __builtin_abort (); + return 0; +} diff --git a/gcc/tree-vect-stmts.cc b/gcc/tree-vect-stmts.cc index efa2d0daa52..6b7dbfd4a23 100644 --- a/gcc/tree-vect-stmts.cc +++ b/gcc/tree-vect-stmts.cc @@ -5595,8 +5595,7 @@ vectorizable_assignment (vec_info *vinfo, GET_MODE_SIZE (TYPE_MODE (vectype_in))))) return false; - if (VECTOR_BOOLEAN_TYPE_P (vectype) - && !VECTOR_BOOLEAN_TYPE_P (vectype_in)) + if (VECTOR_BOOLEAN_TYPE_P (vectype) != VECTOR_BOOLEAN_TYPE_P (vectype_in)) { if (dump_enabled_p ()) dump_printf_loc (MSG_MISSED_OPTIMIZATION, vect_location,