From patchwork Wed Apr 12 06:08:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiufu Guo X-Patchwork-Id: 82268 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp97109vqo; Tue, 11 Apr 2023 23:09:40 -0700 (PDT) X-Google-Smtp-Source: AKy350ZVcAdbuMPtG2Zq+Bx4SclszaPliwQHo3MS+zdnqYnnbLYZ0TnUrSNUZOiNUBM9SP5SsScX X-Received: by 2002:aa7:c957:0:b0:502:25ac:c72a with SMTP id h23-20020aa7c957000000b0050225acc72amr1080766edt.1.1681279779921; Tue, 11 Apr 2023 23:09:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1681279779; cv=none; d=google.com; s=arc-20160816; b=dS81JooF9LS/0Cy/ARL8Wmqjrz5Wi0nPhzEZYEVaqY2KRFgW6yd6wNMh/aJuCUUHXI h6rSHn/peFT+3R21TM5eQKMzPr+SHFG6MjoeP3SDCcmekl3GYvR4oXXXqjoQo59tdqOv OmiFz+wVGfitQlRNedYXWEganu3RIUTMFctiX0IzuDVcvUsgWgge41IVhgmjBRnXvQ/a 7aVvhO9+iAzt8pQbMvO9VrKHbk0zHOVINLKkw4ekQR86Z9fhSZ/dchJ60gmz/7E8D39L WwJWVa/ix6jXpiQYmogWqJ9XdWd/eaj8jP0onQf6djMdYY9PMDQTtI7QOda4NOIhWwel 5gKA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:message-id:date:subject:cc :to:dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=vDr8l1M77CNUw5VKhZ0XSqvZLkNnNjcFGq+1nvbHfD8=; b=g8ckrgxut6HlQyRhf2hOKa06FyqbWl24AXU6NuSG5XeZ0s8i0OV2sO3vXKAO0auvIN R+3uY0jSOLER3BPp7gYj2ush9rLrG0OFz3APRmGou/QfNZq2TG9znkfb8AjsE1XHJMoz cx9kHpBASyqyZDKmDxvBhY5LS+oVeCP9xCD+JgzzwZbKD3Qig8CQgPhPRDXEozBrIgsN r9YP6ou3G+uFCrcK7W+ALnoic7Pe4rSABcK1Y37tNhK135T0RhwjQUrFU32Z6a3XDVth QSdC2TvkygYNckZ638/Fbmf7HMJWTtwyoSJ5vKoabEsyADh42MUaGR5ty0aUwn65zije 9TDA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=eIQVemoU; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id l8-20020a056402124800b0050291c9456fsi67945edw.383.2023.04.11.23.09.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Apr 2023 23:09:39 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=eIQVemoU; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3EAC43858409 for ; Wed, 12 Apr 2023 06:09:38 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3EAC43858409 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1681279778; bh=vDr8l1M77CNUw5VKhZ0XSqvZLkNnNjcFGq+1nvbHfD8=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=eIQVemoUrEwQrbEAuka20dZwaL/giJk/FoDrgrHqGNEzSgWv6bY7SKI6QdAdTBOVO +26Evf4Fzo/CnEPhtfo+N0vHUE63fLECkIfPFrnIz4qDwMn/ZGWlaEOzgaulyWF7lM fJ4NpyxI2fwqdfxk3rhftpl8movUPh5Gv7+GVYYg= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 4F6953858D28; Wed, 12 Apr 2023 06:08:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 4F6953858D28 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33C4EBrD024292; Wed, 12 Apr 2023 06:08:53 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3pwneeu75c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 12 Apr 2023 06:08:53 +0000 Received: from m0098419.ppops.net (m0098419.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 33C4HVem007404; Wed, 12 Apr 2023 06:08:53 GMT Received: from ppma06ams.nl.ibm.com (66.31.33a9.ip4.static.sl-reverse.com [169.51.49.102]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3pwneeu74m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 12 Apr 2023 06:08:52 +0000 Received: from pps.filterd (ppma06ams.nl.ibm.com [127.0.0.1]) by ppma06ams.nl.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 33C0kmv5028714; Wed, 12 Apr 2023 06:08:51 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma06ams.nl.ibm.com (PPS) with ESMTPS id 3pu0m2257x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 12 Apr 2023 06:08:50 +0000 Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 33C68luk22151786 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 12 Apr 2023 06:08:47 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 5D7D620049; Wed, 12 Apr 2023 06:08:47 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 408AB20040; Wed, 12 Apr 2023 06:08:46 +0000 (GMT) Received: from ltcden2-lp1.aus.stglabs.ibm.com (unknown [9.3.90.43]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 12 Apr 2023 06:08:46 +0000 (GMT) To: gcc-patches@gcc.gnu.org Cc: segher@kernel.crashing.org, dje.gcc@gmail.com, linkw@gcc.gnu.org, guojiufu@linux.ibm.com, meissner@linux.ibm.com Subject: [PATCH] testsuite: filter out warning noise for CWE-1341 test Date: Wed, 12 Apr 2023 14:08:45 +0800 Message-Id: <20230412060845.981953-1-guojiufu@linux.ibm.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-GUID: Pueqtt81NO_Yy7fCT-wV8gtsV9PHz5FX X-Proofpoint-ORIG-GUID: AXO-JPTmEHDwzBasPuh_k_dsMpkTEmeU X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-12_01,2023-04-11_02,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 mlxlogscore=999 malwarescore=0 suspectscore=0 mlxscore=0 priorityscore=1501 clxscore=1015 lowpriorityscore=0 spamscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2303200000 definitions=main-2304120054 X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Jiufu Guo via Gcc-patches From: Jiufu Guo Reply-To: Jiufu Guo Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762949626542015477?= X-GMAIL-MSGID: =?utf-8?q?1762949626542015477?= Hi, The case file-CWE-1341-example.c checkes [CWE-1341](`double-fclose`). While on some systems, besides [CWE-1341], a message of [CWE-415] is also reported. On those systems, attribute `malloc` may be attached on fopen: ``` # 258 "/usr/include/stdio.h" 3 4 extern FILE *fopen (const char *__restrict __filename, const char *__restrict __modes) __attribute__ ((__malloc__)) __attribute__ ((__malloc__ (fclose, 1))) ; or say: __attribute_malloc__ __attr_dealloc_fclose __wur; ``` It would be ok to suppress other message except CWE-1341 for this case. This patch add -Wno-analyzer-double-free to make this case pass on those systems. Tested on ppc64 both BE and LE. Is this ok for trunk? BR, Jeff (Jiufu) gcc/testsuite/ChangeLog: PR target/108722 * gcc.dg/analyzer/file-CWE-1341-example.c: Update. --- gcc/testsuite/gcc.dg/analyzer/file-CWE-1341-example.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gcc/testsuite/gcc.dg/analyzer/file-CWE-1341-example.c b/gcc/testsuite/gcc.dg/analyzer/file-CWE-1341-example.c index 2add3cb109b..830cb0376ea 100644 --- a/gcc/testsuite/gcc.dg/analyzer/file-CWE-1341-example.c +++ b/gcc/testsuite/gcc.dg/analyzer/file-CWE-1341-example.c @@ -19,6 +19,9 @@ IN NO EVENT SHALL THE CONTRIBUTOR, THE ORGANIZATION HE/SHE REPRESENTS OR IS SPONSORED BY (IF ANY), THE MITRE CORPORATION, ITS BOARD OF TRUSTEES, OFFICERS, AGENTS, AND EMPLOYEES BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE INFORMATION OR THE USE OR OTHER DEALINGS IN THE CWE. */ +/* This case checks double-fclose only, suppress other warning. */ +/* { dg-additional-options -Wno-analyzer-double-free } */ + #include #include #include