diff mbox series

[v5] gcc: Drop obsolete INCLUDE_PTHREAD_H

Message ID 20230402213345.632989-1-sam@gentoo.org
State Accepted
Headers
Series [v5] gcc: Drop obsolete INCLUDE_PTHREAD_H |

Checks

Context Check Description
snail/gcc-patch-check success Github commit url

Commit Message

Sam James April 2, 2023, 9:33 p.m. UTC 
  INCLUDE_PTHREAD_H was added for r13-1350-g49d508065bdd36 for a calloc poisoning
issue like r13-6662-g0e6f87835ccabf.

When working on r13-6662-g0e6f87835ccabf, we realised that INCLUDE_PTHREAD_H
became unused as of r13-4164-g0a62889c7a155f (which was originally added
for r13-1350-g49d508065bdd36 for a similar musl issue).

I originally tried to use INCLUDE_PTHREAD_H in r13-6662-g0e6f87835ccabf even though
it was the wrong solution, so let's drop it given it's both:
1. now obsolete;
2. a bit confusing.

Nothing is using this to guard inclusion of pthread.h and it only ever had
one consumer in the tree which is now gone.

gcc/ChangeLog:
	* system.h: Drop unused INCLUDE_PTHREAD_H.

Thanks-to: Andrew Pinski <pinskia@gmail.com>
Signed-off-by: Sam James <sam@gentoo.org>
---
 gcc/system.h | 4 ----
 1 file changed, 4 deletions(-)

Comments

Jeff Law April 18, 2023, 7:28 p.m. UTC | #1 
On 4/2/23 15:33, Sam James wrote:
> gcc/ChangeLog:
> 	* system.h: Drop unused INCLUDE_PTHREAD_H.
THanks.  I've pushed this to the trunk.
jeff
Sam James April 19, 2023, 2:18 a.m. UTC | #2 
Jeff Law <jeffreyalaw@gmail.com> writes:

> On 4/2/23 15:33, Sam James wrote:
>> gcc/ChangeLog:
>> 	* system.h: Drop unused INCLUDE_PTHREAD_H.
> THanks.  I've pushed this to the trunk.

Cheers Jeff!

> jeff

best,
sam
diff mbox series

Patch

diff --git a/gcc/system.h b/gcc/system.h
index cf45db3f97e..3fdad7abf1e 100644
--- a/gcc/system.h
+++ b/gcc/system.h
@@ -761,10 +761,6 @@  extern int vsnprintf (char *, size_t, const char *, va_list);
 #endif
 #endif
 
-#ifdef INCLUDE_PTHREAD_H
-#include <pthread.h>
-#endif
-
 #ifdef INCLUDE_ISL
 #ifdef HAVE_isl
 #include <isl/options.h>