From patchwork Tue Mar 28 01:32:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans-Peter Nilsson X-Patchwork-Id: 75758 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1902815vqo; Mon, 27 Mar 2023 18:32:45 -0700 (PDT) X-Google-Smtp-Source: AKy350ZLHToFNvTZ4Xk6jSQup5JVqNSFWHmWUCLhG9JFhRfHQD9hWiB9bMVi76E0nwAVLMYI3lxx X-Received: by 2002:a05:6402:20d:b0:4fa:c17d:8fdd with SMTP id t13-20020a056402020d00b004fac17d8fddmr12728335edv.34.1679967165731; Mon, 27 Mar 2023 18:32:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679967165; cv=none; d=google.com; s=arc-20160816; b=zHY3P2M/DC/uwzHpz/DfiLrZWHsw72yk0F8bQf2YNCpV8wnp0Oj+f7UJm42uIC932D V60zZoPvfP4hukB0u0kjGOIrkGro6QlqZ2coZ4dzixf4UAJ5h7D4/pD66V0E+7Fpaon9 p/5unPs3ALVPtPFIwLq66vroMHal5aiYJMam/fURRtp8RzTjaODURcExIyFv4MuosMYR bsE4SPOBQpNMqttlkUcANTa6Nfid7VGZHM9JcHWhN9k4RuO67+Sp15BVHsL/peEsIE08 63vwa5p0xG+fwN3qiAI7lR8Nr8p8w7rcl7gUvtaICHeigCAbCYPwqTH4+JyNRnPDK8X5 Fapg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:date:message-id :content-transfer-encoding:mime-version:subject:to:dmarc-filter :delivered-to:dkim-signature:dkim-filter; bh=E2A7cRCwCZBHr4EYSPeMpWVDJVYaQv1Nu7Gq9aHMkJI=; b=GWkAPEhfZCAkyMenJufUVpI7nmjXSkaLZYy02Rp7Omsf97vj8//nS0nPqECRPk16Us Iu2zObYVjUhIzYY9tI6iGxTzuVVpwncd3dYG1q4ztko+oR/v6sRdmXQl3b+l2nrKBFQV M/ohjGdwpiV4CUdCxHLe96AmZbD7RfKy2/wmW5UX65Kau3GVnuMsK2axX2FaoOhMGyxN uM+CprPy27rUcN7q6e3nUvwn3QrpOJuDxY4tPxqjSxcS3tfGfcvzMe3wbWl2B58l6vXG OwVXzmqv3bIve5z676rcDhALcLNxZedoC7l2jfkVgZlIB5opJ0CMEYZoL9MzFkdx1/Si BXaA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=EsLDISf1; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id f5-20020a056402160500b004a0db601db8si30854815edv.619.2023.03.27.18.32.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Mar 2023 18:32:45 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=EsLDISf1; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A11703858298 for ; Tue, 28 Mar 2023 01:32:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A11703858298 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1679967164; bh=E2A7cRCwCZBHr4EYSPeMpWVDJVYaQv1Nu7Gq9aHMkJI=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=EsLDISf1vfVamUE8tgDf5c6By0BTey3nSsetvxbSlD5S2xZLC1SfqyxjgWImFeqWz j6qsa5sQgbzYfoDA+PAG2YP4zrjsfKhLnQNh6X7u3jJ91i8OIZl6XDTMplOaFzpZdj SUb+9te2DBRHYp678h4RVGFWCpW/tPSPZa2vZ5tk= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp1.axis.com (smtp1.axis.com [195.60.68.17]) by sourceware.org (Postfix) with ESMTPS id AEFAE3858D39 for ; Tue, 28 Mar 2023 01:32:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AEFAE3858D39 To: Subject: [committed] CRIS: Correct "T" to define_memory_constraint, not define_constraint MIME-Version: 1.0 Message-ID: <20230328013200.52DA220417@pchp3.se.axis.com> Date: Tue, 28 Mar 2023 03:32:00 +0200 X-Spam-Status: No, score=-11.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Hans-Peter Nilsson via Gcc-patches From: Hans-Peter Nilsson Reply-To: Hans-Peter Nilsson Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1761573250564511105?= X-GMAIL-MSGID: =?utf-8?q?1761573250564511105?= This patch has no effect on builds using reload of libgcc, newlib libc, my own at-a-glance-testsuite and coremark. That somewhat surprisingly also goes for LRA builds, even with all CRIS reload_in_progress augmented to include lra_in_progress. I just noticed it when checking because another port had a similar fix, where it mattered for LRA. * config/cris/constraints.md ("T"): Correct to define_memory_constraint. --- gcc/config/cris/constraints.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/config/cris/constraints.md b/gcc/config/cris/constraints.md index 5efb61364f46..fa9aa19d13e3 100644 --- a/gcc/config/cris/constraints.md +++ b/gcc/config/cris/constraints.md @@ -100,7 +100,7 @@ (define_memory_constraint "Q" || reload_completed)"))) ;; Extra constraints. -(define_constraint "T" +(define_memory_constraint "T" "Memory three-address operand." ;; All are indirect-memory: (and (match_code "mem")