From patchwork Sat Mar 18 08:04:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stafford Horne X-Patchwork-Id: 71563 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:604a:0:0:0:0:0 with SMTP id j10csp181440wrt; Sat, 18 Mar 2023 01:05:10 -0700 (PDT) X-Google-Smtp-Source: AK7set98OvV9JfS4E0YfjgZLxeGQAZWR65MjM+qZA6t5+FtIsIuKPn7NCUx+IfTP4KvV1X/vT7vK X-Received: by 2002:a17:906:4948:b0:931:fdf0:7eee with SMTP id f8-20020a170906494800b00931fdf07eeemr1897644ejt.56.1679126710877; Sat, 18 Mar 2023 01:05:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1679126710; cv=none; d=google.com; s=arc-20160816; b=C+uGbAzcnBKnK7YcJ/n1+QaURSNgK7dIrJA55Seaep1duTfiuD1SN0flPEmAzdTIfb f3Y6DhE393l48nnfohFk5hR6WEIKFnE0tNUsTMBz3SBOY2e7/5weglKAsI34MEcYooKP 0SkR7H0akk8KnBJApUmHdfCoiWlsSK4xpjGYVx5Xx8K/uRB0dncd2arba2LE3xQkPMu9 DtpxdpmnIoglTVrLajTUlIjgyBFK2jY2NMLQ7aK9nRli0NJsy1IihKzsinZ5vKxCYX1a jIWUEcK5fDJaDjMpzrV9OCgzZAwc6rvZ68kelMB3cIj0nmbOCn3spMteszOzEZoEdoHx LeTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:message-id:date:subject:cc :to:dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=mqj3eoizRLYpARgkZdhtFQjWuK9djeyoVu1xTCjA+0Q=; b=SJAzDoWIVjd+RRm/2jEh5kTB1rN4n6Y48qxz9goYT+lXau+2HM2GrgTlNJgCmEPenU Bjv9E54kAec05rdYg67LTxGAsRt+Pzj80dX6njRve+oTUvC2ENEPsaaNy05tu9jf0dn9 pNhs8Cu/ajw79xa8QIKHw36wW2JQ9RiMtrHFv+nlfzfQ44iVvDzsYTEF91oqg0yUz4qj uiNbbbvQ3JU5KDiYkmMqaXGqp57qUiNxflA6Yy6hdfEKKp1A+IttiHJhy8rDrWLRiyDI 3NVFHoB7oB795wdVvwMW+PUP6o89P/vUhDcPgTGfHDbqFKYI/3+VdKk4DldADSveTbZa N0Aw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=ayNmlTp0; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id l11-20020a170906794b00b00933436da044si43923ejo.137.2023.03.18.01.05.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Mar 2023 01:05:10 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=ayNmlTp0; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AA69A3858C54 for ; Sat, 18 Mar 2023 08:05:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AA69A3858C54 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1679126709; bh=mqj3eoizRLYpARgkZdhtFQjWuK9djeyoVu1xTCjA+0Q=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=ayNmlTp0i5evdcoxiOq3z6jg/fSwlGeid8BL4nOieJBHk6gYheCJ1atxWzUpWJpC4 DDhrFV9Pa2eSFoIIMo153x/NXHVgEYxGPhb/IXMymIuYuFgjZZc8mi5eaj/d2UsSV3 TfM1I1OScLeEs5s+H/K/zm2V9rJXZimigh48/wUI= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id 0B1473858C50 for ; Sat, 18 Mar 2023 08:04:25 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0B1473858C50 Received: by mail-wm1-x333.google.com with SMTP id bg16-20020a05600c3c9000b003eb34e21bdfso6327553wmb.0 for ; Sat, 18 Mar 2023 01:04:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679126662; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=mqj3eoizRLYpARgkZdhtFQjWuK9djeyoVu1xTCjA+0Q=; b=Pj+DWX3054aUsVi1pYA83VDUvcWtLgNBBc9GAaTgvaujMBZdDtN0tcty7Wb211liaE Zvmc0HdfILoJ50J9EG/5d2HizhoBW07wUOH3K9slQ9sRdobReU+nkRB14mQw8rwyY+om 4FnR90zO5Vw7uBDGsPhNYiWE2lqzwd/4KD2rB5lJkT4AJMTtNHYPl5qBlcj5cpydL36B T2MSKzUA2JrFNzGCYXNwRotMXnvO7uAVvPC3d3UB3zc4CPqNxn3bYykDGr54Qe+aw8aN LMlrQdg5ncbL6poLbtrWhs0w+Ssmafm0G2/kD9bBkq5bS/HcTHOTRr8kO4Ebpo+B4dfy eoQQ== X-Gm-Message-State: AO0yUKWsyGyEoqErB4LH8TtE5UaS3hhr+ZrN9tvg857eQLDPFV/ykcph mvxXHrXyK8K2fMXfoWUlowOWvXtFECk= X-Received: by 2002:a05:600c:4452:b0:3e1:374:8b66 with SMTP id v18-20020a05600c445200b003e103748b66mr26263510wmn.40.1679126662338; Sat, 18 Mar 2023 01:04:22 -0700 (PDT) Received: from localhost (cpc1-brnt4-2-0-cust862.4-2.cable.virginm.net. [86.9.131.95]) by smtp.gmail.com with ESMTPSA id az40-20020a05600c602800b003e2096da239sm10245677wmb.7.2023.03.18.01.04.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Mar 2023 01:04:21 -0700 (PDT) To: GCC patches Cc: Linux OpenRISC , Stafford Horne Subject: [PATCH] or1k: Do not clear existing FPU exceptions before updating Date: Sat, 18 Mar 2023 17:04:05 +0900 Message-Id: <20230318080405.2799610-1-shorne@gmail.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 X-Spam-Status: No, score=-11.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Stafford Horne via Gcc-patches From: Stafford Horne Reply-To: Stafford Horne Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760691969944570492?= X-GMAIL-MSGID: =?utf-8?q?1760691969944570492?= We should always carry the exceptions forward. This bug was found when working on testing glibc math tests, many tests were failing with Overflow and Underflow flags not set. This was traced to here. libgcc/ChangeLog: * config/or1k/sfp-machine.h (FP_HANDLE_EXCEPTIONS): Remove statement clearing existing exceptions. --- libgcc/config/or1k/sfp-machine.h | 1 - 1 file changed, 1 deletion(-) diff --git a/libgcc/config/or1k/sfp-machine.h b/libgcc/config/or1k/sfp-machine.h index 162c6bc5326..c804270fb3c 100644 --- a/libgcc/config/or1k/sfp-machine.h +++ b/libgcc/config/or1k/sfp-machine.h @@ -73,7 +73,6 @@ do { \ do { \ if (__builtin_expect (_fex, 0)) \ { \ - _fpcsr &= ~FP_EX_ALL; \ _fpcsr |= _fex; \ __asm__ volatile ("l.mtspr r0,%0,20" : : "r" (_fpcsr)); \ } \