From patchwork Mon Mar 13 19:00:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Malcolm X-Patchwork-Id: 69050 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:5915:0:0:0:0:0 with SMTP id v21csp1353361wrd; Mon, 13 Mar 2023 12:02:23 -0700 (PDT) X-Google-Smtp-Source: AK7set9TFbyJy0pcvnLZBXuVh2TG3iAx8naBMuV85H/MPph78a5+iKGjYlAo8JUefHeozPBySAJ7 X-Received: by 2002:a17:906:a1c5:b0:906:3373:cfe9 with SMTP id bx5-20020a170906a1c500b009063373cfe9mr33742488ejb.10.1678734143797; Mon, 13 Mar 2023 12:02:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1678734143; cv=none; d=google.com; s=arc-20160816; b=civ7Jyp9mQQTG7XziWttAIMKRcseJzONhyHpb8CIoMxwU02ueXWQgNASKeauWJrpig spEKVn7Gv6WSXClfyIFOHASlPjjKLLt/XcWUOx8P6lBtfh6k8nsVLSuy03bf/PaxCT3o sRHaDs12wCrMBWqi8qvM/DEpNdU/n6hMizhlTq1XWW81H4xSEUuUBtaG6b+k3LW3V8g/ c87DNY4Cjpf3vytwZ2i+sLvK400Vf6LStv15tCfuUdg2SYeVTt+0p4cEY8vkINS82lwA hW0/VWexs5ASHjhKInmAI6hgFrKzaKmvJHbWu8+lRKD+sHlypxwWqIo8TVMowpX1PD9f 85xg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:message-id:date:subject:cc :to:dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=ERSzTHXxGb0pjZHssuu7yIJi9fiQpvM9l2BrB3Rgkl4=; b=ZcoW+xSaKdoWIGIasjGFm81CBIK021vhaIu1tX0A2PHIeZp14WOfYLw3JStNYEs9qo mtrhL3vuEieS2m69jzo4jx25Ll1Q+iyCcYo1PJ1ZkFoZ6bKdaDWlNIca/oWW4cst8FQs XPtA7IGg2fw8DMdr75bXEv6W92bxLhl5keNn5YZSWPEGJ0jLSoiNodS55mc4YLrOV2BD RieyCYVCanN70RIlu0jYUp5CFbofQ1FPaQREOmj7vaQwVwkvwtpuPzzkji+WhSrOKe4x n9zkrsAEdWJIfFtrcICRbCUv4O/EDz6whvw0RNnQPNpNHpEiTjz7Nypk6dMLGtwziFIU 18hA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=Ra8eE0On; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id f10-20020a056402150a00b004cdc92cc412si294262edw.69.2023.03.13.12.02.23 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Mar 2023 12:02:23 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=Ra8eE0On; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D5B3B3858C00 for ; Mon, 13 Mar 2023 19:02:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D5B3B3858C00 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1678734142; bh=ERSzTHXxGb0pjZHssuu7yIJi9fiQpvM9l2BrB3Rgkl4=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=Ra8eE0OndDA8/UtT2fx9JGV5EWRFk9RJQ3qR0/DJ18Kgam5aATJx+oiy2kcGaDBAf C2KQy0lja/ETHE7Z/rv882iMQw6h+6nPD2KYmm6ZnKCCTyK3bbIcIFOVR6wEYrB3GN Rv8q6iyoaCS9rd4l1dMnpnLsgd3OfpWho5c1F6VU= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id D082B3858C27 for ; Mon, 13 Mar 2023 19:00:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D082B3858C27 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-423-oi6qr7krNQKqqB0OudOsqQ-1; Mon, 13 Mar 2023 15:00:37 -0400 X-MC-Unique: oi6qr7krNQKqqB0OudOsqQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id C8F8985A588 for ; Mon, 13 Mar 2023 19:00:36 +0000 (UTC) Received: from t14s.localdomain.com (unknown [10.2.17.70]) by smtp.corp.redhat.com (Postfix) with ESMTP id A53691410F1C; Mon, 13 Mar 2023 19:00:36 +0000 (UTC) To: gcc-patches@gcc.gnu.org Cc: David Malcolm Subject: [pushed] testsuite: add test coverage for analyzer leak false +ve [PR105906] Date: Mon, 13 Mar 2023 15:00:35 -0400 Message-Id: <20230313190035.3358567-1-dmalcolm@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: David Malcolm via Gcc-patches From: David Malcolm Reply-To: David Malcolm Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1760280333369023654?= X-GMAIL-MSGID: =?utf-8?q?1760280333369023654?= Adding regression test coverage; I believe I fixed this leak false positive with r13-5113-g688fc162b76dc6. Successfully regrtested on x86_64-pc-linux-gnu. Pushed to trunk as r13-6641-g23532dac3f602d. gcc/testsuite/ChangeLog: PR analyzer/105906 * gcc.dg/analyzer/leak-pr105906.c: New test. Signed-off-by: David Malcolm --- gcc/testsuite/gcc.dg/analyzer/leak-pr105906.c | 32 +++++++++++++++++++ 1 file changed, 32 insertions(+) create mode 100644 gcc/testsuite/gcc.dg/analyzer/leak-pr105906.c diff --git a/gcc/testsuite/gcc.dg/analyzer/leak-pr105906.c b/gcc/testsuite/gcc.dg/analyzer/leak-pr105906.c new file mode 100644 index 00000000000..72901e4d1eb --- /dev/null +++ b/gcc/testsuite/gcc.dg/analyzer/leak-pr105906.c @@ -0,0 +1,32 @@ +/* { dg-additional-options "-Wno-analyzer-too-complex" } */ + +#define NULL ((void *)0) + +#define LEN 64 + +char ** +epystr_explode(const char *delim, char *str) +{ + char **out = NULL; + int i; + + if (str == NULL || delim == NULL) + return NULL; + + out = __builtin_malloc(LEN * sizeof(char *)); + if (out == NULL) + return NULL; + + for (i = 0; i < LEN; i++) { + out[i] = __builtin_strdup("bla"); + if (out[i] == NULL) /* { dg-bogus "leak" } */ + goto freem; + } + return out; + +freem: + while (--i >= 0) + __builtin_free(out[i]); + __builtin_free(out); + return NULL; +}