From patchwork Fri Feb 17 11:38:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 58524 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp836844wrn; Fri, 17 Feb 2023 03:39:47 -0800 (PST) X-Google-Smtp-Source: AK7set/EffX+gRGCXg2EB4LFsGsnwYjNBioKnIWpAK1Mu/uLe1edcRN+pBnSBnlKlWt2KlzoJGRI X-Received: by 2002:a17:907:b609:b0:8b1:79ce:a629 with SMTP id vl9-20020a170907b60900b008b179cea629mr4230761ejc.18.1676633987303; Fri, 17 Feb 2023 03:39:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676633987; cv=none; d=google.com; s=arc-20160816; b=bTlL2CG8Y5QVUDRqeMwI1zFCKlyDSvuun1EVcpdEBfmocHT57cgxKCFfrPj4/hfWz1 Z7q8p8M19yhh8HEW6N1gPDKHquTD89Ph0cgnq5MLb6/75Tb0ZkGKMeFhssB9U5xDLuLC 0cq1XmkIN/f/5z2dYuVKar5FhX1PMLTRKDnAGIKNN4rDvoo3I8R/83Z221py5G3mT08G tMYBqHgDKMmZ2xuFXXPAmty8zKJq7mDL8rzLYu6N7EEBR8stK/OV3TeKpFRo0SIk5OcD Tz8dr+18V0FNOTg82ZlBjGQw+U4fPsDmJlkVC498qnD9/0xEq8g9W55FihqHYQSa6jtt gCfQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:sender:errors-to:reply-to:from:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence :mime-version:user-agent:subject:to:date:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=6Es8A7D9uqF5E24GrabL6QX2okv7P2qifQemHyJA0II=; b=Iu+aLQWclfqGUyyQNjhD+qi01kZE9cF8QqbYKyGzqpAv9Y/SwvZ35uQnLkNFTrEy1q s0HwZLlCi3u/40QimV/2Rbt4zt9jKXsGZKSp8FZOgk2Q4twhSQfyLYEl5TB/0uV6jV9u ypMGB4g4RJ6HRhHBUcDEXN+hzB2wZHkeP4XQRXg+jzHJDvXpr48cjvdwswuY1qgya8Y+ KrA1A3rfS3MX2Yhl4PI5/6rzqwsX2aloLfkG5IOdOo9FsMNwgJEjQQMsF8s7IECx0ZHD nQvJU7vO7qPMZq4WEtMJzs+oexcx7W72+KaMls5JR84mSED/URwe1Yt1qJbFRj8tIp/E /wcQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=Q9vvgPpR; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id 28-20020a170906021c00b008b141471cb3si6156947ejd.1003.2023.02.17.03.39.47 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Feb 2023 03:39:47 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=Q9vvgPpR; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 619E43843854 for ; Fri, 17 Feb 2023 11:39:26 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 619E43843854 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1676633966; bh=6Es8A7D9uqF5E24GrabL6QX2okv7P2qifQemHyJA0II=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=Q9vvgPpRjv5c3xehX/obLBRP68F1uaI3ZTt/Q/eDQNuVBRvxRGb+pZJTBamMgb5+N ZJsndDJq56zkiH7kQY/XHKgGuvtIWGNn6t9BysQOolblE/0+h7TQUrywQRVPknJgSB pcEgaahgT7SqJAtRydL6JzzHYNKJA+FdiE494nCw= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id B54973858C31 for ; Fri, 17 Feb 2023 11:38:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B54973858C31 Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id 774521FE6D for ; Fri, 17 Feb 2023 11:38:42 +0000 (UTC) Received: from wotan.suse.de (wotan.suse.de [10.160.0.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 6D0442C141 for ; Fri, 17 Feb 2023 11:38:42 +0000 (UTC) Date: Fri, 17 Feb 2023 11:38:42 +0000 (UTC) To: gcc-patches@gcc.gnu.org Subject: [PATCH] tree-optimization/108821 - store motion and volatiles User-Agent: Alpine 2.22 (LSU 394 2020-01-19) MIME-Version: 1.0 X-Spam-Status: No, score=-10.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, MISSING_MID, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Biener via Gcc-patches From: Richard Biener Reply-To: Richard Biener Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" Message-Id: <20230217113926.619E43843854@sourceware.org> X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1758078159818323134?= X-GMAIL-MSGID: =?utf-8?q?1758078159818323134?= The following fixes store motion to not re-issue volatile stores to preserve TBAA behavior since that will result in the number of volatile accesses changing. Bootstrapped and tested on x86_64-unknown-linux-gnu, pushed to trunk. PR tree-optimization/108821 * tree-ssa-loop-im.cc (sm_seq_valid_bb): We can also not move volatile accesses. * gcc.dg/tree-ssa/ssa-lim-24.c: New testcase. --- gcc/testsuite/gcc.dg/tree-ssa/ssa-lim-24.c | 25 ++++++++++++++++++++++ gcc/tree-ssa-loop-im.cc | 4 +++- 2 files changed, 28 insertions(+), 1 deletion(-) create mode 100644 gcc/testsuite/gcc.dg/tree-ssa/ssa-lim-24.c diff --git a/gcc/testsuite/gcc.dg/tree-ssa/ssa-lim-24.c b/gcc/testsuite/gcc.dg/tree-ssa/ssa-lim-24.c new file mode 100644 index 00000000000..6b463490a91 --- /dev/null +++ b/gcc/testsuite/gcc.dg/tree-ssa/ssa-lim-24.c @@ -0,0 +1,25 @@ +/* { dg-do compile } */ +/* { dg-options "-O2 -fdump-tree-lim2-details -fdump-tree-optimized" } */ + +extern volatile int *x; +static int gCrc; + +static int __attribute__((noinline)) crc16Add(int crc, int b) +{ + return crc + b; +} + +void f(int data, int dataSz) +{ + int i; + + for(i=0;iref == UNANALYZABLE_MEM_ID) return -1; /* Stop at memory references which we can't move. */ - else if (memory_accesses.refs_list[data->ref]->mem.ref == error_mark_node) + else if (memory_accesses.refs_list[data->ref]->mem.ref == error_mark_node + || TREE_THIS_VOLATILE + (memory_accesses.refs_list[data->ref]->mem.ref)) { /* Mark refs_not_in_seq as unsupported. */ bitmap_ior_into (refs_not_supported, refs_not_in_seq);