From patchwork Thu Feb 16 13:44:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrick Palka X-Patchwork-Id: 58075 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp307272wrn; Thu, 16 Feb 2023 05:45:21 -0800 (PST) X-Google-Smtp-Source: AK7set8s12G2sHaT/KayGmBpwbXAb0Eh86lhbZOAF9zo7TtDUOgd5Z6QZdmC27jAB7vEXkdB62q+ X-Received: by 2002:a17:906:4d56:b0:8b1:264f:3776 with SMTP id b22-20020a1709064d5600b008b1264f3776mr6744359ejv.23.1676555121792; Thu, 16 Feb 2023 05:45:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676555121; cv=none; d=google.com; s=arc-20160816; b=v2rxCfbNnCGVklykX9FeoAYOvdKN/MM1b05QyI04VL/wHeTGcaoHiUfoRX+rulp6hS ggaY6eU1ezJhD8Ah2D8ixwC6+jOlIVvlrbl5pcYbiw2/hiBt3tzUMT31i4tx+RHW8Sjf ndYGxw4Ii3h1SLasT4yhHCUNFAOiI/OKrZPEPxwNfmaIlIKqShLWnlO1ZXzkJnlRFx1t 6PK6Ut92de8SDllMBHIqKWKn6jHJrUQhX6jYa3LBOonnBzmuaLV4/xd8rezz+88G+M93 7R4xy4r2oDUoRcfRlSfzZ8ujBsssMZpOvV5xTmJCprOkjXqQ008d7QGkkKk3ANePm1ES J7hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=mFOUuM5GL3Psnp1PQKH4KEF1qnuaiTuDaDVpSexfLjc=; b=SKqR7uwnLEEFcXx2idSRJ6X+7WWCC8c3E2YMPF4rexX/MoLXfGgscoaM6qWX0tVYx/ a2xGSbCsjf1/tpLnk6coEx0zSa9wD4oEQUK0nBL7uelgGvJyx9yogo7kawR0pG5c4Imw FcSQBGf+gWzQ7o6HofiG/TzoF3SE1tqVmgefLpWkQ/Cqo0OjVQhJQkMKcnvELooVK5K4 uT6VZvkkghDFnn8kBGAIO/5V1TsdcYhOQg9XSBCbC9kZgb6pAlSLLL6v6dKakV+JE9vI BVn8cdMCnzOcg+8d3s4cTG2RoZZG6zGzCESIar4qcrkO5fI+ZM+ht8AJxRnbbUnBSrUr DODg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b="VN/Jv3NV"; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id cm6-20020a170907938600b0087849c91571si1876784ejc.352.2023.02.16.05.45.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Feb 2023 05:45:21 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b="VN/Jv3NV"; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 89F733857B93 for ; Thu, 16 Feb 2023 13:45:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 89F733857B93 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1676555120; bh=mFOUuM5GL3Psnp1PQKH4KEF1qnuaiTuDaDVpSexfLjc=; h=To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=VN/Jv3NVs7Bok0hnLEPfVgu9kvg85/YcFucdvxP3spIZVGdura48WFp9zyMpS83kX BxmbgV63mMsK+6/G0cxdTGZpEi0XI6b+REqbnKLYDPzlpuS4YZHsIMJ/IAsHH56bAH ehUs4shlLzHXUyfhemCiWPaj+BqBM4y6WoAzJ6YE= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 37BE93857437 for ; Thu, 16 Feb 2023 13:44:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 37BE93857437 Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-78-gbW-L1kdOE2-jJgbA1AzDw-1; Thu, 16 Feb 2023 08:44:34 -0500 X-MC-Unique: gbW-L1kdOE2-jJgbA1AzDw-1 Received: by mail-qt1-f197.google.com with SMTP id cd3-20020a05622a418300b003b9bd2a2284so1217527qtb.4 for ; Thu, 16 Feb 2023 05:44:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mFOUuM5GL3Psnp1PQKH4KEF1qnuaiTuDaDVpSexfLjc=; b=RJMb/iWLPS4jAyUy80BcoLY0eoyZfDV42RaSIwC0CSS6YlHnB8BxfW9JIcKwILuaKe 8zO+AAID5p35mMnIkSxd9p8wnABzXs4jxL34GmR9P5bFjxUK49FEkr5wsDLsMHKLHy21 GO3V82LEU4fjJgUn7Bxw9joPtKF3id2Lz0eArqzE0a1eVCkl84IulhW0NoEJ1xGu7y4h WXxTI3kIum65CnONRwU93TEAtG+hz/D8Mo6NJa0EszbTzKHqs2wULj9LThNxVm3i7biy SXBTglJaWosKh9mKIg0ZnCvGYcYmQDtXTkiPikkVQhDW2k4DlmGuz4VuTfMsPH4XIvgn UmbQ== X-Gm-Message-State: AO0yUKVF7eXCOnw1Sgx2Xitkb4XftQL/6dnNK7YIMQcmFpgrM8ykO+73 dKWQqlpwA/xyimib7IeSeya7GtbHMZY18XFDsUOCqne5sQmXzJXB4+lwPetAYM7BxoeZphUQD8C nzkkLLlu5A8obkQjNujcso8yL7taeCSp51j5I2ZiWjjrislSRRS+wM53xr/dpnI9XCJMCl3Gf X-Received: by 2002:ac8:57cf:0:b0:3ac:fba0:cde with SMTP id w15-20020ac857cf000000b003acfba00cdemr9042113qta.22.1676555073818; Thu, 16 Feb 2023 05:44:33 -0800 (PST) X-Received: by 2002:ac8:57cf:0:b0:3ac:fba0:cde with SMTP id w15-20020ac857cf000000b003acfba00cdemr9042090qta.22.1676555073456; Thu, 16 Feb 2023 05:44:33 -0800 (PST) Received: from localhost.localdomain (ool-457670bb.dyn.optonline.net. [69.118.112.187]) by smtp.gmail.com with ESMTPSA id 7-20020a05620a040700b006fbb4b98a25sm1168128qkp.109.2023.02.16.05.44.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 16 Feb 2023 05:44:32 -0800 (PST) To: gcc-patches@gcc.gnu.org Cc: Patrick Palka Subject: [PATCH] don't declare header-defined functions both static and inline, pt 2 Date: Thu, 16 Feb 2023 08:44:31 -0500 Message-Id: <20230216134431.1600922-1-ppalka@redhat.com> X-Mailer: git-send-email 2.39.2.422.gc867e4fa18 In-Reply-To: References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-13.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, KAM_NUMSUBJECT, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Patrick Palka via Gcc-patches From: Patrick Palka Reply-To: Patrick Palka Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757995463388325039?= X-GMAIL-MSGID: =?utf-8?q?1757995463388325039?= This fixes some header-defined functions that are undesirably declared static and weren't caught by the "^static inline" pattern used in the previous patch. gcc/ChangeLog: * hash-table.h (gt_pch_nx): Remove static. * lra-int.h (lra_change_class): Likewise. * recog.h (which_op_alt): Likewise. * sel-sched-ir.h (sel_bb_empty_or_nop_p): Replace static with inline. --- gcc/hash-table.h | 2 +- gcc/lra-int.h | 2 +- gcc/recog.h | 2 +- gcc/sel-sched-ir.h | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/gcc/hash-table.h b/gcc/hash-table.h index 3f87ec06f37..c0c6e1cd83d 100644 --- a/gcc/hash-table.h +++ b/gcc/hash-table.h @@ -1275,7 +1275,7 @@ hashtab_entry_note_pointers (void *obj, void *h, gt_pointer_operator op, } template -static void +void gt_pch_nx (hash_table *h) { h->check_complete_insertion (); diff --git a/gcc/lra-int.h b/gcc/lra-int.h index 73f8eb004b0..a400a0f85e2 100644 --- a/gcc/lra-int.h +++ b/gcc/lra-int.h @@ -428,7 +428,7 @@ lra_get_regno_hard_regno (int regno) /* Change class of pseudo REGNO to NEW_CLASS. Print info about it using TITLE. Output a new line if NL_P. */ -static void inline +inline void lra_change_class (int regno, enum reg_class new_class, const char *title, bool nl_p) { diff --git a/gcc/recog.h b/gcc/recog.h index 764fa90afde..539a27c3edf 100644 --- a/gcc/recog.h +++ b/gcc/recog.h @@ -382,7 +382,7 @@ extern const operand_alternative *recog_op_alt; on operand OP of the current instruction alternative (which_alternative). Only valid after calling preprocess_constraints and constrain_operands. */ -inline static const operand_alternative * +inline const operand_alternative * which_op_alt () { gcc_checking_assert (IN_RANGE (which_alternative, 0, diff --git a/gcc/sel-sched-ir.h b/gcc/sel-sched-ir.h index 7034a1ab06c..0e87134c6db 100644 --- a/gcc/sel-sched-ir.h +++ b/gcc/sel-sched-ir.h @@ -1096,7 +1096,7 @@ get_loop_exit_edges_unique_dests (const class loop *loop) return edges; } -static bool +inline bool sel_bb_empty_or_nop_p (basic_block bb) { insn_t first = sel_bb_head (bb), last;