Message ID | 20230211161044.3540594-1-stefansf@linux.ibm.com |
---|---|
State | Accepted |
Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp1557962wrn; Sat, 11 Feb 2023 08:13:00 -0800 (PST) X-Google-Smtp-Source: AK7set8rweM/GHMpBHUXsBPWt1tsdPrP1ZoivovfsYUFvSd31Sae7QmfbgT3TSFVLW8mSgKkd22h X-Received: by 2002:a17:907:8810:b0:8a9:e031:c4ae with SMTP id ro16-20020a170907881000b008a9e031c4aemr20744046ejc.2.1676131980427; Sat, 11 Feb 2023 08:13:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1676131980; cv=none; d=google.com; s=arc-20160816; b=drSdLd4t1UZDCUhwZy4xum+cYB8O7zvQuLSRoanNURIR/rnSuHPyGDTqxsqGBNlCfN jzAXFOjibt7EhEk5KJpaRN9FhXMG7SM1jbBjDeCkaEBn7kULR8XVkqmRo9c3yn8uzmT8 p0grR02dixbisrLU4GxSdUtLlw7/8JITU1ZcMYHOQ/WM6QlgU9lIuG6mKEcM1J26nlwM QyrlN3Bh9xjCe7JsBVew6jYXmmpYv04VQ899qj18qj8Hza7mJRfN/to4HLkF57xnZ/uo ZykzhbsjZ228nQfdKUmdiiUjcOk8QKwn44HBUR2CA8UM62z97QrpS5yqoswJh0NjYQ+k 0pxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:message-id:date:subject:cc :to:dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=rIUdxEPFJ1hM/ZJvR3J+djd14DVoS2qFcBN+AQrO7Y4=; b=Qgk/b2CvARcM26/hJ8roLVlfg/pshc9DriyhGkNdw4Ofkza1VF3l/VznQX9xqFH7HO lx9gElX0rr0z83Bs44gd547kiQ/87AGHKV3+xuVWNTfYnsjWz6DddvyaDzzOokr/M29Y EowVE3WyCx2luqew0O7NlfS8d8MiV+r7eXSKXxJL3IOmMTY9JiycyM3Xf1/GvHKO28FH wJNLk8ZDkleYD7vswYmMA0w0y53e5heC4BzxYgkUNb+vRlp2phN+GpXWLFimWlOw+wTQ kB+1lcxiLiuOsw+ytWIffzftoxddSCFlN/1FHSgFHu5OZ2VJtQ4JQpKISEZDMI0q3gl/ 3OsQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b="Lpj9/LAP"; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (ip-8-43-85-97.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id up10-20020a170907cc8a00b008af3945032fsi7342025ejc.916.2023.02.11.08.13.00 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Feb 2023 08:13:00 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b="Lpj9/LAP"; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 716893858409 for <ouuuleilei@gmail.com>; Sat, 11 Feb 2023 16:12:59 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 716893858409 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1676131979; bh=rIUdxEPFJ1hM/ZJvR3J+djd14DVoS2qFcBN+AQrO7Y4=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=Lpj9/LAP7/Q0a2QRe/XoSyyOT9NRCpfTNNOuaN1qwEDRVEYhQhinYH9uRy54vMCeQ Ci/iUOlTocjVGNYBZ5lbnqrBqwghkauH1KtTxYsWHvqyZM5rEJte3MNoxdkacpzGOa ZjnUV16KNr0jl+zse8Rxg6dWu2tZeo6gnKWAkHxQ= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id C7C283858D32 for <gcc-patches@gcc.gnu.org>; Sat, 11 Feb 2023 16:12:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C7C283858D32 Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 31BFH2Et001157 for <gcc-patches@gcc.gnu.org>; Sat, 11 Feb 2023 16:12:15 GMT Received: from ppma04fra.de.ibm.com (6a.4a.5195.ip4.static.sl-reverse.com [149.81.74.106]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3npdh40p21-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for <gcc-patches@gcc.gnu.org>; Sat, 11 Feb 2023 16:12:15 +0000 Received: from pps.filterd (ppma04fra.de.ibm.com [127.0.0.1]) by ppma04fra.de.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 31B2t71k007043 for <gcc-patches@gcc.gnu.org>; Sat, 11 Feb 2023 16:12:13 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma04fra.de.ibm.com (PPS) with ESMTPS id 3np2n68fw8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for <gcc-patches@gcc.gnu.org>; Sat, 11 Feb 2023 16:12:13 +0000 Received: from smtpav02.fra02v.mail.ibm.com (smtpav02.fra02v.mail.ibm.com [10.20.54.101]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 31BGC90M25625176 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 11 Feb 2023 16:12:09 GMT Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3EB9D20043; Sat, 11 Feb 2023 16:12:09 +0000 (GMT) Received: from smtpav02.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 16FBD20040; Sat, 11 Feb 2023 16:12:09 +0000 (GMT) Received: from a8345010.lnxne.boe (unknown [9.152.108.100]) by smtpav02.fra02v.mail.ibm.com (Postfix) with ESMTPS; Sat, 11 Feb 2023 16:12:09 +0000 (GMT) To: krebbel@linux.ibm.com, gcc-patches@gcc.gnu.org Cc: Stefan Schulze Frielinghaus <stefansf@linux.ibm.com> Subject: [PATCH] IBM zSystems: Fix predicate execute_operation Date: Sat, 11 Feb 2023 17:10:45 +0100 Message-Id: <20230211161044.3540594-1-stefansf@linux.ibm.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: KO3XmcL-QWu2UfGrbcOf5gyFQihS9akQ X-Proofpoint-ORIG-GUID: KO3XmcL-QWu2UfGrbcOf5gyFQihS9akQ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.170.22 definitions=2023-02-11_09,2023-02-09_03,2023-02-09_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 lowpriorityscore=0 impostorscore=0 suspectscore=0 adultscore=0 phishscore=0 mlxlogscore=999 spamscore=0 malwarescore=0 bulkscore=0 clxscore=1015 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2212070000 definitions=main-2302110147 X-Spam-Status: No, score=-8.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> From: Stefan Schulze Frielinghaus via Gcc-patches <gcc-patches@gcc.gnu.org> Reply-To: Stefan Schulze Frielinghaus <stefansf@linux.ibm.com> Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1757551767431400997?= X-GMAIL-MSGID: =?utf-8?q?1757551767431400997?= |
Series |
IBM zSystems: Fix predicate execute_operation
|
|
Checks
Context | Check | Description |
---|---|---|
snail/gcc-patch-check | success | Github commit url |
Commit Message
Stefan Schulze Frielinghaus
Feb. 11, 2023, 4:10 p.m. UTC
Use constrain_operands in order to check whether there exists a valid alternative instead of extract_constrain_insn which ICEs in case no alternative is found. Bootstrapped and regtested on IBM zSystems. Ok for mainline? gcc/ChangeLog: * config/s390/predicates.md (execute_operation): Use constrain_operands instead of extract_constrain_insn in order to determine wheter there exists a valid alternative. --- gcc/config/s390/predicates.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On 2/11/23 17:10, Stefan Schulze Frielinghaus wrote: > Use constrain_operands in order to check whether there exists a valid > alternative instead of extract_constrain_insn which ICEs in case no > alternative is found. > > Bootstrapped and regtested on IBM zSystems. Ok for mainline? > > gcc/ChangeLog: > > * config/s390/predicates.md (execute_operation): Use > constrain_operands instead of extract_constrain_insn in order to > determine wheter there exists a valid alternative. Ok. Thanks! Andreas
diff --git a/gcc/config/s390/predicates.md b/gcc/config/s390/predicates.md index 404e8d87b63..d5d5a7cc0d3 100644 --- a/gcc/config/s390/predicates.md +++ b/gcc/config/s390/predicates.md @@ -479,9 +479,9 @@ if (icode < 0) return false; - extract_constrain_insn (insn); + extract_insn (insn); - return which_alternative >= 0; + return constrain_operands (reload_completed, get_enabled_alternatives (insn)) == 1; }) ;; Return true if OP is a store multiple operation. It is known to be a