diff mbox series

[v3] emit DW_AT_name for DW_TAG_GNU_formal_parameter_pack [PR70536]

Message ID 20230204165033.4026-1-ed@catmur.uk
State Accepted
Headers
Series [v3] emit DW_AT_name for DW_TAG_GNU_formal_parameter_pack [PR70536] |

Checks

Context Check Description
snail/gcc-patch-check success Github commit url

Commit Message

Ed Catmur Feb. 4, 2023, 4:50 p.m. UTC 
  Per http://wiki.dwarfstd.org/index.php?title=C%2B%2B0x:_Variadic_templates DW_TAG_GNU_formal_parameter_pack should have a DW_AT_name:

17$:      DW_TAG_formal_parameter_pack
              DW_AT_name("args")
18$:          DW_TAG_formal_parameter
                  ! no DW_AT_name attribute
                  DW_AT_type(reference to 13$)
(...)

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70536
---
 gcc/dwarf2out.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ed Catmur May 17, 2023, 9:32 p.m. UTC | #1 
Ping.

On Sat, 4 Feb 2023, at 10:50, Ed Catmur wrote:
> Per 
> http://wiki.dwarfstd.org/index.php?title=C%2B%2B0x:_Variadic_templates 
> DW_TAG_GNU_formal_parameter_pack should have a DW_AT_name:
>
> 17$:      DW_TAG_formal_parameter_pack
>               DW_AT_name("args")
> 18$:          DW_TAG_formal_parameter
>                   ! no DW_AT_name attribute
>                   DW_AT_type(reference to 13$)
> (...)
>
> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70536
> ---
>  gcc/dwarf2out.cc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/gcc/dwarf2out.cc b/gcc/dwarf2out.cc
> index 1f39df3b1e2..462328acd9f 100644
> --- a/gcc/dwarf2out.cc
> +++ b/gcc/dwarf2out.cc
> @@ -23041,7 +23041,7 @@ gen_formal_parameter_pack_die  (tree parm_pack,
>  	      && subr_die);
> 
>    parm_pack_die = new_die (DW_TAG_GNU_formal_parameter_pack, subr_die, 
> parm_pack);
> -  add_src_coords_attributes (parm_pack_die, parm_pack);
> +  add_name_and_src_coords_attributes (parm_pack_die, parm_pack);
> 
>    for (arg = pack_arg; arg; arg = DECL_CHAIN (arg))
>      {
> -- 
> 2.34.1
diff mbox series

Patch

diff --git a/gcc/dwarf2out.cc b/gcc/dwarf2out.cc
index 1f39df3b1e2..462328acd9f 100644
--- a/gcc/dwarf2out.cc
+++ b/gcc/dwarf2out.cc
@@ -23041,7 +23041,7 @@  gen_formal_parameter_pack_die  (tree parm_pack,
 	      && subr_die);
 
   parm_pack_die = new_die (DW_TAG_GNU_formal_parameter_pack, subr_die, parm_pack);
-  add_src_coords_attributes (parm_pack_die, parm_pack);
+  add_name_and_src_coords_attributes (parm_pack_die, parm_pack);
 
   for (arg = pack_arg; arg; arg = DECL_CHAIN (arg))
     {