From patchwork Tue Jan 31 13:26:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arthur Cohen X-Patchwork-Id: 50934 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp2817876wrn; Tue, 31 Jan 2023 07:33:42 -0800 (PST) X-Google-Smtp-Source: AK7set+/73BbHR4F+DgG+Gis5yj3BtfC+GLEYGaNnR8fm+XKxe3MUQMqDJX56Mh7CubveYVf3wou X-Received: by 2002:a17:907:9626:b0:879:36b4:486 with SMTP id gb38-20020a170907962600b0087936b40486mr22264053ejc.13.1675179222730; Tue, 31 Jan 2023 07:33:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1675179222; cv=none; d=google.com; s=arc-20160816; b=fRhaGgP+4X7KFgyRWSfhUt/GK26efLUPOLYn6T+S01lhaMHneUYj9eRGgimP/PFogC zdNt2n+RpjBMYDYeCa4Cu189YCYR2WrkcejDPJ5YhYmOiGwCkSL//TGBKc3qhdsKsfQs sNFzCzB8wp/fkWVssrAmLTpDjZuOEJEGkOiYGDqGjzY2/0rRS61C2Muc0Of4M5vPJczp xF+b7CyU6REUkYgw8erIm8rYJZHYCYgW5xuwpUCq6K5mdYsZu4CdBP1Zbl2sN3W7MBLq g/nQYQZIHVS1w0EHKXKNatQU0y1+ZGbow9Z7btbfXWko9ESSFIAO7xMHO3EGeZzUcTST knqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature :dmarc-filter:delivered-to; bh=HpW4NwAcCbOVh6lyC7GPbvJa27IQ4H3lps395+OQNcM=; b=FTQSwGC/o8soLLyls6qBfa3Y8jALr+pTLKhRdPwBZyDnJmr1nu9CCdu38wo0r/FMa8 8xHI24Nfl2BakZ0U6PcRekB02GJ25p8o5HEQbu40vX/chl05S7s8tDBSoHkPRhb4JZ86 3RADOPf4tn04hMGt4jkXcqStIvrNP+mJIN/c+SkMbpcQjYduM9JFWIiK8tolKXaLhsog 2g0Ae80RJBhv0UwMrt3OBHoInqvEVwdfeas/hH6cJx+pfzaLCfG41+PhF5XbBr2b3WKU a7ak3f9gOBrRnjU2tzGuIx+3V9Gk9Fw88I43iR4tFUrRpfNtZP3wpKSSCR6rzY5KGFKQ Z4aw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@embecosm.com header.s=google header.b=Ua3t9j7o; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from sourceware.org (server2.sourceware.org. [8.43.85.97]) by mx.google.com with ESMTPS id r5-20020a170906a20500b0086e55f5caf2si19460429ejy.149.2023.01.31.07.33.42 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Jan 2023 07:33:42 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) client-ip=8.43.85.97; Authentication-Results: mx.google.com; dkim=pass header.i=@embecosm.com header.s=google header.b=Ua3t9j7o; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 8.43.85.97 as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 60FA1395A436 for ; Tue, 31 Jan 2023 13:25:27 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by sourceware.org (Postfix) with ESMTPS id 241F33AA800D for ; Tue, 31 Jan 2023 13:22:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 241F33AA800D Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-wm1-x32a.google.com with SMTP id k8-20020a05600c1c8800b003dc57ea0dfeso4461396wms.0 for ; Tue, 31 Jan 2023 05:22:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=HpW4NwAcCbOVh6lyC7GPbvJa27IQ4H3lps395+OQNcM=; b=Ua3t9j7o0cjMoy4+bVAlOUfGh+tIbAkgpnElt3oog6lpX03Zes0uThC99fxOdcrMVh GuPtsZ+yotsXMLS8DCMtCI2rbD8uhXMB1nu76HMNdtJAltXOvT6CK5RGl/tFWnNWWwdI MUkRZa1B0ks9xVuqVsypwlNzSh6GsrMYCZX8UjRBGuqceynyDx0esmIGvHvfo7sLFv+d WJjIF4GkOIxCWifThD94VWPhVO/+mHW2iVDFYHGq73WkoLpKptwB0rKWJ3mPFPCw8Czv tzxScTyvZehfeeKiF2he59PvqnEiEYu+ZKGm7220OC2lxpaRmAnZE4+dKAfTfohzL+WN otaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HpW4NwAcCbOVh6lyC7GPbvJa27IQ4H3lps395+OQNcM=; b=CivspsW926cRj0ETJKmpx7H7FGw2KwwPoQutX8KPj0/iGqZQrHMMhs46u+NW9iwksl yNAfStGlrEsg5bJsGHmYh7QYgPWjdgxdQqEnyGJzxK1pitPbQy/khIYrE/6rjgHq20XB rqCOF9zfzNP02k95ChOk/l2JuI9FTVIl478eMrbTxru3A7OVoLpy3AJKKoVBbu2mPhnL D1yWFX8WfOocgEsHLtmwPnODC4Nw8do3c7kFV1/GBAdWAOMpuNPPuqyUqaOzuVJg1xq3 YKaz3bZivAS0ErOt6gGL7Vm9vEpzFCJD0/tGk+vxQydlArBVX2WdQitUDoJXJgCodsis yX7Q== X-Gm-Message-State: AO0yUKX4nDHg/D8+lCrykZ1Z1wLt4SY5x/OPw8S54WFzKISepf0zD+nr HKl5SqeoGZfwTstixZLX7lvhDpm3I2zO45ZdNw== X-Received: by 2002:a05:600c:3c86:b0:3dd:1b76:347f with SMTP id bg6-20020a05600c3c8600b003dd1b76347fmr3615837wmb.18.1675171372529; Tue, 31 Jan 2023 05:22:52 -0800 (PST) Received: from platypus.lan ([2001:861:5e4c:3bb0:6424:328a:1734:3249]) by smtp.gmail.com with ESMTPSA id i19-20020a05600c2d9300b003dc4fd6e624sm9075222wmg.19.2023.01.31.05.22.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Jan 2023 05:22:52 -0800 (PST) From: Arthur Cohen To: gcc-patches@gcc.gnu.org Cc: gcc-rust@gcc.gnu.org, Philip Herron Subject: [COMMITTED] gccrs: Statics are a coercion site Date: Tue, 31 Jan 2023 14:26:33 +0100 Message-Id: <20230131132633.663363-1-arthur.cohen@embecosm.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 X-Spam-Status: No, score=-15.4 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1756552728874346307?= X-GMAIL-MSGID: =?utf-8?q?1756552728874346307?= From: Philip Herron Statics can be assigned to a block expression meaning they need to behave similarly to constant items. gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-toplevel.cc (TypeCheckTopLevel::visit): Make static items behave more similarly to const items. Tested on x86_64-pc-linux-gnu, committed on master. --- gcc/rust/typecheck/rust-hir-type-check-toplevel.cc | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/gcc/rust/typecheck/rust-hir-type-check-toplevel.cc b/gcc/rust/typecheck/rust-hir-type-check-toplevel.cc index b0ee292df10..594e527fdcf 100644 --- a/gcc/rust/typecheck/rust-hir-type-check-toplevel.cc +++ b/gcc/rust/typecheck/rust-hir-type-check-toplevel.cc @@ -261,11 +261,11 @@ TypeCheckTopLevel::visit (HIR::StaticItem &var) TyTy::BaseType *expr_type = TypeCheckExpr::Resolve (var.get_expr ()); TyTy::BaseType *unified - = unify_site (var.get_mappings ().get_hirid (), - TyTy::TyWithLocation (type, var.get_type ()->get_locus ()), - TyTy::TyWithLocation (expr_type, - var.get_expr ()->get_locus ()), - var.get_locus ()); + = coercion_site (var.get_mappings ().get_hirid (), + TyTy::TyWithLocation (type, var.get_type ()->get_locus ()), + TyTy::TyWithLocation (expr_type, + var.get_expr ()->get_locus ()), + var.get_locus ()); context->insert_type (var.get_mappings (), unified); }