From patchwork Sun Jan 15 10:27:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Aldy Hernandez X-Patchwork-Id: 43824 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:adf:eb09:0:0:0:0:0 with SMTP id s9csp677083wrn; Sun, 15 Jan 2023 02:28:38 -0800 (PST) X-Google-Smtp-Source: AMrXdXtjjNFZfz0LotHnxEf2jXce97gQSOdAma7RAMiNbyS9mmTN9SffcNjGQjHdi8DCuTIY7Oqj X-Received: by 2002:a17:906:b096:b0:861:4671:a834 with SMTP id x22-20020a170906b09600b008614671a834mr14610151ejy.71.1673778517916; Sun, 15 Jan 2023 02:28:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673778517; cv=none; d=google.com; s=arc-20160816; b=ZVEi6KIv7n2hV6F8zQqkIMhQBoalsGPMe7oZOnFhMVhdpr0dSuFK1IHo3qRkcc9gTn Qy0SFZOx0MYTTaOpwpu3rGs4lJmYMv3alCpU1Zq/pa3O6s2A332dhATgVmXlFogw2AP7 hCkwedKhO/5HDKsOO7pewpXt53w3l6II403wcH5CSBFrNKaLJlKYMdBth+Ke0lOGDSHV MvSsVWXluznNdHHULruCdYd4bNNdU4bqc6TN/nuQgHYUVVBdDubPFDS5gm2mzuysdSC2 0Z9HHYOJBMxWdu1acW5t44C0J+HqX6+4KH8Dw16UOIcB09onp19rW/MRuEzVHdq2nO64 vXfw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:message-id:date:subject:cc :to:dmarc-filter:delivered-to:dkim-signature:dkim-filter; bh=pfI1fv5ChpiJNeprbOBkk9y8zFbID+euKv4AwnW6ct0=; b=dORIWp6s4MDhDXdoz4RHNoHn8pJTOI5YAQBAr6vxtCmcwlxaJ0A3SolR0YdNvI1rye ojZWXiKxbR0RK8GCstYX1EzKoOh5JrVUadb7riz1fTMQydT5rLxiS186eQDbUZ+9pKio MzVrZc9Xs4lfv5AMU02QPxWRK3xNDQfS3eqHF6hOqLqOunCrcp+yHGCtgpvWXOhPGGrm 57ivhQE5lof9LskToVB3osySccou+b4H8FaLjTbDcY1aPohs22755T5MW23bAHGhqoBW gcOXWzO+cL9TCJ2dFNniDbWGcZSxNMo5aTh7RkPIBmMJKU3B2mNt0kqGq7g9NAcjpbiD f/ZA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=mo5S+v5s; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id k5-20020a50cb85000000b00461d2ed78acsi24063252edi.378.2023.01.15.02.28.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Jan 2023 02:28:37 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=mo5S+v5s; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D79CC3858410 for ; Sun, 15 Jan 2023 10:28:31 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D79CC3858410 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1673778511; bh=pfI1fv5ChpiJNeprbOBkk9y8zFbID+euKv4AwnW6ct0=; h=To:Cc:Subject:Date:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=mo5S+v5sgvN4aslvUY/y+oTcsbX9CGz1uaf0elu6x/nEakLnhQkqrn3lQGKYoz9ZM MjluStwwD0EGUGEmI5owgRdn69pc5ewpQ8DADu/tu5rcpP5od8MzJhlvGuEqXxJeKk UXKRPO9unPx09ZKBZBYEQoZBjFCsulS64HbGVrAI= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 502283858D32 for ; Sun, 15 Jan 2023 10:27:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 502283858D32 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-277-8QICCpw3Ob-3evskYoAq5g-1; Sun, 15 Jan 2023 05:27:45 -0500 X-MC-Unique: 8QICCpw3Ob-3evskYoAq5g-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 493768339B4; Sun, 15 Jan 2023 10:27:45 +0000 (UTC) Received: from abulafia.quesejoda.com (ovpn-192-35.brq.redhat.com [10.40.192.35]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A5BAC40C2064; Sun, 15 Jan 2023 10:27:44 +0000 (UTC) Received: from abulafia.quesejoda.com (localhost [127.0.0.1]) by abulafia.quesejoda.com (8.17.1/8.17.1) with ESMTPS id 30FARgEg019125 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NOT); Sun, 15 Jan 2023 11:27:42 +0100 Received: (from aldyh@localhost) by abulafia.quesejoda.com (8.17.1/8.17.1/Submit) id 30FARfU4019124; Sun, 15 Jan 2023 11:27:41 +0100 To: Jakub Jelinek Cc: Richard Biener , Andrew MacLeod , GCC patches , Aldy Hernandez Subject: [PATCH] [PR107608] [range-ops] Avoid folding into INF when flag_trapping_math. Date: Sun, 15 Jan 2023 11:27:38 +0100 Message-Id: <20230115102738.19101-1-aldyh@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Spam-Status: No, score=-11.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Aldy Hernandez via Gcc-patches From: Aldy Hernandez Reply-To: Aldy Hernandez Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1755083983197175447?= X-GMAIL-MSGID: =?utf-8?q?1755083983197175447?= As discussed in the PR, for trapping math, do not fold overflowing operations into +-INF as doing so could elide a trap. There is a minor adjustment to known_isinf() where it was mistakenly returning true for an [infinity U NAN], whereas it should only return true when the range is exclusively +INF or -INF. This is benign, as there were no users of known_isinf up to now. I had some testsuite issues with: > FAIL: c-c++-common/diagnostic-format-sarif-file-4.c -std=gnu++14 scan-sarif-file "text": " int \\\\u6587\\\\u5b57\\\\u5316\\\\u3051 = > FAIL: c-c++-common/diagnostic-format-sarif-file-4.c -std=gnu++17 scan-sarif-file "text": " int \\\\u6587\\\\u5b57\\\\u5316\\\\u3051 = > FAIL: c-c++-common/diagnostic-format-sarif-file-4.c -std=gnu++20 scan-sarif-file "text": " int \\\\u6587\\\\u5b57\\\\u5316\\\\u3051 = > FAIL: c-c++-common/diagnostic-format-sarif-file-4.c -std=gnu++98 scan-sarif-file "text": " int \\\\u6587\\\\u5b57\\\\u5316\\\\u3051 = > FAIL: g++.dg/pr71488.C (test for excess errors) > FAIL: g++.dg/guality/pr55665.C -O2 -flto -fno-use-linker-plugin -flto-partition=none line 23 p == 40 > FAIL: c-c++-common/diagnostic-format-sarif-file-4.c -Wc++-compat scan-sarif-file "text": " int \\\\u6587\\\\u5b57\\\\u5316\\\\u3051 = < FAIL: g++.dg/pr71488.C (test for excess errors) < FAIL: g++.dg/guality/pr55665.C -O2 -flto -fno-use-linker-plugin -flto-partition=none line 23 p == 40 > FAIL: ./index0-out.go execution, -O0 -g -fno-var-tracking-assignments > FAIL: go.test/test/fixedbugs/issue27836.dir/Äfoo.go -O -I. (test for excess errors) > FAIL: go.test/test/fixedbugs/issue27836.dir/Ämain.go -O -I. (test for excess errors) But they seem to be transient issues on my machine, as re-running them manually don't cause any issues. Also, the tests themselves have nothing to do with floats so I don't see how they could be related. Tested on x86-64 Linux. I also ran the glibc testsuite (git sources) on x86-64 and this patch fixes: -FAIL: math/test-double-lgamma -FAIL: math/test-double-log1p -FAIL: math/test-float-lgamma -FAIL: math/test-float-log1p -FAIL: math/test-float128-catan -FAIL: math/test-float128-catanh -FAIL: math/test-float128-lgamma -FAIL: math/test-float128-log -FAIL: math/test-float128-log1p -FAIL: math/test-float128-y0 -FAIL: math/test-float128-y1 -FAIL: math/test-float32-lgamma -FAIL: math/test-float32-log1p -FAIL: math/test-float32x-lgamma -FAIL: math/test-float32x-log1p -FAIL: math/test-float64-lgamma -FAIL: math/test-float64-log1p -FAIL: math/test-float64x-lgamma -FAIL: math/test-ldouble-lgamma OK for trunk? PR tree-optimization/107608 gcc/ChangeLog: * range-op-float.cc (range_operator_float::fold_range): Avoid folding into INF when flag_trapping_math. * value-range.h (frange::known_isinf): Return false for possible NANs. --- gcc/range-op-float.cc | 21 +++++++++++++++++++++ gcc/value-range.h | 1 + 2 files changed, 22 insertions(+) diff --git a/gcc/range-op-float.cc b/gcc/range-op-float.cc index 986a3896a4f..74ac4658378 100644 --- a/gcc/range-op-float.cc +++ b/gcc/range-op-float.cc @@ -91,6 +91,27 @@ range_operator_float::fold_range (frange &r, tree type, else r.clear_nan (); + // If the result has overflowed and flag_trapping_math, folding this + // operation could elide an overflow or division by zero exception. + // Avoid returning a singleton +-INF, to keep the propagators (DOM + // and substitute_and_fold_engine) from folding. See PR107608. + if (flag_trapping_math + && MODE_HAS_INFINITIES (TYPE_MODE (type)) + && r.known_isinf () && !op1.known_isinf () && !op2.known_isinf ()) + { + REAL_VALUE_TYPE inf = r.lower_bound (); + if (real_isneg (&inf)) + { + REAL_VALUE_TYPE min = real_min_representable (type); + r.set (type, inf, min); + } + else + { + REAL_VALUE_TYPE max = real_max_representable (type); + r.set (type, max, inf); + } + } + return true; } diff --git a/gcc/value-range.h b/gcc/value-range.h index ea50ed3e64a..f4ac73b499f 100644 --- a/gcc/value-range.h +++ b/gcc/value-range.h @@ -1300,6 +1300,7 @@ inline bool frange::known_isinf () const { return (m_kind == VR_RANGE + && !maybe_isnan () && real_identical (&m_min, &m_max) && real_isinf (&m_min)); }