From patchwork Mon Jan 9 14:07:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Biener X-Patchwork-Id: 40888 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp2175588wrt; Mon, 9 Jan 2023 06:08:16 -0800 (PST) X-Google-Smtp-Source: AMrXdXs4rk9m003sbunv3l03UkLyPfjOULvAYEVRKu5XjwNw04D/K3DV0WOJktfZXfDoeUIHU98j X-Received: by 2002:a17:907:3e0c:b0:7c0:f90f:163d with SMTP id hp12-20020a1709073e0c00b007c0f90f163dmr73500354ejc.11.1673273296288; Mon, 09 Jan 2023 06:08:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1673273296; cv=none; d=google.com; s=arc-20160816; b=LNsxWY9bvAh3ngWobjT5qOsY9plns1sBqTEZEaNYiU5MmLKt2P9dQcdpIY6EhBUFaI ekGg82amk4gzRjBwBJWXG0TQkbxINUR0LIMeHm/hxsRizAF9RAYnS9kz5J151WKBRfUy T23Y6nqRERPJodnPppJexHapQNLQIm/aJy/kjdVaUKKynrjWxRSOPYKUl9MIwFl7t/lO MrUjEMa+s8vU0tNjngcQgLwuDySEdq9P5beynw4zqz6iJXYkLXYHzdJ24QXUWCR5iAEh ZZ6NVrC9Pk+kJL8iBtXpTxhLMe/0LdtsN9DzLxJ+dem1+QUdL79/gRge7IP2qvCmDCDy w7Vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:from:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:message-id :mime-version:subject:to:date:dmarc-filter:delivered-to :dkim-signature:dkim-filter; bh=I7U/BX1wOZ7lDdq3hBHo6ivUhHDdLicSTkYDU28Z/Hg=; b=E1n64V+oQ3drDZLnNqbtxLxo447oZcQODq+aD7avEyhima1o+UVZM+IpunooGvblqf xfdyAOOTmeP2iS/MG3ERzIvZu383K89egU8NceV/CKMCD0+LOHKww3s6B2PDIp9Y4+zw mDXLjSKpsoRdKZHHztE4K9xdhYkiqu/ce7WkW1flNHHKsL1uStzD3UD61/jeQnDY3tq1 2wQh5agi+KePtZrKldb5RIWaFbwEZjinfhx1c9h9SPatqkEbDcxrdw0N2iR1fyhvM9Mh 631dfqqDMMtmFIpJgfKyjq3qHozjG2L0hFuBjQZ6j5DyQnB9QgwZjGtVFkJNn5VkKKti G4+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=mPw3bi0X; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id cs21-20020a170906dc9500b007c0bc7057ddsi10277685ejc.909.2023.01.09.06.08.16 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Jan 2023 06:08:16 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=mPw3bi0X; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9727C3857C4F for ; Mon, 9 Jan 2023 14:08:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9727C3857C4F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1673273292; bh=I7U/BX1wOZ7lDdq3hBHo6ivUhHDdLicSTkYDU28Z/Hg=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=mPw3bi0XWf1UK9Upz7q6Zfh8l94f/8D8A8yZsCpmeW8+lqobNe4mmtZhW2sAwjfVV 5vcNBeW4fCw2jwbGr8cSBsj0CBO3O+3plwbcd4JXDr4HL5OtxoVAl2imVKhYQLvQTe XGGO3bmp+4X7TL92Aj66X694nhPT/lIJqmSHszYA= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2001:67c:2178:6::1d]) by sourceware.org (Postfix) with ESMTPS id D643F3858D1E for ; Mon, 9 Jan 2023 14:07:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org D643F3858D1E Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 96E9844E9 for ; Mon, 9 Jan 2023 14:07:27 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 78A9C13583 for ; Mon, 9 Jan 2023 14:07:27 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id qYs1HJ8fvGMDIgAAMHmgww (envelope-from ) for ; Mon, 09 Jan 2023 14:07:27 +0000 Date: Mon, 9 Jan 2023 15:07:27 +0100 (CET) To: gcc-patches@gcc.gnu.org Subject: [PATCH] middle-end/108209 - typo in genmatch.cc:commutative_op MIME-Version: 1.0 Message-Id: <20230109140727.78A9C13583@imap2.suse-dmz.suse.de> X-Spam-Status: No, score=-11.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Richard Biener via Gcc-patches From: Richard Biener Reply-To: Richard Biener Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1754554219630537829?= X-GMAIL-MSGID: =?utf-8?q?1754554219630537829?= The early out for user-id handling indicated commutative rather than not commutative. Bootstrapped and tested on x86_64-unkown-linux-gnu, pushed. PR middle-end/108209 * genmatch.cc (commutative_op): Fix return value for user-id with non-commutative first replacement. --- gcc/genmatch.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/genmatch.cc b/gcc/genmatch.cc index fb9e37ae434..d4cb439a851 100644 --- a/gcc/genmatch.cc +++ b/gcc/genmatch.cc @@ -496,7 +496,7 @@ commutative_op (id_base *id) { int res = commutative_op (uid->substitutes[0]); if (res < 0) - return 0; + return -1; for (unsigned i = 1; i < uid->substitutes.length (); ++i) if (res != commutative_op (uid->substitutes[i])) return -1;