From patchwork Mon Jan 2 11:39:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Iain Sandoe X-Patchwork-Id: 38095 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:4e01:0:0:0:0:0 with SMTP id p1csp4121406wrt; Mon, 2 Jan 2023 03:40:11 -0800 (PST) X-Google-Smtp-Source: AMrXdXuCBCMd3QWD+/8OAYF/A6+Z+XkBaRBxTQMhJymEWW3HshfI2gohiYAm5LCpelWEBeMEZQa8 X-Received: by 2002:a17:907:7676:b0:815:8d03:92ad with SMTP id kk22-20020a170907767600b008158d0392admr38267336ejc.39.1672659610973; Mon, 02 Jan 2023 03:40:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1672659610; cv=none; d=google.com; s=arc-20160816; b=K85UzCkZnM555WwpaV0HnyMo0aGdUfc814dJkJFhsKgZiuFJGH0+oSkD2I+3irlqVr F+QYUBF64kILWvKt2Ond8tg/IpuYoW54DOVrDlXmlNXjCGAd7RufpSeqmj8t6c+z4ed3 ueyY8gKEk1/JF0Q4LAvTTUrS127RgxaxItAWUUmGYmFqQAewvtlxAZoS5llGfulWxKbc wYWagd6wUTfMM4S58OJppw70LldPCwcAKz2KrSDp2OFlZdAoxqE5V0tfXm8w60l4Du6Q 9Ny0NUCsUTHBtGWKEZo16k6PSYyNSjqQvF7wF8xkZBYXlqXDT4a0fNm3Bz3tJ+h7xvwA cAFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:reply-to:from:list-subscribe:list-help :list-post:list-archive:list-unsubscribe:list-id:precedence :content-transfer-encoding:mime-version:message-id:date:subject:to :delivered-to:dkim-signature:dkim-filter; bh=MI1t28X8zToGT7laDqhtADRq9mY+Zk79dGOwO1AWVww=; b=u8JFiBxWDFrFMNOTMoyHJZr2UKgl8+G3neG1HnCq6Sjua3zhLn62j38mo3rlJ/1PHd wT+UYtfMyQM04FqVwNhLQTRwHBemCKM22jDC7A/Cldzl3Qt/vjrVM9Nr7fJSLDEOSkCm 6UWEcxKKwlblnx4yco+K22XfOF7iWbXJC/mf8bBO0ZKFlpO59EpSj6HpO581IvpkvmQT 3rL0+ENw0F+A8i0ap7QlQo1S/oQLhydAVFMn0iKK2o/1f40ENruIlZ3Aqq0itkQpDbvE gm1Sud5b15MS2hZUx6/SFyRdWbV4g2UbWOeQfonHntc6yGi8gA6tEux4TEiA1nXWGLAI NUBA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=ldtagGKW; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id sz15-20020a1709078b0f00b007be268708b3si20009495ejc.926.2023.01.02.03.40.10 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Jan 2023 03:40:10 -0800 (PST) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; dkim=pass header.i=@gcc.gnu.org header.s=default header.b=ldtagGKW; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=gnu.org Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BE32C3858413 for ; Mon, 2 Jan 2023 11:40:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BE32C3858413 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gcc.gnu.org; s=default; t=1672659609; bh=MI1t28X8zToGT7laDqhtADRq9mY+Zk79dGOwO1AWVww=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=ldtagGKWg1Ibb9Z1REXzroxgoXsXjTiYCtUJJqN5gUtBaGDFJNABYP4IZ6LzXbzBA PMQ/2ldH9zBLoZ+9REVYrPyDXywkbCGpCZi7/GA2LeAibjw4bSzDODTi9x797fOs9h NbN/HSVIAgPBLMjPG3GLKMj+O3n1Psy0jcqpdOvg= X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from mail-wr1-x429.google.com (mail-wr1-x429.google.com [IPv6:2a00:1450:4864:20::429]) by sourceware.org (Postfix) with ESMTPS id 223563858D32 for ; Mon, 2 Jan 2023 11:39:25 +0000 (GMT) Received: by mail-wr1-x429.google.com with SMTP id j17so20710374wrr.7 for ; Mon, 02 Jan 2023 03:39:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:reply-to:message-id:date :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=MI1t28X8zToGT7laDqhtADRq9mY+Zk79dGOwO1AWVww=; b=678Lv+fjU233UaI6G/J93T3jyr75tcd4i0uurJd2B4C32SJrQA0bD3ezEE7aE0RJ5a /P/VKsNqNjazIAxlqrMiUOdeukY7orNEM4l4E5tOwkq0jL1NZbxo58Fg8FmV5uiKkoH3 kxJks+Eih+RNrJP/yvCwHbJE3VxjCSVMNchvq3m5dz24YWRvShuCFor0LaD6rdEfc7hM b88XDDyLccxJvebJqTbOOb+ztTMc/V892kYwpSXTaoMMmZQv044NCIxwJdT0Tzgdeh08 9IJ8a8bv8N9KKy716H/28SDeFExMB8Tbs6w32sGo7OT2BcQZu0vdgA4QujmM5K1/RHUL 0fCQ== X-Gm-Message-State: AFqh2koH2C2To2yuEA5hTOeQEWWzOTLaRp6/zbiALj90GRmvb5ITGtnq is2ghaxLkTgIIEiiO9CC+SJIn4xoMGQ= X-Received: by 2002:a5d:438e:0:b0:241:94bc:26d3 with SMTP id i14-20020a5d438e000000b0024194bc26d3mr29038743wrq.49.1672659563792; Mon, 02 Jan 2023 03:39:23 -0800 (PST) Received: from localhost.localdomain (host81-138-1-83.in-addr.btopenworld.com. [81.138.1.83]) by smtp.gmail.com with ESMTPSA id f14-20020a5d664e000000b0027f4a7efc54sm19815342wrw.15.2023.01.02.03.39.23 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 02 Jan 2023 03:39:23 -0800 (PST) X-Google-Original-From: Iain Sandoe To: gcc-patches@gcc.gnu.org Subject: [PATCH] modula-2: Module registration constructors need to be visible [PR108259]. Date: Mon, 2 Jan 2023 11:39:22 +0000 Message-Id: <20230102113922.5458-1-iain@sandoe.co.uk> X-Mailer: git-send-email 2.37.1 (Apple Git-137.1) MIME-Version: 1.0 X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, FREEMAIL_FROM, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-Patchwork-Original-From: Iain Sandoe via Gcc-patches From: Iain Sandoe Reply-To: iain@sandoe.co.uk Cc: Iain Sandoe , gaiusmod2@gmail.com Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1753910724060744152?= X-GMAIL-MSGID: =?utf-8?q?1753910724060744152?= Tested on x86_64-linux-gnu, x86_64,aarch64-darwin21. There remain issues with shared libraries, but the link fails are fixed by this. OK for master? Thanks Iain --- 8< --- In the current design the main executable links explicitly to the module registration construtors that it uses. This means that they must be visible in shared libraries. PR modula2/108259 gcc/m2/ChangeLog: * gm2-gcc/m2decl.cc (m2decl_DeclareModuleCtor): Make module registration constructors visible. --- gcc/m2/gm2-gcc/m2decl.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gcc/m2/gm2-gcc/m2decl.cc b/gcc/m2/gm2-gcc/m2decl.cc index 62bfefd2530..d849f8aefc4 100644 --- a/gcc/m2/gm2-gcc/m2decl.cc +++ b/gcc/m2/gm2-gcc/m2decl.cc @@ -276,7 +276,7 @@ m2decl_DeclareModuleCtor (tree decl) /* Declare module_ctor (). */ TREE_PUBLIC (decl) = 1; DECL_ARTIFICIAL (decl) = 1; - DECL_VISIBILITY (decl) = VISIBILITY_HIDDEN; + DECL_VISIBILITY (decl) = VISIBILITY_DEFAULT; DECL_VISIBILITY_SPECIFIED (decl) = 1; DECL_STATIC_CONSTRUCTOR (decl) = 1; return decl;